Feature swaptiles #226
Draft
Feature swaptiles #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A final incomplete PR, I'll leave the rest to you all.
This PR should allow tile swaps for 2x2. This should be pulled in conjunction with the PR in larnd-sim.
The only validation I've done is look at the outputs of
calib_prompt_hits, and the outputs are identical todevelopif I only look at the fields['id', 'x', 'y' 'z', 't_drift', 'ts_pps', 'io_group', 'Q_raw', 'Q', 'E'].calib_final_hits, on the other hand, is not matching withdevelop. I correcteddevelopby addingchannel_threshold_file: 'data/proto_nd_flow/thresholds_2x2.swapped.json'( I believe it was defaulting to the unswapped version before) toyamls/proto_nd_flow/resources/RunDataMC.yaml, but that didn't seem to help. I'll leave that to you...The remaining input files to update are the disabled channels/chips. I don't have the unswapped versions available. @jaafar-chakrani?
The file
2x2.yamlin this repo, the one copied inscripts/proto_nd_scripts/get_proto_nd_input.sh, and the one in the develop branch in larnd-sim, have all diverged a bit. I've kept the2x2.yamlcurled inscripts/proto_nd_scripts/get_proto_nd_input.sh, updated it to include the updatedtile_map, and removed thecurling fromscripts/proto_nd_scripts/get_proto_nd_input.sh.The update in
src/proto_nd_flow/resources/geometry.pytakes into account thattile_mapnow has an entry for each module, instead of only one.I also noticed that the layouts used in
yamls/proto_nd_flow/resources/GeometryData.yamlfor data were slightly outdated, so I also updated those.