chore: switch cppscripts to references and unique_ptrs #1689
+326
−332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
i have some feedback points however mac ci beat me to them. I'd also like to suggest instead making the storage in g_Scripts the unique_ptr that way the only thing that needs to be changed is the body of GetScript with how the new'd script is stored (.reset on a unique_ptr) and how an existing one is returned (.get) |
Collaborator
|
alongside this, please make sure each and every script is actually able to be deleted without issue and have its destructor called. These have never had to have this happen and as such those code paths have not been tested ever. |
Collaborator
|
ignore my first feedback about removing all the make_unique, see #1682 for why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.