Fix "Go Outside and Play" Meta Achievements #1942
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawnreprime
commented
Nov 19, 2025
dawnreprime
commented
- Correct initial value when the next achievement is started
- Enable retroactive data migration for older characters
- Correct initial value when the next achievement is started - Enable retroactive data migration for older characters
Author
Testing:
|
Collaborator
|
I have already resolved this issue on a local branch in a more modular manner. |
Xiphoseer
reviewed
Dec 1, 2025
| if (type == eMissionTaskType::RACING) { | ||
| // The "Go Outside and Play" meta achievements 2-4 | ||
| // These achievements are the only ones in the game that continue their progress instead of starting at zero | ||
| constexpr std::array missionIDs = { 676U, 677U, 678U }; |
Contributor
There was a problem hiding this comment.
New hardcoded database IDs should be avoided (at least outside scripts)
Author
There was a problem hiding this comment.
Ah! Thank you for responding!
Makes sense. Does this fix warrant storing additional data for these 3? Is the idea for future addition?
Author
There was a problem hiding this comment.
I was led to a better solution without storing extra data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.