Fix Achievement Propagation Undefined Behavior #1943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address primary issues in DarkflameUniverse#1941: - Fix undefined behavior during achievement progress algorithm - Avoid iterator invalidation if unordered_map inserts lead to rehash Other changes: - Leverage mission list iteration for functions iterating all missions - Fix const-correctness in various places - Add missing delete in MissionComponent
Author
Extra Notes:The removal case is not triggered by the code section. Testing:Newly added meta achievements no longer gain incorrectly tracked progress on accepting, including edge cases before the next rank with multiple triggered achievements cascading. |
Collaborator
|
I have already resolved this issue on a local branch in a more efficient manner. |
Xiphoseer
reviewed
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address primary issues in #1941:
Other changes: