Skip to content

Fix profile tests for DVB 2017 profile #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
Merged

Fix profile tests for DVB 2017 profile #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b36515e
convert reports into asserts
wschidol Feb 11, 2025
6b3af85
fix profile test for DVB DASH
wschidol Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions DASH/mpdvalidator/schematron/ac4-generic.sch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@
<let name="md_compat" value="$cod[4]"/>

<!-- TS 103190-1, F.1.2.1 -->
<report test="$bs_ver = '00' and @mimeType != ('audio/mp4','video/mp4')">The value of the mimeType attribute shall be set to 'audio/mp4' or 'video/mp4'.</report>
<assert test="$bs_ver != '00' or @mimeType != ('audio/mp4','video/mp4')">The value of the mimeType attribute shall be set to 'audio/mp4' or 'video/mp4'.</assert>
<!-- TS 103190-2, G.2.6 -->
<report test="matches($codecs, 'ac-4\.(01|02)','i') and not(@audioSamplingRate)">@audioSamplingRate shall be set to the sampling frequency derived from the parameters fs_index and
dsi_sf_multiplier, contained in ac4_dsi_v1.</report>
<assert test="not(matches($codecs, 'ac-4\.(01|02)','i')) or @audioSamplingRate">@audioSamplingRate shall be set to the sampling frequency derived from the parameters fs_index and
dsi_sf_multiplier, contained in ac4_dsi_v1.</assert>
<!-- TS 103190-2, G.2.7 -->
<report test="$bs_ver = ('01','02') and @mimeType != 'audio/mp4'">The value of the mimeType attribute shall be set to 'audio/mp4'.</report>
<assert test="$bs_ver != ('01','02') or @mimeType = 'audio/mp4'">The value of the mimeType attribute shall be set to 'audio/mp4'.</assert>
<!-- TS 103190-2, G.2.8 -->
<report test="$bs_ver = ('01','02') and @startWithSAP != '1'">The @startWithSAP value shall be set to '1'.</report>
<assert test="$bs_ver != ('01','02') or @startWithSAP = '1'">The @startWithSAP value shall be set to '1'.</assert>
</rule>
</pattern>

Expand All @@ -50,8 +50,8 @@
<title>Role element for AC-4</title>
<rule context="dash:Role[matches(dlb:getNearestCodecString(.), 'ac-4\.00')]">
<!-- TS 103 190-1 F.1.3.1 -->
<report test="@schemeIdUri = 'urn:mpeg:dash:role:2011' and
not(@value = ('main','alternate','commentary','dub'))">The value of Role (role) shall be main, alternate, commentary.</report>
<assert test="@schemeIdUri != 'urn:mpeg:dash:role:2011' or
@value = ('main','alternate','commentary','dub')">The value of Role (role) shall be main, alternate, commentary.</assert>
</rule>
</pattern>

Expand All @@ -70,17 +70,17 @@

<!-- AC-4 Representations should contain or inherit exactly one AudioChannelConfiguration descriptor -->
<!-- TS 103 190-1, F.1.2.3 -->
<report test="count(ancestor::*/dash:AudioChannelConfiguration[@schemeIdUri = ($NSDLB_acc2014,$NSMPEG_acc)]) &gt; 1" role="warn">
<assert test="count(ancestor::*/dash:AudioChannelConfiguration[@schemeIdUri = ($NSDLB_acc2014,$NSMPEG_acc)]) &lt;= 1" role="warn">
<xsl:text>It is recommended to use exactly one AudioChannelConfiguration element with a schemeIdURI of </xsl:text>
<value-of select="$NSDLB_acc2014"/> or <value-of select="$NSMPEG_acc"/>
</report>
</assert>

<!-- TS 103 190-1, F.1.4.1 -->
<assert test="matches(@value,'^[0-9a-fA-F]{4}$')">The value element shall contain a four-digit hexadecimal representation of the 16-bit field which describes
the channel assignment of the referenced AC-4 elementary stream</assert>
<let name="val6" value="concat('00',@value)"/>
<let name="x" value="dlb:dlb2mpg($val6)"/>
<report test="$x != 0">Use &lt;<name/> schemeIdUri="<value-of select="$NSMPEG_acc"/>" value="<value-of select="$x"/>"/&gt;</report>
<assert test="$x = 0">Use &lt;<name/> schemeIdUri="<value-of select="$NSMPEG_acc"/>" value="<value-of select="$x"/>"/&gt;</assert>
</rule>
</pattern>

Expand All @@ -90,19 +90,19 @@
<!-- check that only specified schemeIdUris are used -->
<!-- TS 103 190-2, G.2.5 -->
<rule context="dash:AudioChannelConfiguration[matches(dlb:getNearestCodecString(.),'ac-4\.(01|02)')][not(@schemeIdUri = ($NSDLB_acc2015,$NSMPEG_acc))]">
<report test="true()" role="warn">
<assert test="false()" role="warn">
Unspecified schemeIdUri in AudioChannelConfiguration element
</report>
</assert>
</rule>

<rule context="dash:AudioChannelConfiguration[matches(dlb:getNearestCodecString(.),'ac-4\.(01|02)')][@schemeIdUri eq $NSDLB_acc2015]">
<!-- TS 103 190-2, G.2.5 -->
<!-- AC-4 Representations should contain or inherit exactly one AudioChannelConfiguration descriptor -->
<report test="count(ancestor::*/dash:AudioChannelConfiguration[@schemeIdUri = ($NSDLB_acc2015,$NSMPEG_acc)]) &gt; 1" role="warn">
<assert test="count(ancestor::*/dash:AudioChannelConfiguration[@schemeIdUri = ($NSDLB_acc2015,$NSMPEG_acc)]) &lt;= 1" role="warn">
<xsl:text>It is recommended to use exactly one AudioChannelConfiguration element with a schemeIdURI of </xsl:text>
<xsl:text></xsl:text>
<value-of select="$NSDLB_acc2015"/> or <value-of select="$NSMPEG_acc"/>
</report>
</assert>

<!-- TS 103 190-2, G.3.1 -->
<!-- AudioChannelConfiguration descriptors with schemeIDUri tag:dolby.com,2014:dash:audio_channel_configuration:2011 shall be of certain format -->
Expand All @@ -111,18 +111,18 @@

<!-- TS 103 190-2, G.2.5 -->
<let name="x" value="dlb:dlb2mpg(@value)"/>
<report test="$x != 0">For all AC-4 channel configurations that are mappable to the MPEG channel configuration scheme, the scheme described by
@schemeIdUri="urn:mpeg:mpegB:cicp:ChannelConfiguration" shall be used</report>
<assert test="$x = 0">For all AC-4 channel configurations that are mappable to the MPEG channel configuration scheme, the scheme described by
@schemeIdUri="urn:mpeg:mpegB:cicp:ChannelConfiguration" shall be used</assert>
</rule>

<rule context="dash:AudioChannelConfiguration[matches(dlb:getNearestCodecString(.),'ac-4\.(01|02)')][@schemeIdUri eq $NSMPEG_acc]">
<!-- TS 103 190-2, G.2.5 -->
<!-- AC-4 Representations should contain or inherit exactly one AudioChannelConfiguration descriptor -->
<report test="count(ancestor::*/dash:AudioChannelConfiguration[@schemeIdUri = ($NSDLB_acc2015,$NSMPEG_acc)]) &gt; 1" role="warn">
<assert test="count(ancestor::*/dash:AudioChannelConfiguration[@schemeIdUri = ($NSDLB_acc2015,$NSMPEG_acc)]) &lt;= 1" role="warn">
<xsl:text>It is recommended to use exactly one AudioChannelConfiguration element with a schemeIdURI of </xsl:text>
<xsl:text></xsl:text>
<value-of select="$NSDLB_acc2015"/> or <value-of select="$NSMPEG_acc"/>
</report>
</assert>

<!-- TS 103 190-2, G.3.2 -->
<!-- AudioChannelConfiguration descriptors with schemeIDUri urn:mpeg:mpegB:cicp:ChannelConfiguration shall be of certain format -->
Expand Down
30 changes: 15 additions & 15 deletions DASH/mpdvalidator/schematron/dvb-dash.sch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,30 +10,30 @@
<pattern>
<title>AdaptationSet element for DVB DASH 2017 profile</title>
<!-- Check the conformance of AdaptationSet -->
<rule context="dash:MPD[$dvbdash-profile-2017 = tokenize(@profiles,' ')]/dash:Period/dash:AdaptationSet[dlb:isAdaptationSetAudio(.)][not(dlb:isAuxiliaryStream(.))]/dash:Representation">
<rule context="dash:MPD[dlb:isProfile(.,$dvbdash-profile-2017)]/dash:Period/dash:AdaptationSet[dlb:isAdaptationSetAudio(.)][not(dlb:isAuxiliaryStream(.))]/dash:Representation">
<!-- see="https://www.etsi.org/deliver/etsi_ts/103200_103299/103285/01.02.01_60/ts_103285v010201p.pdf#page=28" -->
<report test="@mimeType != ancestor::dash:AdaptationSet/dash:Representation/@mimeType">@mimeType shall be common between all Representations in an Adaptation Set</report>
<assert test="@mimeType = ancestor::dash:AdaptationSet/dash:Representation/@mimeType">@mimeType shall be common between all Representations in an Adaptation Set</assert>
<!-- see="https://www.etsi.org/deliver/etsi_ts/103200_103299/103285/01.02.01_60/ts_103285v010201p.pdf#page=28" -->
<report test="@codecs != ancestor::dash:AdaptationSet/dash:Representation/@codecs" role="warn">@codecs should be common between all Representations in an Adaptation Set</report>
<assert test="@codecs = ancestor::dash:AdaptationSet/dash:Representation/@codecs" role="warn">@codecs should be common between all Representations in an Adaptation Set</assert>
<!-- see="https://www.etsi.org/deliver/etsi_ts/103200_103299/103285/01.02.01_60/ts_103285v010201p.pdf#page=28" -->
<report test="@audioSamplingRate != ancestor::dash:AdaptationSet/dash:Representation/@audioSamplingRate" role="warn">@audioSamplingRate should be common between all Representations in an Adaptation Set</report>
<assert test="@audioSamplingRate = ancestor::dash:AdaptationSet/dash:Representation/@audioSamplingRate" role="warn">@audioSamplingRate should be common between all Representations in an Adaptation Set</assert>
</rule>
<rule context="dash:MPD[$dvbdash-profile-2017 = tokenize(@profiles,' ')]/dash:Period/dash:AdaptationSet[dlb:isAdaptationSetAudio(.)][not(dlb:isAuxiliaryStream(.))]/dash:Representation/dash:AudioChannelConfiguration">
<rule context="dash:MPD[dlb:isProfile(.,$dvbdash-profile-2017)]/dash:Period/dash:AdaptationSet[dlb:isAdaptationSetAudio(.)][not(dlb:isAuxiliaryStream(.))]/dash:Representation/dash:AudioChannelConfiguration">
<let name="siu" value="@schemeIdUri"/>
<let name="val" value="@value"/>
<!-- see="https://www.etsi.org/deliver/etsi_ts/103200_103299/103285/01.02.01_60/ts_103285v010201p.pdf#page=28" -->
<report test="$val != ancestor::dash:AdaptationSet/dash:Representation/dash:AudioChannelConfiguration[@schemeIdUri = $siu]/@value" role="warn">audioChannelConfiguration should be common between all Representations in an Adaptation Set</report>
<assert test="$val = ancestor::dash:AdaptationSet/dash:Representation/dash:AudioChannelConfiguration[@schemeIdUri = $siu]/@value" role="warn">audioChannelConfiguration should be common between all Representations in an Adaptation Set</assert>
</rule>
<rule context="dash:MPD[$dvbdash-profile-2017 = tokenize(@profiles,' ')]/dash:Period/dash:AdaptationSet[dlb:isAdaptationSetAudio(.)][dlb:isAuxiliaryStream(.)]">
<rule context="dash:MPD[dlb:isProfile(.,$dvbdash-profile-2017)]/dash:Period/dash:AdaptationSet[dlb:isAdaptationSetAudio(.)][dlb:isAuxiliaryStream(.)]">
<!-- see="https://www.etsi.org/deliver/etsi_ts/103200_103299/103285/01.02.01_60/ts_103285v010201p.pdf#page=37" -->
<report test="dash:AudioChannelConfiguration or dash:Role or dash:Accessibility or @lang">All Adaptation Sets that refer to Auxiliary Audio streams may not contain the @lang attribute and Role,
Accessibility, AudioChannelConfiguration descriptors</report>
<assert test="not(dash:AudioChannelConfiguration or dash:Role or dash:Accessibility or @lang)">All Adaptation Sets that refer to Auxiliary Audio streams may not contain the @lang attribute and Role,
Accessibility, AudioChannelConfiguration descriptors</assert>
</rule>
</pattern>

<pattern>
<title>Preselection element for DVB DASH 2017 profile</title>
<rule context="dash:MPD[$dvbdash-profile-2017 = tokenize(@profiles,' ')]/dash:Period/dash:Preselection[dlb:isAdaptationSetAudio(.)]">
<rule context="dash:MPD[dlb:isProfile(.,$dvbdash-profile-2017)]/dash:Period/dash:Preselection[dlb:isAdaptationSetAudio(.)]">
<assert test="dash:Role[@schemeIdUri='urn:mpeg:dash:role:2011']">Every AC-4 or MPEG-H Audio Preselection element shall include at least one Role element using the scheme
"urn:mpeg:dash:role:2011" as defined in ISO/IEC 23009-1:2019 [1].</assert>

Expand All @@ -43,15 +43,15 @@

<!-- If there is more than one preselection in this bundle, at least one must be main -->
<!-- see="https://www.etsi.org/deliver/etsi_ts/103200_103299/103285/01.02.01_60/ts_103285v010201p.pdf#page=37" -->
<report test="count(../dash:Preselection[$bundleID = tokenize(@preselectionComponents,' ')]) &gt; 1 and not(../dash:Preselection[$bundleID = tokenize(@preselectionComponents,' ')]/dash:Role[@schemeIdUri='urn:mpeg:dash:role:2011'][@value='main'])">If there is more than one audio Preselection associated with an audio bundle, at least one of the Preselection
elements shall be tagged with an @value set to "main".</report>
<assert test="count(../dash:Preselection[$bundleID = tokenize(@preselectionComponents,' ')]) &lt;= 1 or ../dash:Preselection[$bundleID = tokenize(@preselectionComponents,' ')]/dash:Role[@schemeIdUri='urn:mpeg:dash:role:2011'][@value='main']">If there is more than one audio Preselection associated with an audio bundle, at least one of the Preselection
elements shall be tagged with an @value set to "main".</assert>

<!-- ISO/IEC 23009-1, 3rd edition, clause 5.3.11.3 -->
<report test="some $x in tokenize(@preselectionComponents,' ') satisfies not($x = preceding-sibling::dash:AdaptationSet/@id)"
<assert test="every $x in tokenize(@preselectionComponents,' ') satisfies $x = preceding-sibling::dash:AdaptationSet/@id"
diagnostics="preselID">
@preselectionComponents specifies the ids of the contained Adaptation Sets or Content Components that belong to this Preselection
as white space separated list in processing order.
</report>
</assert>
</rule>
</pattern>
<diagnostics>
Expand All @@ -61,7 +61,7 @@
<pattern>
<title>AdaptationSet and Preselection element for AC-4 for DVB DASH 2017 profile</title>
<!-- Check the conformance of AdaptationSet -->
<rule context="dash:MPD[$dvbdash-profile-2017 = tokenize(@profiles,' ')]//*[self::dash:AdaptationSet or self::dash:Preselection or self::Representation][dlb:isAdaptationSetAC4(.)]">
<rule context="dash:MPD[dlb:isProfile(.,$dvbdash-profile-2017)]//*[self::dash:AdaptationSet or self::dash:Preselection or self::Representation][dlb:isAdaptationSetAC4(.)]">
<!-- TS 103190-1, F1.2.1 and TS 103190-2, G2.3 and E.13 -->
<let name="cod" value="tokenize(dlb:getNearestCodecString(.),'\.')"/>
<let name="bs_ver" value="$cod[2]"/>
Expand Down
8 changes: 8 additions & 0 deletions DASH/mpdvalidator/schematron/helper-functions.sch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,14 @@
<xsl:value-of select="$c/ancestor-or-self::*/@codecs[1]"/>
</xsl:function>

<!-- check whether a given element is signaled as included in a given profile
by checking profile strings of the element including its ancestors -->
<xsl:function name="dlb:isProfile" as="xs:boolean">
<xsl:param name="context"/>
<xsl:param name="profile"/>
<xsl:value-of select="some $p in $context/ancestor-or-self::*/@profiles satisfies $profile = tokenize($p,',')"/>
</xsl:function>

<!-- check if the applicable @codecs parameter contains a certain string -->
<xsl:function name="dlb:isAdaptationSetType" as="xs:boolean">
<xsl:param name="x" as="element()"/>
Expand Down