refactor(DASH/IOP): migrate segment validation to representation interface and box classes #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rface and box classes - Add AVCCBox, HVCCBox, NALUnitBox, ELSTBox, TRUNBox, TFDTBox, and SIDXBox in Utils/boxes/ - Add getAVCCBoxes, getHVCCBoxes, getELSTBoxes, getTRUNBoxes, getTFDTBoxes, getSIDXBoxes to RepresentationInterface and implement in isoSegmentRepresentation - Refactor validateSegmentCommon.php and validateSegmentOnDemand.php to use representation getters instead of direct XML/DOM parsing - Refactor validateSegment.php to pass representation instead of XML - Update module.php to use new function signatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors the DASH/IOP module to remove direct XML/DOM parsing from segment validation logic. Instead, it introduces box classes (AVCCBox, HVCCBox, NALUnitBox, ELSTBox, TRUNBox, TFDTBox, SIDXBox) and corresponding getter methods in the RepresentationInterface, implemented in isoSegmentRepresentation.
Key changes
Motivation
This aligns the DASH/IOP module with the refactored modules.
Notes