Fixes for discharging preloaded content #3530
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with using the
preload()function and discharging before it's filled up until buffer target:dischargeFragmentsand bytes_appended events are not sent out for those fragments.chunkis an init segment. It returns the exact same init segment asinitChunk, and so it gets appended twice to the source buffer.You can reproduce both of these by calling preload and attaching a video element quickly after, before you reach the buffer target.