Skip to content

fix DVRWindowSize manifest property #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2021
Merged

fix DVRWindowSize manifest property #3744

merged 2 commits into from
Aug 27, 2021

Conversation

@bbert
Copy link
Contributor

@bbert bbert commented Aug 27, 2021

Sometime manifest.dvrWindowSize was used (instead of manifest.DVRWindowSize)

@dsilhavy
Copy link
Collaborator

dsilhavy commented Aug 27, 2021

@bbert Thanks for the fix. Can we use this opportunity to rename everything to dvrWindowSize. We are using camelCase throughout the whole project we should be consistent here.

@bbert
Copy link
Contributor Author

bbert commented Aug 27, 2021

agree, I do it

@dsilhavy dsilhavy self-requested a review August 27, 2021 11:15
@dsilhavy dsilhavy added this to the 4.1.0 milestone Aug 27, 2021
@dsilhavy dsilhavy merged commit 4ff8a25 into Dash-Industry-Forum:development Aug 27, 2021
@bbert bbert deleted the fix-dvrwindowsize branch September 3, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsilhavy dsilhavy Awaiting requested review from dsilhavy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bbert @dsilhavy