feat: Add settings portalScale and portalMinimum to cap resolution
#4388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the portal is scaled
|
@dsilhavy thanks for changing the base branch, we'll use this for future PRs. Anything you need for us to progress this PR? |
dsilhavy
requested changes
Mar 11, 2024
Contributor
Author
|
@dsilhavy Thanks for the feedback! I don't have capacity to implement the changes you've requested this week, but I've raised a ticket on our end to track implementation once there's capacity |
Collaborator
|
Hi @eirikbjornr did you have the chance to check my comments? |
Contributor
Author
|
Noo – I've not had time to progress this since I replied to your last comments. I'm aiming to make some time for this in the coming 2 weeks! |
Contributor
Author
|
@dsilhavy I've made the changes you requested! What are thoughts on the new changes? Aside: Looks like the CI is still pointed at the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add portalScale to scale the portal size used to calculate the max bandwidth given a view portal's dimensions.
Add portalMinimum to define a limit on how far portalScale can take the bandwidth down.
How
Impl unit tests, update types, update JSDoc.