Integrating Cta608Parser From SVTA's Comon-Media-Library #4522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted this since we are now using Cta608Parser from common-media-library instead
setting Cta608Parser from comon-media-library for adapter to use
Switching to Cta608Parser from common-media-library. Also includes changes that fixes emulation prevention bytes in cea-608 parsing. See Dash-Industry-Forum#3719
new dependency for common-media-library version 0.7.0
correcting unit test for the parser
Configured polyfill for timers to resolve build issues related to xml2js dependency
littlespex
reviewed
Jun 22, 2024
littlespex
reviewed
Jun 22, 2024
dsilhavy
approved these changes
Jun 24, 2024
littlespex
approved these changes
Jun 25, 2024
This was referenced Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates Cta608Parser from common-media-library version 0.7.0 and removes existing
cea-608-parser.jsas its no longer needed.It also includes a fix for handling emulation prevention bytes in CEA-608 parsing from an existing unmerged PR #3719
In addition to all that Cta608Parser from common-media-library includes following fixes in it: