-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Feature/alternative media presentations #4868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sebastianpiq
wants to merge
221
commits into
Dash-Industry-Forum:development
Choose a base branch
from
qualabs:feature/alternative-media-presentations
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/alternative media presentations #4868
sebastianpiq
wants to merge
221
commits into
Dash-Industry-Forum:development
from
qualabs:feature/alternative-media-presentations
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5f340c1.
Update alternative mpd syntaxis
…ack-to-main-content Media manager unit test: switch back to main content
…ve-media-presentations/media-manager-unit-tests
…media-manager-unit-tests Alternative media presentations: media manager unit tests
… log in PlaybackController
…live-to-live-switch-back feat: Implement live to live switch back
* alternative clip functional test vod to vod * small refacotr alternative replace live functional test * add clip live to live test case * fix clip for live to live * Update test/functional/test/feature-support/alternative/alternative-mpd-clip-vod.js Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * remove comment * Update src/streaming/controllers/AlternativeMediaController.js Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * rename deltaTime * remove comments * add missing clear timeouts * add missing done --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…in EventController and AlternativeMediaController
…update-and-listen-mode Add Alternative event update and listen mode
This reverts commit bf31094.
…validity-expiration Revert "Feature MPD update on validity expiration"
Co-authored-by: Sebastian Piquerez <[email protected]>
…listen-mode-sample-page Add Listen Mode sample and update samples.json with new entry
…e correct HTML file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of Alternative Media Presentations as defined in DASH 6 specification. This PR adds support for two new event types that enable dynamic content switching during playback:
Changes
Alternative Events Attributes Support
earliestResolutionTimeOffset: Time before event trigger when alternative media resolution beginsmaxDuration: Maximum duration for alternative contentnoJump: Prevents skipping of eventsclip: Limits alternative content duration to main content durationstartAtPlayhead: Used with non-clip content, alternative content starts offset by the delay from event triggerreturnOffset: Offset applied when returning to main content after alternative content endsCore Changes
earliestResolutionTimeOffset,noJump, and re-triggerable eventsNew Events
alternativeContentStart: Fired when alternative content starts playingalternativeContentEnd: Fired when alternative content finishes playingImplemented Use Cases
Listen Mode Implementation
Using events with
'update'status, the duration of alternative content can be dynamically modified to extend or end earlier than originally planned.Testing
Unit Tests:
Functional Tests:
clipattributenoJumpattributeearliestResolutionTimeOffsetmaxDurationstartAtPlayheadattributeSample Pages
Three example pages have been created to demonstrate the implementation:
alternative-media-presentations.html: General usage exampleslive-to-live.html: Live content with alternative live contentlisten-mode.html: Listen mode demonstrationKnown Issues
This solution uses the
preload()method, which has issues with multi-period assets. Therefore, alternative content cannot be multi-period.