refactor: replace global dashjs.FactoryMaker with ES6 imports #4890
+20
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace all usages of the global `dashjs.FactoryMaker` with proper ES6 module imports across 6 core files. This harmonizes the import pattern with the rest of the codebase and improves module compatibility when dash.js is used as an ES6 module in modern build tools. This prevents issues when: - Importing modules directly without the main entry point - Using tree-shaking in modern bundlers - Integrating dash.js in codebases with strict ES6 module requirements
dsilhavy
approved these changes
Nov 17, 2025
Collaborator
|
Thank you @slhck , added to v5.1.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all usages of the global
dashjs.FactoryMakerwith proper ES6 module imports across 6 core files. This harmonizes the import pattern with the rest of the codebase and improves module compatibility when dash.js is used as an ES6 module in modern build tools.This prevents issues when: