Skip to content

fix: Allow enhancement codecs to be re-tested in Capabilities.js if Settings change #4894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2025
Merged

fix: Allow enhancement codecs to be re-tested in Capabilities.js if Settings change #4894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/streaming/utils/Capabilities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,11 @@ function Capabilities() {
return Promise.resolve();
}

const enhancementCodecs = settings.get().streaming.enhancement.codecs;
if (settings.get().streaming.enhancement.enabled && enhancementCodecs.some(cdc => basicConfiguration.codec.includes(cdc))) {
if (settings.get().streaming.enhancement.enabled && _isEnhancementCodec(basicConfiguration.codec)) {
// Remove enhancement codecs from tested configurations so that they can be re-tested if the enhancement settings change
testedCodecConfigurations = testedCodecConfigurations.filter((configuration) => {
return !_isEnhancementCodec(configuration.mediaSourceCodecString);
});
return Promise.resolve(true);
}

Expand Down Expand Up @@ -355,6 +358,18 @@ function Capabilities() {
})
}

/**
* Check if codec is an enhancement layer codec, e.g. LCEVC
* Enhancement layer codecs can be configured via settings.
* @param {string} codec
* @return {boolean} true if enhancement codec
* @private
*/
function _isEnhancementCodec(codec) {
const enhancementCodecs = settings.get().streaming.enhancement.codecs;
return enhancementCodecs.some((c) => codec.includes(c));
}

function _isConfigSupported(testedConfigurations) {
return testedConfigurations.some((testedConfiguration) => {
return testedConfiguration && testedConfiguration.decodingInfo && testedConfiguration.decodingInfo.supported
Expand Down