feat: Add --writemissingrepdata option (Issue #271) #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta files Implements Issue #271 by adding a new CLI option that selectively generates RepData files only for representations that lack them, avoiding unnecessary regeneration of existing files. This improves efficiency when new assets are added to a VoD root with many existing assets that already have RepData files. Changes: - Added Version field to RepData structure for future format evolution - New --writemissingrepdata CLI flag and configuration option - Updated loadRep logic to conditionally write based on file existence - Added comprehensive test to verify existing files are not touched - Updated all existing tests to pass new parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements Issue #271 by adding a new
--writemissingrepdataCLI option that selectively generates RepData files only for representations that lack them, avoiding unnecessary regeneration of existing files.Changes
--writemissingrepdataCLI option - Generates RepData only when missing, unlike--writerepdatawhich regenerates all filesloadRep()to conditionally write based on file existenceTestWriteMissingRepDatato verify existing files are not touchedBenefits
This improves efficiency when new assets are added to a VoD root with many existing assets that already have RepData files. Instead of regenerating all RepData files (which can be time-consuming for large asset collections), only missing files are generated.
Testing
All existing tests pass, plus a new test specifically verifies:
Usage
# Generate RepData files only for representations that don't have them livesim2 --writemissingrepdata --vodroot ./vod