Skip to content

rte/v1.1.0/specification.md: Describe GPIO pins purpose #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

miczyg1
Copy link
Contributor

@miczyg1 miczyg1 commented Mar 11, 2025

No description provided.

@miczyg1 miczyg1 requested a review from macpijan March 11, 2025 16:04
@macpijan
Copy link
Contributor

macpijan commented Mar 11, 2025

We will have some duplication with: https://docs.dasharo.com/unified-test-documentation/generic-testing-stand-setup/

Maybe we should link from generic test setup to the document you have just modified?

Especially that you are adding now info on power LED, which is not yet covered in generic test setup at all I think.

@miczyg1
Copy link
Contributor Author

miczyg1 commented Mar 11, 2025

We will have some duplication with: https://docs.dasharo.com/unified-test-documentation/generic-testing-stand-setup/

Ohh didn't know that it is already described elsewhere. But still the generic testing stand does not include all the pre-defined OC GPIOs. It is a duplication to some extent, however not entirely.

Maybe we should link from generic test setup to the document you have just modified?

Sounds like a good idea.

Especially that you are adding now info on power LED, which is not yet covered in generic test setup at all I think.

It is not covered, but it should be. I will update the PR.

@miczyg1
Copy link
Contributor Author

miczyg1 commented May 9, 2025

@macpijan Now that I look at it again, we have swapped RST and PWR_BTN pins. Per schematics (and my changes in the PR):

image

PWR_BTN is pin 6 and RST is pin 5, while we use the following in the testing stand setup:

J11 pin 5 PWR_ON#
J11 pin 6 RST#
J15 pin 1 GND

Per the config https://github.com/3mdeb/RteCtrl/blob/master/config/RteCtrl.cfg#L69 we also have the RST first (409 / GPB1) the PWR_BTN (410 / GPB2). osfv_cli seems to use good pins, because it uses IDs as in RteCtrl.cfg:
https://github.com/Dasharo/osfv-scripts/blob/main/osfv_cli/src/osfv/libs/rte.py#L20

Now I wonder how many setups got it wrong...

@miczyg1
Copy link
Contributor Author

miczyg1 commented May 9, 2025

f60178d add the links to RTE spec and add PWR LED signal connection.
9151138 fixes the PWR and RST pin numbering.

@macpijan please review again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants