Skip to content

Conversation

@lucymcnatt
Copy link
Collaborator

Jira ticket: https://broadworkbench.atlassian.net/browse/[ticket_number]

Summary of changes

What

Why

Testing these changes

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

host = apply(ip4s.Ipv4Address.fromInet4Address(addr.getAddress).getOrElse(host)
))
)
req.withUri(newUri). putHeaders(org.http4s.headers.Host(host. renderString))
Copy link
Contributor

@aednichols aednichols Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This strategy is equivalent to alternative 1 in this PR: #2002

It Seems Like It Should Work but it appears Rob found some concrete issues in testing.

Copy link
Contributor

@aednichols aednichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should look at leonardo.dns.ProxyResolver, the Akka path still has support for "proper" DNS.

We use the Akka HTTP client extensively in ProxyService.scala.

In other words, instead of replacing Blaze with Ember, can we replace it with Akka HTTP and remove the other library altogether?

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.11%. Comparing base (30c3ab8) to head (ce0d23e).

Files with missing lines Patch % Lines
...ch/leonardo/http/BaselineDependenciesBuilder.scala 0.00% 7 Missing ⚠️
...itute/dsde/workbench/leonardo/dao/HttpSamDAO.scala 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4889      +/-   ##
===========================================
- Coverage    74.12%   74.11%   -0.01%     
===========================================
  Files          131      131              
  Lines        11064    11065       +1     
  Branches       882      926      +44     
===========================================
  Hits          8201     8201              
- Misses        2863     2864       +1     
Files with missing lines Coverage Δ
...itute/dsde/workbench/leonardo/dao/HttpSamDAO.scala 22.27% <0.00%> (ø)
...ch/leonardo/http/BaselineDependenciesBuilder.scala 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30c3ab8...ce0d23e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants