-
Notifications
You must be signed in to change notification settings - Fork 21
update http4s and wblibs #4889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
update http4s and wblibs #4889
Conversation
| host = apply(ip4s.Ipv4Address.fromInet4Address(addr.getAddress).getOrElse(host) | ||
| )) | ||
| ) | ||
| req.withUri(newUri). putHeaders(org.http4s.headers.Host(host. renderString)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This strategy is equivalent to alternative 1 in this PR: #2002
It Seems Like It Should Work but it appears Rob found some concrete issues in testing.
aednichols
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should look at leonardo.dns.ProxyResolver, the Akka path still has support for "proper" DNS.
We use the Akka HTTP client extensively in ProxyService.scala.
In other words, instead of replacing Blaze with Ember, can we replace it with Akka HTTP and remove the other library altogether?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4889 +/- ##
===========================================
- Coverage 74.12% 74.11% -0.01%
===========================================
Files 131 131
Lines 11064 11065 +1
Branches 882 926 +44
===========================================
Hits 8201 8201
- Misses 2863 2864 +1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Jira ticket: https://broadworkbench.atlassian.net/browse/[ticket_number]
Summary of changes
What
Why
Testing these changes
What to test
Who tested and where
jenkins retestorjenkins multi-test.