Skip to content

AN-659 Temporarily disable memory retry #5362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 16, 2025
Merged

AN-659 Temporarily disable memory retry #5362

merged 4 commits into from
Jul 16, 2025

Conversation

aednichols
Copy link
Contributor

@aednichols aednichols commented Jul 14, 2025

Disable the memory retry control with a view to re-enable it in the future.

Bike shedding Discussion opportunities:

  • Comment out or delete the code
    • Normally I'm on team delete, but we do seem committed to bringing it back soon
  • Leave an empty grid square or rearrange the checkboxes
    • Leave looks a bit silly [0] but I think it's better for muscle memory
  • Leave or delete memory retry value in submission history
    • I went with leave [1], because users may still want to look at pre-disablement workflows

[0]
Screenshot 2025-07-14 at 15 12 08

[1]
Screenshot 2025-07-14 at 15 22 48

@@ -786,8 +786,10 @@ export const WorkflowView = _.flow(
useCallCache,
deleteIntermediateOutputFiles,
useReferenceDisks,
retryWithMoreMemory,
retryMemoryFactor,
// Memory Retry will return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with all your bike shed design choices except can we make the doorknob a slightly different shape (seems more accurate to say it MAY return rather than WILL return).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. (That's a reference, but accuracy comes first.)

JB Will Return

@salonishah11
Copy link
Contributor

Leave an empty grid square or rearrange the checkboxes

I think leaving an empty grid square creates a slightly awkward UX. Maybe we can move Resource Monitoring box to the left?

@aednichols
Copy link
Contributor Author

The issue I see with that is:

  • Memory retry users accidentally clicking the relocated resource monitoring checkbox
  • Resource monitoring users are disoriented because their option is "missing"

And then the reverse when we bring it back.

@aednichols aednichols requested a review from jgainerdewar July 15, 2025 17:11
Copy link

@aednichols aednichols added this pull request to the merge queue Jul 16, 2025
Merged via the queue into dev with commit 394827b Jul 16, 2025
11 checks passed
@aednichols aednichols deleted the aen_an_659 branch July 16, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants