-
Notifications
You must be signed in to change notification settings - Fork 21
AN-659 Temporarily disable memory retry #5362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -786,8 +786,10 @@ export const WorkflowView = _.flow( | |||
useCallCache, | |||
deleteIntermediateOutputFiles, | |||
useReferenceDisks, | |||
retryWithMoreMemory, | |||
retryMemoryFactor, | |||
// Memory Retry will return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with all your bike shed design choices except can we make the doorknob a slightly different shape (seems more accurate to say it MAY return rather than WILL return).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think leaving an empty grid square creates a slightly awkward UX. Maybe we can move Resource Monitoring box to the left? |
The issue I see with that is:
And then the reverse when we bring it back. |
|
Disable the memory retry control with a view to re-enable it in the future.
Bike sheddingDiscussion opportunities:[0]

[1]
