Add optional systemd resolver mount for chaos injectors #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diyarab
force-pushed
the
diyara.bissembayeva/fix/node-dns-resolver
branch
from
03704ef to
08e0f20
Compare
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 0916562 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
diyarab
changed the title
clairecng
reviewed
Dec 19, 2025
| } | ||
|
|
||
| if m.config.Injector.MountSystemdResolve { | ||
| podSpec.Containers[0].VolumeMounts = append(podSpec.Containers[0].VolumeMounts, corev1.VolumeMount{ |
Contributor
There was a problem hiding this comment.
could we add a quick verification that we have at least 1 container in the list?
It should never happen but just in case!
clairecng
reviewed
Dec 19, 2025
| repo: chaos-injector | ||
| annotations: {} # extra annotations passed to the chaos injector pods | ||
| labels: {} # extra labels passed to the chaos injector pods | ||
| mountSystemdResolve: false # bind-mount /run/systemd/resolve/resolv.conf into injector pods |
Contributor
There was a problem hiding this comment.
can you add documentation in the docs/ folder to describe this new field?
Contributor
Author
|
Superseded by PR #1010 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Please briefly describe your changes as well as the motivation behind them:
injector.mountSystemdResolveconfiguration value. When enabled, the chaos injector mounts the host’s/run/systemd/resolve/resolv.confover/mnt/host/etc/resolv.conf, ensuring the node DNS config can be read even when/mnt/host/etc/resolv.confpoints elsewhere. Defaults remain unchanged, so clusters without systemd-resolved continue working as before.Code Quality Checklist
Testing
unittests orend-to-endtests.unittests orend-to-endtests.