[CHAOSPLT-1364] Fix cloud disruption hosts only injected in first chaos pod

[aymericDD]

What does this PR do?

• Adds new functionality
• Alters existing functionality
• Fixes a bug
• Improves documentation or testing

Please briefly describe your changes as well as the motivation behind them:
Bug Fix: Cloud network disruptions (e.g., AWS S3) were only injecting --hosts arguments into the first chaos pod. When multiple targets were selected, subsequent
chaos pods were created without any hosts, causing the disruption to fail partially.

Root Cause: The r.Client.Status().Update(ctx, instance) call in createChaosPods (line 709) overwrites the local instance object with the API server's response.
Since UpdateHostsOnCloudDisruption modifies instance.Spec.Network.Hosts in memory only (not persisted to etcd), the hosts were cleared after the first pod creation.

Solution: Use DeepCopy() before calling Status().Update() to preserve in-memory spec changes. This follows Kubernetes controller-runtime best practices
(cluster-api #1259, controller-runtime
#2850).

BTW: It also fix the flaky test.

Code Quality Checklist

• The documentation is up to date.
• My code is sufficiently commented and passes continuous integration checks.
• I have signed my commit (see Contributing Docs).

Testing

• I leveraged continuous integration testing
  • by depending on existing unit tests or end-to-end tests.
  • by adding new unit tests or end-to-end tests.
• I manually tested the following steps:
  • Reproduction: Created a cloud disruption targeting AWS S3 with 2 target replicas. Before the fix, first chaos pod had 361 --hosts arguments, second pod had 0.
  • Verification: After the fix, both chaos pods receive all 361 cloud service IP ranges.
  • E2E Test: Ran ginkgo --focus "should create a cloud disruption but apply a host disruption with the list of cloud managed service ip ranges" - passes
    successfully.
  • locally.
  • as a canary deployment to a cluster.

[aymericDD]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• [CHAOSPLT-1364] Fix cloud disruption hosts only injected in first chaos pod #1012 👈 (View in Graphite)
• [CHAOSPLT-259] Add percentage-based IP selection for network disruptions  #1011
• [CHAOSPLT-1360] Add DNS resolv.conf path customization for network disruptions #1010
• [CHAOSPLT-1359] Add DNS resolver control #1009
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.