-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hack: enable full dead code elimination in binaries #32527
Draft
pgimalac
wants to merge
9
commits into
main
Choose a base branch
from
pgimalac/fix-go-dce-hack
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component/system-probe
long review
PR is complex, plan time to review it
labels
Dec 26, 2024
pgimalac
added
the
qa/rc-required
Only for a PR that requires validation on the Release Candidate
label
Dec 26, 2024
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=52907511 --os-family=ubuntu Note: This applies to commit 9068e80 |
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog/no-changelog
component/system-probe
do-not-merge/hold
long review
PR is complex, plan time to review it
qa/rc-required
Only for a PR that requires validation on the Release Candidate
team/agent-shared-components
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Try enabling full dead code elimination to see impact on the size of binaries.
Motivation
Binary size reduction, estimated around 25%, as well as RSS reduction (unclear).
Describe how you validated your changes
N/A
Possible Drawbacks / Trade-offs
Additional Notes
This is a hack, I just commented out code to make it work, so no need to code-review this, and do not merge !
I believe the system-probe agent needs other changes to enable to optimization properly, but I didn't check yet.