Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack: enable full dead code elimination in binaries #32527

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

pgimalac
Copy link
Member

@pgimalac pgimalac commented Dec 26, 2024

What does this PR do?

Try enabling full dead code elimination to see impact on the size of binaries.

Motivation

Binary size reduction, estimated around 25%, as well as RSS reduction (unclear).

Describe how you validated your changes

N/A

Possible Drawbacks / Trade-offs

Additional Notes

This is a hack, I just commented out code to make it work, so no need to code-review this, and do not merge !

I believe the system-probe agent needs other changes to enable to optimization properly, but I didn't check yet.

@github-actions github-actions bot added component/system-probe long review PR is complex, plan time to review it labels Dec 26, 2024
@pgimalac pgimalac added the qa/rc-required Only for a PR that requires validation on the Release Candidate label Dec 26, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 26, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52907511 --os-family=ubuntu

Note: This applies to commit 9068e80

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 26, 2024

Uncompressed package size comparison

Comparison with ancestor cd84726951a89e51d46423e0bb5ca17e0fe4b0d9

Diff per package
package diff status size ancestor threshold
datadog-heroku-agent-amd64-deb -0.02MB 532.54MB 532.56MB 0.50MB
datadog-dogstatsd-arm64-deb -11.81MB 44.52MB 56.33MB 0.50MB
datadog-dogstatsd-x86_64-rpm -12.27MB 46.63MB 58.90MB 0.50MB
datadog-dogstatsd-x86_64-suse -12.27MB 46.63MB 58.90MB 0.50MB
datadog-dogstatsd-amd64-deb -12.27MB 46.55MB 58.83MB 0.50MB
datadog-iot-agent-aarch64-rpm -15.55MB 74.43MB 89.98MB 0.50MB
datadog-iot-agent-arm64-deb -15.55MB 74.36MB 89.91MB 0.50MB
datadog-iot-agent-amd64-deb -16.43MB 77.42MB 93.86MB 0.50MB
datadog-iot-agent-x86_64-rpm -16.43MB 77.49MB 93.93MB 0.50MB
datadog-iot-agent-x86_64-suse -16.43MB 77.49MB 93.92MB 0.50MB
datadog-agent-arm64-deb -93.72MB 895.05MB 988.77MB 0.50MB
datadog-agent-aarch64-rpm -93.72MB 904.70MB 998.42MB 0.50MB
datadog-agent-amd64-deb -96.69MB 908.12MB 1004.81MB 0.50MB
datadog-agent-x86_64-rpm -96.69MB 917.79MB 1014.48MB 0.50MB
datadog-agent-x86_64-suse -96.69MB 917.79MB 1014.48MB 0.50MB

Decision

✅ Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe do-not-merge/hold long review PR is complex, plan time to review it qa/rc-required Only for a PR that requires validation on the Release Candidate team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant