Add option to build on non-glibc env #32943
Open
+97
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an build option (`--non-glibc`) to build the agent on non-glibc environment like musl libc. The option disables system-probe gpu module and corechecks gpu collector using `github.com/NVIDIA/go-nvml` which depends on a glibc-extended definition.
ogaca-dd
approved these changes
Jan 14, 2025
maycmlee
approved these changes
Jan 14, 2025
| --- | ||
| enhancements: | ||
| - | | ||
| Add an build option (`--non-glibc`) to build the agent on non-glibc environment like musl libc. |
There was a problem hiding this comment.
Suggested change
| Add an build option (`--non-glibc`) to build the agent on non-glibc environment like musl libc. | |
| Add an build option (`--non-glibc`) to build the Agent on `non-glibc` environment like musl libc. |
brycekahle
requested changes
Jan 14, 2025
| @@ -146,6 +146,7 @@ def build( | |||
| bundle_ebpf=False, | |||
| agent_bin=None, | |||
| run_on=None, # noqa: U100, F841. Used by the run_on_devcontainer decorator | |||
| non_glibc=False, | |||
There was a problem hiding this comment.
I'd prefer a glibc=True argument for the invoke task and have --no-glibc be the command line option that gets you a non-glibc build.
| ): | ||
| """ | ||
| Build the system-probe | ||
| """ | ||
| raise NameError('test') |
| @@ -3,7 +3,7 @@ | |||
| // This product includes software developed at Datadog (https://www.datadoghq.com/). | |||
| // Copyright 2016-present Datadog, Inc. | |||
|
|
|||
| //go:build linux && !arm64 | |||
There was a problem hiding this comment.
Go build tags are usually positive assertions, so let's use a glibc build tag instead and add it to the list of default build tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add an build option (
--non-glibc) to build the agent on non-glibc environment like musl libc.The option disables system-probe gpu module and corechecks gpu collector using
github.com/NVIDIA/go-nvmlwhich depends on a glibc-extended definition.Motivation
(reported at #32942)
Recently added system-probe gpu module and corechecks gpu collector use github.com/NVIDIA/go-nvml which requires glibc.
So, agent can't be built for non-glibc environments like Alpine Linux and Arch Linux which use musl libc.
Describe how you validated your changes
I applied this change as a patch to seqsense/datadog-agent-alpine#134 and confirmed that the build is fixed by setting the option
--non-glibc.Possible Drawbacks / Trade-offs
The doesn't take effect unless setting the option.
Additional Notes