(fleet) repair package when it is reinstalled while a previous installation cannot safely be deleted #35119
+304
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
medium review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes it possible to reinstall packages even if the files from a previous installation of the same version of the package is stil in use. In that case it checks that the directory contains all the expected files and copies any missing file.
The change is scoped to windows for now, to minimise the likelihood of introducing a regression and because that need hasn't surfaced on linux yet.
Motivation
Make package installation more resilient on windows.
Describe how you validated your changes
The new code is unit tested and the behavior of the datadog-installer is checked by numerous E2E tests.
Possible Drawbacks / Trade-offs
This breaks an exisiting behavior that starting an experiment for a package already installed will fail. Is that really a desired property?
Additional Notes