[VULN-1598] Bump go version to 1.24.4 #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustmop
reviewed
Jun 27, 2025
| @@ -14,7 +14,7 @@ jobs: | |||
| golangci: | |||
| strategy: | |||
| matrix: | |||
| go: [1.23] | |||
| go: [1.24] | |||
There was a problem hiding this comment.
The error message you're seeing in the CI is: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24.4). This is because this config file is using golangci-lint version v1.60 which was built using go1.23. I believe we need to change the version to v1.64.2 which you can see adds "go1.24 support" in the Changelog.
There was a problem hiding this comment.
thank you for the catch! i've upgraded golangci-lint to v1.64.2 as suggested, and all of the checks pass now.
There was a problem hiding this comment.
Awesome, glad that worked.
dustmop
approved these changes
Jun 27, 2025
| @@ -14,7 +14,7 @@ jobs: | |||
| golangci: | |||
| strategy: | |||
| matrix: | |||
| go: [1.23] | |||
| go: [1.24] | |||
There was a problem hiding this comment.
Awesome, glad that worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes