[Forwarder] Refactor AWS logs handler into a class #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ge0Aja
force-pushed
the
georgi/logs_handler
branch
2 times, most recently
from
9529841 to
996bad4
Compare
tyrcho
approved these changes
Jun 17, 2024
| for log in logs["logEvents"]: | ||
| yield merge_dicts(log, self.aws_attributes.to_dict()) | ||
|
|
||
| def extract_logs(slef, event): |
There was a problem hiding this comment.
Suggested change
| def extract_logs(slef, event): | |
| def extract_logs(self, event): |
There was a problem hiding this comment.
well, if it works like that, could be a static method instead ?
ge0Aja
force-pushed
the
georgi/logs_handler
branch
from
873d17c to
6090ee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply