Skip to content

AZINTS-2562 Metric Filtering ARM templates #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

aishwarya-ddog
Copy link

@aishwarya-ddog aishwarya-ddog commented Jul 5, 2024

What does this PR do?

Update ARM templates to help update and get metric filters - ie allow users to enable and disable Microsoft resource providers from metric collection.
metrics_config is a json which has one attribute : excluded_resource_providers which takes in a list of Microsoft resource provider name strings.
ARM templates let the users specify excluded metric filters directly. However, we parse it into metrics_config when we make the API call.

Motivation

RFC

https://docs.google.com/document/d/10sDJY0CWCzlAHCvV11DCkmWftTqz2qaxUvI_VYXHmcE/edit?usp=sharing

We are enabling users to set metric filters at resource provider level in the configuration page and through the UI. Translating this capability to ARM templates

Testing Guidelines

Checked the ARM templates created

azure/deploy-to-azure/azure-integration/azuredeploy-managementgroups.json
Screenshot 2024-07-05 at 1 37 34 PM

#816 (comment)
Screenshot 2024-07-05 at 1 40 24 PM

azure/deploy-to-azure/azure-integration/CreateUIDefinition-managementgroups.json
Screenshot 2024-07-05 at 2 39 44 PM

Additional Notes

Types of changes

  • [n] Bug fix
  • [y] New feature
  • [n] Breaking change
  • [n] Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • [y] This PR's description is comprehensive
  • [n] This PR contains breaking changes that are documented in the description
  • [y] This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • [y] This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • [y] This PR's changes are covered by the automated tests
  • [n] This PR collects user input/sensitive content into Datadog
  • [y] This PR passes the integration tests (ask a Datadog member to run the tests)
  • [y] This PR passes the unit tests
  • [y] This PR passes the installation tests (ask a Datadog member to run the tests)

@aishwarya-ddog aishwarya-ddog marked this pull request as ready for review July 5, 2024 09:17
@aishwarya-ddog aishwarya-ddog requested a review from a team as a code owner July 5, 2024 09:17
Copy link
Contributor

@ava-silver ava-silver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we also get a couple screenshots of the UI to show what it looks like?

@ava-silver
Copy link
Contributor

Also want to note here that we should only be merging once this is GA/ready for all customers

@aishwarya-ddog
Copy link
Author

#816 (comment) @ava-silver
Is this a standard practice to not release ARM templates unless fully GA'd for our team? because, from the #api-platform team, it was said to be ok to release beta features on our 3p libraries as long as we note down that it is not a fully GA'd feature.

@aishwarya-ddog aishwarya-ddog requested a review from ava-silver July 5, 2024 18:57
@ava-silver
Copy link
Contributor

including spaces and [] in the list example here is confusing, are we allowing those? i was under the impression that this would be similar to the format of the existing tag filters. if so, could we make the format of these examples align with the existing ones?

@parsons90 parsons90 marked this pull request as draft July 15, 2024 14:55
@ava-silver ava-silver closed this Jul 17, 2024
@ava-silver
Copy link
Contributor

closing so i stop getting pinged, we can re-open later if/when we continue this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants