-
Notifications
You must be signed in to change notification settings - Fork 390
AZINTS-2562 Metric Filtering ARM templates #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we also get a couple screenshots of the UI to show what it looks like?
azure/deploy-to-azure/azure-integration/CreateUIDefinition-managementgroups.json
Outdated
Show resolved
Hide resolved
azure/deploy-to-azure/azure-integration/CreateUIDefinition-managementgroups.json
Outdated
Show resolved
Hide resolved
azure/deploy-to-azure/azure-integration/CreateUIDefinition-managementgroups.json
Show resolved
Hide resolved
azure/deploy-to-azure/azure-integration/CreateUIDefinition.json
Outdated
Show resolved
Hide resolved
azure/deploy-to-azure/azure-integration/azuredeploy-managementgroups.json
Outdated
Show resolved
Hide resolved
azure/deploy-to-azure/azure-integration/azuredeploy-managementgroups.json
Outdated
Show resolved
Hide resolved
azure/deploy-to-azure/azure-integration/azuredeploy-managementgroups.json
Show resolved
Hide resolved
Also want to note here that we should only be merging once this is GA/ready for all customers |
#816 (comment) @ava-silver |
including spaces and |
closing so i stop getting pinged, we can re-open later if/when we continue this work. |
What does this PR do?
Update ARM templates to help update and get metric filters - ie allow users to enable and disable Microsoft resource providers from metric collection.
metrics_config is a json which has one attribute : excluded_resource_providers which takes in a list of Microsoft resource provider name strings.
ARM templates let the users specify excluded metric filters directly. However, we parse it into metrics_config when we make the API call.
Motivation
RFC
https://docs.google.com/document/d/10sDJY0CWCzlAHCvV11DCkmWftTqz2qaxUvI_VYXHmcE/edit?usp=sharing
We are enabling users to set metric filters at resource provider level in the configuration page and through the UI. Translating this capability to ARM templates
Testing Guidelines
Checked the ARM templates created
azure/deploy-to-azure/azure-integration/azuredeploy-managementgroups.json

#816 (comment)

azure/deploy-to-azure/azure-integration/CreateUIDefinition-managementgroups.json

Additional Notes
Types of changes
Check all that apply