Skip to content

refactor(waf): Changing the array manipulation to direct replace to avoid slow… #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

ViBiOh
Copy link
Contributor

@ViBiOh ViBiOh commented Jul 9, 2024

… operation on large array

What does this PR do?

Fix the slow operation on array for WAF(for a 80k item, it's nearly 35ms)

Motivation

WAF log integration is timeouting.

Testing Guidelines

TBD

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@github-actions github-actions bot added the aws label Jul 9, 2024
@ViBiOh ViBiOh marked this pull request as ready for review July 9, 2024 14:29
@ViBiOh ViBiOh requested a review from a team as a code owner July 9, 2024 14:29
@ViBiOh ViBiOh force-pushed the vibioh/fix_slow_array_operations branch from 8024d07 to c7ee02a Compare July 9, 2024 14:57
@ViBiOh ViBiOh changed the title refactor(waf): Changing the array manipulation to yield to avoid slow… refactor(waf): Changing the array manipulation to direct replace to avoid slow… Jul 9, 2024
…void slow operation on large array

Signed-off-by: Vincent Boutour <[email protected]>
@ViBiOh ViBiOh force-pushed the vibioh/fix_slow_array_operations branch from c7ee02a to 52a23f4 Compare July 9, 2024 15:01
@ViBiOh ViBiOh merged commit d57ad61 into master Jul 9, 2024
13 checks passed
@ViBiOh ViBiOh deleted the vibioh/fix_slow_array_operations branch July 9, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants