Skip to content

refactor(logs): Avoid compiling regex many times #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

ViBiOh
Copy link
Contributor

@ViBiOh ViBiOh commented Jul 25, 2024

What does this PR do?

Optimize CPU consumption by compiling the regex only once.

Motivation

Save CPU and cost

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@ViBiOh ViBiOh requested a review from a team as a code owner July 25, 2024 13:13
@github-actions github-actions bot added the aws label Jul 25, 2024
@ViBiOh ViBiOh merged commit a648f34 into master Jul 25, 2024
13 checks passed
@ViBiOh ViBiOh deleted the vibioh/improve_regex_compile branch July 25, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants