-
Notifications
You must be signed in to change notification settings - Fork 390
[AWSX] fix(vpc_flow_log_monitoring) Batch metric series before submission #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1,4 +1,4 @@ | |||
name: Python unit tests | |||
name: AWS Python unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Code Vulnerability
No explicit permissions set for at the workflow level (...read more)
Datadog’s GitHub organization defines default permissions for the GITHUB_TOKEN
to be restricted (contents:read
, metadata:read
, and packages:read
).
Your repository may require a different setup, so consider defining permissions for each job following the least privilege principle to restrict the impact of a possible compromise.
You can find the list of all possible permissions in Workflow syntax for GitHub Actions - GitHub Docs. They can be defined at the job or the workflow level.
78ec7d9
to
14e7601
Compare
b98ca33
to
99491f4
Compare
What does this PR do?
Batch metrics series before submission to honor the max payload value set by the submission endpoint see https://docs.datadoghq.com/api/latest/metrics/#submit-metrics
Remove TTP protocol from map see https://www.iana.org/assignments/protocol-numbers/protocol-numbers.xhtml
Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply