[AWSX] fix(vpc_flow_log_monitoring) Batch metric series before submission#921
Merged
[AWSX] fix(vpc_flow_log_monitoring) Batch metric series before submission#921
Conversation
| @@ -1,4 +1,4 @@ | |||
| name: Python unit tests | |||
| name: AWS Python unit tests | |||
There was a problem hiding this comment.
🟠 Code Vulnerability
No explicit permissions set for at the workflow level (...read more)
Datadog’s GitHub organization defines default permissions for the GITHUB_TOKEN to be restricted (contents:read, metadata:read, and packages:read).
Your repository may require a different setup, so consider defining permissions for each job following the least privilege principle to restrict the impact of a possible compromise.
You can find the list of all possible permissions in Workflow syntax for GitHub Actions - GitHub Docs. They can be defined at the job or the workflow level.
ViBiOh
approved these changes
Mar 21, 2025
78ec7d9 to
14e7601
Compare
b98ca33 to
99491f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Batch metrics series before submission to honor the max payload value set by the submission endpoint see https://docs.datadoghq.com/api/latest/metrics/#submit-metrics
Remove TTP protocol from map see https://www.iana.org/assignments/protocol-numbers/protocol-numbers.xhtml
Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply