Skip to content

[AWSX] fix(vpc_flow_log_monitoring) Batch metric series before submission #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 21, 2025

Conversation

ge0Aja
Copy link
Contributor

@ge0Aja ge0Aja commented Mar 21, 2025

What does this PR do?

Batch metrics series before submission to honor the max payload value set by the submission endpoint see https://docs.datadoghq.com/api/latest/metrics/#submit-metrics

Remove TTP protocol from map see https://www.iana.org/assignments/protocol-numbers/protocol-numbers.xhtml

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@github-actions github-actions bot added the aws label Mar 21, 2025
@ge0Aja ge0Aja marked this pull request as ready for review March 21, 2025 11:45
@ge0Aja ge0Aja requested a review from a team as a code owner March 21, 2025 11:45
@@ -1,4 +1,4 @@
name: Python unit tests
name: AWS Python unit tests

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Code Vulnerability

No explicit permissions set for at the workflow level (...read more)

Datadog’s GitHub organization defines default permissions for the GITHUB_TOKEN to be restricted (contents:read, metadata:read, and packages:read).

Your repository may require a different setup, so consider defining permissions for each job following the least privilege principle to restrict the impact of a possible compromise.

You can find the list of all possible permissions in Workflow syntax for GitHub Actions - GitHub Docs. They can be defined at the job or the workflow level.

View in Datadog  Leave us feedback  Documentation

@ViBiOh ViBiOh self-assigned this Mar 21, 2025
@ge0Aja ge0Aja force-pushed the georgi/vpc-flow-logs-batching branch from 78ec7d9 to 14e7601 Compare March 21, 2025 12:29
@ge0Aja ge0Aja force-pushed the georgi/vpc-flow-logs-batching branch from b98ca33 to 99491f4 Compare March 21, 2025 12:33
@ge0Aja ge0Aja merged commit 575e9df into master Mar 21, 2025
10 checks passed
@ge0Aja ge0Aja deleted the georgi/vpc-flow-logs-batching branch March 21, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants