feat(aws): CLOUDS-5876 Adding a way to override the source #923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ge0Aja
reviewed
Mar 28, 2025
| @@ -141,6 +143,12 @@ def generate_metadata(context): | |||
| ) | |||
| ) | |||
|
|
|||
| if DD_CUSTOM_SOURCE != "": | |||
There was a problem hiding this comment.
I think we can move this to generate_custom_tags function below
There was a problem hiding this comment.
source is not exactly a tag, it's a "root field" in the metadata. It's a bit broader than "custom_tag" I think.
ge0Aja
reviewed
Mar 28, 2025
Signed-off-by: Vincent Boutour <[email protected]>
Signed-off-by: Vincent Boutour <[email protected]>
Signed-off-by: Vincent Boutour <[email protected]>
ViBiOh
force-pushed
the
vibioh/CLOUDS-5876_override_source
branch
from
76953f9 to
dd4904d
Compare
Signed-off-by: Vincent Boutour <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply