Skip to content

[AWSX] Update the documentation on setting the service tag in the forwarder #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

[AWSX] Update the documentation on setting the service tag in the forwarder #933

merged 1 commit into from
Apr 30, 2025

Conversation

ge0Aja
Copy link
Contributor

@ge0Aja ge0Aja commented Apr 30, 2025

What does this PR do?

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@ge0Aja ge0Aja requested a review from a team as a code owner April 30, 2025 11:14
@github-actions github-actions bot added the aws label Apr 30, 2025
@ge0Aja
Copy link
Contributor Author

ge0Aja commented Apr 30, 2025

closes #931

RaphaelAllier
RaphaelAllier reviewed Apr 30, 2025
View reviewed changes
aws/logs_monitoring/README.md Outdated
@@ -585,6 +585,15 @@ The CloudFormation Stack creates following IAM roles:
]
```

## Service Tag Setting
The `service` tag value could be overridden from several sources. These sources have a priority defined in the following order from most to least priority.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rephrase to

The value of the service tag is determined based on multiple inputs. These inputs are ranked by priority from highest to lowest

@ge0Aja ge0Aja force-pushed the georgi/service-tag-doc branch from b181956 to e5f2b93 Compare April 30, 2025 11:55
@ge0Aja ge0Aja force-pushed the georgi/service-tag-doc branch from e5f2b93 to 299c758 Compare April 30, 2025 11:56
@ge0Aja ge0Aja merged commit 4af9f14 into master Apr 30, 2025
10 checks passed
@ge0Aja ge0Aja deleted the georgi/service-tag-doc branch April 30, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaphaelAllier RaphaelAllier RaphaelAllier approved these changes

Assignees
No one assigned
Labels
aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ge0Aja @RaphaelAllier