-
Notifications
You must be signed in to change notification settings - Fork 390
[AZINTS] migrate event hub forwarder to model v4 #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ava-silver
merged 14 commits into
master
from
ava.silver/azints/migrate-event-hub-forwarder-to-model-v4
May 8, 2025
Merged
[AZINTS] migrate event hub forwarder to model v4 #934
ava-silver
merged 14 commits into
master
from
ava.silver/azints/migrate-event-hub-forwarder-to-model-v4
May 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mattsp1290
approved these changes
May 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates to the v4 model, which requires us to explicitly import
@azure/functions
, and also now deploy via zip with a remote build. Open to discuss how we want to store thedeploy.zip
for future maintainability.Worth noting that this is a breaking change since customers can no longer edit in the portal.
Also consolidated the arm templates into just the
eventhub_log_forwarder
templates since the powershell scripts are redundant and we don't need to embed the content.Motivation
node azure functions v3 model is disallowed, we need to migrate to model v4.
Testing Guidelines
Tested by deploying the arm template in the portal:

Test using:

Update the sub template links to point from
master
torefs%2Fheads%2Fava.silver%2Fazints%2Fmigrate-event-hub-forwarder-to-model-v4
, and then:and paste in for the function package uri parameter:
Additional Notes
We'll need to update the documentation since that will no longer be up to date.
I'll make a follow-up PR for that once we merge these changes.
Additionally, we'll need to update the blob forwarder as well since that will also be out of date.
Types of changes
Check all that apply