Skip to content

[AZINTS] migrate event hub forwarder to model v4 #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ava-silver
Copy link
Contributor

@ava-silver ava-silver commented May 6, 2025

What does this PR do?

Updates to the v4 model, which requires us to explicitly import @azure/functions, and also now deploy via zip with a remote build. Open to discuss how we want to store the deploy.zip for future maintainability.

Worth noting that this is a breaking change since customers can no longer edit in the portal.

Also consolidated the arm templates into just the eventhub_log_forwarder templates since the powershell scripts are redundant and we don't need to embed the content.

Motivation

node azure functions v3 model is disallowed, we need to migrate to model v4.

Testing Guidelines

Tested by deploying the arm template in the portal:
image

Test using:
Deploy to Azure

Update the sub template links to point from master to refs%2Fheads%2Fava.silver%2Fazints%2Fmigrate-event-hub-forwarder-to-model-v4, and then:

and paste in for the function package uri parameter:

https://raw.githubusercontent.com/DataDog/datadog-serverless-functions/refs/heads/ava.silver/azints/migrate-event-hub-forwarder-to-model-v4/azure/activity_logs_monitoring/deploy.zip

Additional Notes

We'll need to update the documentation since that will no longer be up to date.

I'll make a follow-up PR for that once we merge these changes.

Additionally, we'll need to update the blob forwarder as well since that will also be out of date.

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ava-silver ava-silver marked this pull request as ready for review May 6, 2025 21:21
@ava-silver ava-silver requested a review from a team as a code owner May 6, 2025 21:21
@ava-silver ava-silver requested review from dor-weid and mattsp1290 May 6, 2025 21:21
Copy link
Member

@mattsp1290 mattsp1290 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!!

@ava-silver ava-silver removed the request for review from dor-weid May 8, 2025 15:03
@ava-silver ava-silver merged commit 4a6658d into master May 8, 2025
10 checks passed
@ava-silver ava-silver deleted the ava.silver/azints/migrate-event-hub-forwarder-to-model-v4 branch May 8, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants