Skip to content

Add support for DD_ENHANCED_METRICS variable in forwarder template #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LorisFriedel
Copy link
Member

What does this PR do?

Update the datadog forwarder template to support the passing of DD_ENHANCED_METRICS boolean.

Motivation

The goal is to be able to enable enhanced metrics for the lambda itself, for better observability of the lambda.

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@LorisFriedel LorisFriedel requested a review from a team as a code owner June 10, 2025 08:26
@github-actions github-actions bot added the aws label Jun 10, 2025
@ge0Aja ge0Aja self-assigned this Jun 10, 2025
@LorisFriedel LorisFriedel requested a review from ge0Aja June 10, 2025 11:36
@RaphaelAllier
Copy link
Member

RaphaelAllier commented Jun 10, 2025

cc @ge0Aja Can you check #687 that the discussions there don't contradict the changes in this PR ? There is a serverless impact to doing this

@ge0Aja
Copy link
Contributor

ge0Aja commented Jun 10, 2025

cc @ge0Aja Can you check #687 that the discussions there don't contradict the changes in this PR ? There is a serverless impact to doing this

Yep, we should be fine, DD_ENHANCED_METRICS=false by default.

Copy link
Contributor

@ge0Aja ge0Aja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LorisFriedel LorisFriedel merged commit bf88011 into master Jun 10, 2025
12 checks passed
@LorisFriedel LorisFriedel deleted the loris.friedel/support-dd-enhanced-metrics-OBSPLTF-436 branch June 10, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants