Remove DdApiKeySecretArn
AllowedPattern
constraints to allow friendly name support in DD forwarder lambda
#956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
To allow the use of the simple (aka friendly) name of the DD API key secret, I'm removing the
AllowedPattern
constraints on theDdApiKeySecretArn
template variable and updating the variable description accordingly.Motivation
This allows to use a naming convention for the secret names and deploy the lambda without having to know the full ARN of the secret. This makes scaling the use of the Datadog Forwarder much easier.
Testing Guidelines
The lambda code is using
boto3.client.get_secret_value(SecretId=<var>)
, which, according to its documentation, allows to retrieve a secret from its ARN or its name (if the secret is in the same account):Types of changes
Check all that apply