Conversation
masci
suggested changes
Jan 24, 2017
Contributor
masci
left a comment
masci
left a comment
There was a problem hiding this comment.
A couple of nitpicks.
Out of curiosity, why do you need the DD_VERSION variable?
| fi | ||
| fi | ||
| $sudo_cmd yum -y --disablerepo='*' --enablerepo='datadog' install datadog-agent || $sudo_cmd yum -y install datadog-agent | ||
| if [ -n "$dd_version" ]; then |
Contributor
There was a problem hiding this comment.
What about assigning dd_agent variable in the if/else block at line 58?
| ***** | ||
| " | ||
| $sudo_cmd apt-get install -y --force-yes datadog-agent | ||
| if [ -n "$dd_version" ]; then |
| echo -e "\033[34m\n* Refreshing repositories\n\033[0m" | ||
| $sudo_cmd zypper --non-interactive refresh | ||
|
|
||
| if [ -n "$dd_version" ]; then |
n0ts
commented
Jan 25, 2017
Contributor
Author
n0ts
left a comment
n0ts
left a comment
There was a problem hiding this comment.
I want to all same datadog agent version in my production servers.
| fi | ||
| fi | ||
| $sudo_cmd yum -y --disablerepo='*' --enablerepo='datadog' install datadog-agent || $sudo_cmd yum -y install datadog-agent | ||
| if [ -n "$dd_version" ]; then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I add DD_VERSION environment variable in datadog agent scripts.
Could you review it?