feat: enable code hotspots reporting for native #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsakeirouz
force-pushed
the
elsa/trace-to-profile-corr
branch
4 times, most recently
from
e0f0057 to
46c683c
Compare
elsakeirouz
commented
Apr 7, 2025
Comment on lines
+586
to
+588
| if traceKey.apmRuntimeID != "" { | ||
| runtimeID = traceKey.apmRuntimeID | ||
| } |
There was a problem hiding this comment.
This is simple for now because we are testing with one instrumented process at a time. This section (and all relative ones) will need to be updated accordingly later.
elsakeirouz
force-pushed
the
elsa/trace-to-profile-corr
branch
2 times, most recently
from
70bc80f to
e2df3d6
Compare
* go.mod, * go.sum, * reporter/datadog_reporter.go: Here.
elsakeirouz
force-pushed
the
elsa/trace-to-profile-corr
branch
from
e2df3d6 to
401509b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO BE UPDATED
What does this PR do?
It makes use of the information newly made available by the ebpf profiler in order to correlate traces and profiles by adding the runtimeID tag and the spanID, transactionID and traceID labels to the profile.
Motivation
This will enable the use of the existing code-hotspots feature for any instrumented code containing the desired data in the specified formats.