[Dynamix Instrumentation] Fix DebuggerUploader adaptive flush interval #7831

dudikeleti · 2025-11-17T15:51:49Z

Summary of changes

Fixes a bug where the adaptive flush interval in DebuggerUploaderBase never actually adapted because the interval was reinitialized on every loop iteration.

Reason for change

This bug caused our debug log to be very noisy with irrelevant messages on every timer interval, regardless of whether the interval changed or not.

dd-trace-dotnet-ci-bot · 2025-11-17T16:51:44Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7831) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	75.40 ± (75.21 - 75.82) ms	75.45 ± (75.55 - 76.36) ms	+0.1%	✅⬆️
.NET Framework 4.8 - Bailout
duration	81.58 ± (81.44 - 82.53) ms	78.97 ± (78.77 - 79.51) ms	-3.2%	✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1138.61 ± (1140.95 - 1155.55) ms	1115.51 ± (1115.37 - 1123.28) ms	-2.0%	✅
.NET Core 3.1 - Baseline
process.internal_duration_ms	23.07 ± (22.99 - 23.15) ms	22.96 ± (22.88 - 23.04) ms	-0.5%	✅
process.time_to_main_ms	87.85 ± (87.49 - 88.21) ms	87.68 ± (87.29 - 88.06) ms	-0.2%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.91 ± (10.91 - 10.92) MB	10.91 ± (10.90 - 10.91) MB	-0.1%	✅
runtime.dotnet.threads.count	12 ± (12 - 12)	12 ± (12 - 12)	+0.0%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	23.00 ± (22.93 - 23.06) ms	23.04 ± (22.95 - 23.12) ms	+0.2%	✅⬆️
process.time_to_main_ms	89.79 ± (89.44 - 90.14) ms	90.33 ± (89.99 - 90.68) ms	+0.6%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.96 ± (10.95 - 10.96) MB	10.95 ± (10.95 - 10.96) MB	-0.0%	✅
runtime.dotnet.threads.count	13 ± (13 - 13)	13 ± (13 - 13)	+0.0%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	220.85 ± (219.50 - 222.19) ms	220.59 ± (219.16 - 222.02) ms	-0.1%	✅
process.time_to_main_ms	553.22 ± (551.95 - 554.49) ms	548.54 ± (547.51 - 549.58) ms	-0.8%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	52.68 ± (52.66 - 52.70) MB	52.48 ± (52.46 - 52.50) MB	-0.4%	✅
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	+0.0%	✅⬆️
.NET 6 - Baseline
process.internal_duration_ms	21.87 ± (21.80 - 21.94) ms	21.60 ± (21.54 - 21.65) ms	-1.2%	✅
process.time_to_main_ms	76.83 ± (76.48 - 77.19) ms	75.85 ± (75.55 - 76.15) ms	-1.3%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.60 ± (10.60 - 10.60) MB	10.62 ± (10.62 - 10.62) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 6 - Bailout
process.internal_duration_ms	21.75 ± (21.68 - 21.81) ms	21.69 ± (21.61 - 21.77) ms	-0.3%	✅
process.time_to_main_ms	78.26 ± (77.89 - 78.63) ms	76.92 ± (76.56 - 77.28) ms	-1.7%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.65 ± (10.65 - 10.66) MB	10.66 ± (10.66 - 10.66) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	211.11 ± (208.47 - 213.76) ms	207.45 ± (206.16 - 208.75) ms	-1.7%	✅
process.time_to_main_ms	520.24 ± (519.15 - 521.33) ms	510.25 ± (509.04 - 511.46) ms	-1.9%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	51.77 ± (51.74 - 51.80) MB	51.65 ± (51.62 - 51.68) MB	-0.2%	✅
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	+0.0%	✅⬆️
.NET 8 - Baseline
process.internal_duration_ms	19.86 ± (19.79 - 19.92) ms	19.96 ± (19.88 - 20.04) ms	+0.5%	✅⬆️
process.time_to_main_ms	74.33 ± (74.02 - 74.64) ms	74.91 ± (74.51 - 75.32) ms	+0.8%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.65 ± (7.65 - 7.66) MB	7.63 ± (7.62 - 7.64) MB	-0.3%	✅
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	20.12 ± (20.06 - 20.18) ms	19.85 ± (19.79 - 19.92) ms	-1.3%	✅
process.time_to_main_ms	78.34 ± (77.94 - 78.73) ms	76.27 ± (75.91 - 76.63) ms	-2.6%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.71 ± (7.71 - 7.72) MB	7.69 ± (7.68 - 7.70) MB	-0.3%	✅
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	192.78 ± (191.82 - 193.75) ms	193.33 ± (192.37 - 194.28) ms	+0.3%	✅⬆️
process.time_to_main_ms	497.55 ± (496.61 - 498.49) ms	489.38 ± (488.23 - 490.53) ms	-1.6%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	39.20 ± (39.16 - 39.23) MB	38.91 ± (38.87 - 38.95) MB	-0.7%	✅
runtime.dotnet.threads.count	27 ± (27 - 27)	27 ± (27 - 27)	-0.0%	✅

HttpMessageHandler

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	192.82 ± (192.99 - 193.93) ms	195.30 ± (194.87 - 195.73) ms	+1.3%	✅⬆️
.NET Framework 4.8 - Bailout
duration	196.33 ± (196.25 - 196.72) ms	199.95 ± (199.51 - 200.55) ms	+1.8%	✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1162.43 ± (1163.08 - 1169.83) ms	1181.97 ± (1184.40 - 1195.04) ms	+1.7%	✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms	188.71 ± (188.29 - 189.12) ms	190.47 ± (190.11 - 190.83) ms	+0.9%	✅⬆️
process.time_to_main_ms	80.87 ± (80.67 - 81.06) ms	81.41 ± (81.20 - 81.63) ms	+0.7%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	16.13 ± (16.10 - 16.16) MB	16.09 ± (16.06 - 16.11) MB	-0.3%	✅
runtime.dotnet.threads.count	20 ± (19 - 20)	20 ± (20 - 20)	+0.3%	✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms	187.69 ± (187.42 - 187.95) ms	191.52 ± (191.07 - 191.98) ms	+2.0%	✅⬆️
process.time_to_main_ms	82.13 ± (81.97 - 82.28) ms	83.58 ± (83.36 - 83.80) ms	+1.8%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	16.20 ± (16.18 - 16.23) MB	16.13 ± (16.11 - 16.15) MB	-0.4%	✅
runtime.dotnet.threads.count	21 ± (21 - 21)	21 ± (21 - 21)	-0.0%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	397.03 ± (394.30 - 399.76) ms	396.46 ± (394.19 - 398.74) ms	-0.1%	✅
process.time_to_main_ms	517.20 ± (516.56 - 517.84) ms	518.94 ± (518.22 - 519.67) ms	+0.3%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	63.00 ± (62.84 - 63.16) MB	63.15 ± (63.00 - 63.29) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	29 ± (29 - 29)	29 ± (29 - 29)	+0.1%	✅⬆️
.NET 6 - Baseline
process.internal_duration_ms	192.64 ± (192.23 - 193.06) ms	193.20 ± (192.84 - 193.55) ms	+0.3%	✅⬆️
process.time_to_main_ms	70.05 ± (69.86 - 70.23) ms	69.96 ± (69.78 - 70.14) ms	-0.1%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.10 ± (15.97 - 16.23) MB	16.08 ± (15.94 - 16.22) MB	-0.1%	✅
runtime.dotnet.threads.count	18 ± (18 - 19)	18 ± (18 - 19)	-0.0%	✅
.NET 6 - Bailout
process.internal_duration_ms	193.08 ± (192.60 - 193.55) ms	191.78 ± (191.44 - 192.12) ms	-0.7%	✅
process.time_to_main_ms	71.24 ± (71.10 - 71.39) ms	71.13 ± (71.00 - 71.27) ms	-0.2%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.40 ± (16.37 - 16.43) MB	16.43 ± (16.39 - 16.46) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	-1.0%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	407.77 ± (404.88 - 410.66) ms	411.95 ± (409.03 - 414.88) ms	+1.0%	✅⬆️
process.time_to_main_ms	486.13 ± (485.54 - 486.72) ms	483.55 ± (482.85 - 484.25) ms	-0.5%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	62.08 ± (61.92 - 62.23) MB	62.18 ± (62.04 - 62.32) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	29 ± (29 - 30)	29 ± (29 - 30)	-0.1%	✅
.NET 8 - Baseline
process.internal_duration_ms	190.14 ± (189.74 - 190.54) ms	190.29 ± (189.94 - 190.64) ms	+0.1%	✅⬆️
process.time_to_main_ms	69.11 ± (68.94 - 69.28) ms	69.44 ± (69.23 - 69.64) ms	+0.5%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.78 ± (11.74 - 11.81) MB	11.71 ± (11.68 - 11.73) MB	-0.6%	✅
runtime.dotnet.threads.count	18 ± (18 - 18)	18 ± (18 - 18)	-1.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	190.37 ± (189.92 - 190.82) ms	189.52 ± (189.23 - 189.80) ms	-0.4%	✅
process.time_to_main_ms	70.46 ± (70.33 - 70.59) ms	70.33 ± (70.20 - 70.45) ms	-0.2%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.82 ± (11.77 - 11.87) MB	11.83 ± (11.80 - 11.85) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	19 ± (19 - 19)	19 ± (19 - 19)	+0.2%	✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	365.47 ± (364.05 - 366.89) ms	361.12 ± (359.50 - 362.75) ms	-1.2%	✅
process.time_to_main_ms	467.54 ± (466.88 - 468.20) ms	458.84 ± (458.02 - 459.66) ms	-1.9%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	50.59 ± (50.55 - 50.63) MB	50.37 ± (50.33 - 50.41) MB	-0.4%	✅
runtime.dotnet.threads.count	29 ± (29 - 29)	29 ± (29 - 29)	+0.3%	✅⬆️

Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts

FakeDbCommand (.NET Framework 4.8)

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7831) - mean (76ms)  : 70, 82
    master - mean (76ms)  : 71, 80

    section Bailout
    This PR (7831) - mean (79ms)  : 73, 85
    master - mean (82ms)  : 74, 90

    section CallTarget+Inlining+NGEN
    This PR (7831) - mean (1,119ms)  : 1063, 1175
    master - mean (1,148ms)  : 1034, 1262

FakeDbCommand (.NET Core 3.1)

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7831) - mean (118ms)  : 110, 126
    master - mean (119ms)  : 111, 127

    section Bailout
    This PR (7831) - mean (121ms)  : 115, 127
    master - mean (120ms)  : 114, 126

    section CallTarget+Inlining+NGEN
    This PR (7831) - mean (804ms)  : 765, 844
    master - mean (811ms)  : 767, 855

FakeDbCommand (.NET 6)

gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7831) - mean (105ms)  : 98, 111
    master - mean (106ms)  : 98, 114

    section Bailout
    This PR (7831) - mean (106ms)  : 99, 113
    master - mean (107ms)  : 100, 114

    section CallTarget+Inlining+NGEN
    This PR (7831) - mean (748ms)  : 707, 789
    master - mean (763ms)  : 712, 814

FakeDbCommand (.NET 8)

gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7831) - mean (103ms)  : 97, 109
    master - mean (103ms)  : 95, 111

    section Bailout
    This PR (7831) - mean (104ms)  : 97, 111
    master - mean (107ms)  : 98, 116

    section CallTarget+Inlining+NGEN
    This PR (7831) - mean (713ms)  : 683, 743
    master - mean (723ms)  : 693, 753

HttpMessageHandler (.NET Framework 4.8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7831) - mean (195ms)  : 190, 200
    master - mean (193ms)  : 188, 199

    section Bailout
    This PR (7831) - mean (200ms)  : 193, 207
    master - mean (196ms)  : 194, 199

    section CallTarget+Inlining+NGEN
    This PR (7831) - mean (1,190ms)  : 1107, 1273
    master - mean (1,166ms)  : 1118, 1215

HttpMessageHandler (.NET Core 3.1)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7831) - mean (281ms)  : 274, 288
    master - mean (278ms)  : 272, 284

    section Bailout
    This PR (7831) - mean (283ms)  : 274, 292
    master - mean (278ms)  : 274, 282

    section CallTarget+Inlining+NGEN
    This PR (7831) - mean (947ms)  : 899, 994
    master - mean (951ms)  : 907, 994

HttpMessageHandler (.NET 6)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7831) - mean (271ms)  : 266, 277
    master - mean (271ms)  : 265, 277

    section Bailout
    This PR (7831) - mean (271ms)  : 266, 275
    master - mean (273ms)  : 267, 278

    section CallTarget+Inlining+NGEN
    This PR (7831) - mean (929ms)  : 879, 979
    master - mean (925ms)  : 878, 971

HttpMessageHandler (.NET 8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7831) - mean (270ms)  : 265, 274
    master - mean (269ms)  : 263, 274

    section Bailout
    This PR (7831) - mean (270ms)  : 266, 274
    master - mean (270ms)  : 264, 276

    section CallTarget+Inlining+NGEN
    This PR (7831) - mean (853ms)  : 832, 874
    master - mean (865ms)  : 845, 885

Fix DebuggerUploaderBase adaptive flush interval

27bc95c

dudikeleti requested a review from a team as a code owner November 17, 2025 15:51

github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:debugger labels Nov 17, 2025

dudikeleti changed the title ~~Fix DebuggerUploaderBase adaptive flush interval~~ [Dynamix Instrumentation] Fix DebuggerUploader adaptive flush interval Nov 17, 2025

tylfin approved these changes Nov 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Dynamix Instrumentation] Fix DebuggerUploader adaptive flush interval #7831

[Dynamix Instrumentation] Fix DebuggerUploader adaptive flush interval #7831

dudikeleti commented Nov 17, 2025 •

edited

Loading

Uh oh!

dd-trace-dotnet-ci-bot bot commented Nov 17, 2025

FakeDbCommand

HttpMessageHandler

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Dynamix Instrumentation] Fix DebuggerUploader adaptive flush interval #7831

Are you sure you want to change the base?

[Dynamix Instrumentation] Fix DebuggerUploader adaptive flush interval #7831

Conversation

dudikeleti commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reason for change

Uh oh!

dd-trace-dotnet-ci-bot bot commented Nov 17, 2025

Execution-Time Benchmarks Report ⏱️

FakeDbCommand

HttpMessageHandler

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dudikeleti commented Nov 17, 2025 •

edited

Loading