[Dynamic Instrumentation] DEBUG-4758 Fix type mismatch with @duration expression #7844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… different (e.g., value type -> object)
This comment has been minimized.
This comment has been minimized.
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7844) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7844) - mean (77ms) : 69, 84
master - mean (75ms) : 71, 79
section Bailout
This PR (7844) - mean (81ms) : 73, 89
master - mean (79ms) : 74, 84
section CallTarget+Inlining+NGEN
This PR (7844) - mean (1,142ms) : 1044, 1240
master - mean (1,133ms) : 1053, 1212
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7844) - mean (120ms) : 112, 129
master - mean (118ms) : 112, 125
section Bailout
This PR (7844) - mean (120ms) : 110, 130
master - mean (121ms) : 113, 128
section CallTarget+Inlining+NGEN
This PR (7844) - mean (808ms) : 772, 844
master - mean (814ms) : 781, 848
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7844) - mean (107ms) : 98, 117
master - mean (108ms) : 102, 114
section Bailout
This PR (7844) - mean (108ms) : 99, 118
master - mean (106ms) : 100, 112
section CallTarget+Inlining+NGEN
This PR (7844) - mean (761ms) : 716, 805
master - mean (757ms) : 721, 792
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7844) - mean (105ms) : 96, 114
master - mean (104ms) : 99, 109
section Bailout
This PR (7844) - mean (107ms) : 100, 115
master - mean (105ms) : 99, 111
section CallTarget+Inlining+NGEN
This PR (7844) - mean (719ms) : 679, 759
master - mean (725ms) : 694, 757
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7844) - mean (194ms) : 190, 199
master - mean (192ms) : 188, 196
section Bailout
This PR (7844) - mean (198ms) : 194, 201
master - mean (195ms) : 193, 197
section CallTarget+Inlining+NGEN
This PR (7844) - mean (1,195ms) : 1121, 1270
master - mean (1,175ms) : 1102, 1248
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7844) - mean (281ms) : 272, 291
master - mean (279ms) : 271, 287
section Bailout
This PR (7844) - mean (280ms) : 272, 287
master - mean (278ms) : 274, 283
section CallTarget+Inlining+NGEN
This PR (7844) - mean (957ms) : 901, 1012
master - mean (944ms) : 898, 991
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7844) - mean (273ms) : 267, 280
master - mean (280ms) : 272, 289
section Bailout
This PR (7844) - mean (275ms) : 263, 287
master - mean (277ms) : 269, 284
section CallTarget+Inlining+NGEN
This PR (7844) - mean (930ms) : 884, 976
master - mean (937ms) : 888, 987
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7844) - mean (273ms) : 265, 280
master - mean (270ms) : 263, 277
section Bailout
This PR (7844) - mean (272ms) : 263, 281
master - mean (268ms) : 265, 271
section CallTarget+Inlining+NGEN
This PR (7844) - mean (860ms) : 835, 885
master - mean (859ms) : 840, 878
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes a bug in the debugger expression parser when compiling expressions with T == object that return value types (e.g. @duration as TimeSpan), causing a runtime error (“Expression of type 'System.TimeSpan' cannot be used for assignment to type 'System.Object'”).
Test coverage
ProbeExpressionParser_ObjectReturnType_AllowsValueTypeResults