[Profiler] Extract StackFramesCollector creation to a factory #8004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area:profiler
gleocadie
force-pushed
the
gleocadie/refactor-stackframescollector
branch
2 times, most recently
from
e397d14 to
24d46df
Compare
gleocadie
force-pushed
the
gleocadie/refactor-stackframescollector
branch
from
24d46df to
1cfafc5
Compare
BenchmarksBenchmark execution time: 2025-12-23 15:53:52 Comparing candidate commit 1cfafc5 in PR branch Found 11 performance improvements and 2 performance regressions! Performance is the same for 158 metrics, 15 unstable metrics. scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1
scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1
|
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8004) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8004) - mean (68ms) : 67, 70
master - mean (69ms) : 67, 70
section Bailout
This PR (8004) - mean (72ms) : 71, 73
master - mean (72ms) : 72, 73
section CallTarget+Inlining+NGEN
This PR (8004) - mean (1,012ms) : 962, 1061
master - mean (1,016ms) : 947, 1084
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8004) - mean (106ms) : 104, 108
master - mean (106ms) : 104, 108
section Bailout
This PR (8004) - mean (107ms) : 106, 108
master - mean (107ms) : 105, 108
section CallTarget+Inlining+NGEN
This PR (8004) - mean (707ms) : 682, 732
master - mean (712ms) : 673, 752
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8004) - mean (93ms) : 91, 95
master - mean (94ms) : 92, 96
section Bailout
This PR (8004) - mean (94ms) : 93, 95
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (8004) - mean (663ms) : 642, 684
master - mean (665ms) : 642, 688
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8004) - mean (92ms) : 89, 95
master - mean (92ms) : 89, 94
section Bailout
This PR (8004) - mean (93ms) : 92, 94
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (8004) - mean (632ms) : 608, 657
master - mean (631ms) : 614, 649
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8004) - mean (194ms) : 191, 198
master - mean (194ms) : 189, 199
section Bailout
This PR (8004) - mean (198ms) : 194, 201
master - mean (198ms) : 195, 200
section CallTarget+Inlining+NGEN
This PR (8004) - mean (1,126ms) : 1048, 1204
master - mean (1,130ms) : 1045, 1215
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8004) - mean (277ms) : 272, 283
master - mean (277ms) : 272, 283
section Bailout
This PR (8004) - mean (277ms) : 273, 281
master - mean (278ms) : 275, 281
section CallTarget+Inlining+NGEN
This PR (8004) - mean (909ms) : 867, 951
master - mean (911ms) : 868, 955
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8004) - mean (271ms) : 266, 276
master - mean (272ms) : 266, 278
section Bailout
This PR (8004) - mean (270ms) : 266, 275
master - mean (271ms) : 267, 274
section CallTarget+Inlining+NGEN
This PR (8004) - mean (891ms) : 847, 935
master - mean (891ms) : 847, 935
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8004) - mean (270ms) : 266, 274
master - mean (271ms) : 266, 275
section Bailout
This PR (8004) - mean (271ms) : 267, 274
master - mean (273ms) : 267, 278
section CallTarget+Inlining+NGEN
This PR (8004) - mean (827ms) : 810, 844
master - mean (827ms) : 811, 844
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
Implementation details
Test coverage
Other details