-
Notifications
You must be signed in to change notification settings - Fork 324
Extract metrics from communication #10399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (310.665 µs) : 286, 335
. : milestone, 311,
basic (273.064 µs) : 267, 279
. : milestone, 273,
loop (8.957 ms) : 8952, 8961
. : milestone, 8957,
section candidate
noprobe (339.29 µs) : 259, 420
. : milestone, 339,
basic (279.558 µs) : 268, 291
. : milestone, 280,
loop (8.931 ms) : 8922, 8940
. : milestone, 8931,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 10 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~4d7ac37ff7, baseline=1.59.0-SNAPSHOT~2a6801efde
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1082770
Total [baseline] (10.822 s) : 0, 10822413
Agent [candidate] (1.088 s) : 0, 1088285
Total [candidate] (10.774 s) : 0, 10773930
section appsec
Agent [baseline] (1.272 s) : 0, 1272168
Total [baseline] (11.017 s) : 0, 11016590
Agent [candidate] (1.295 s) : 0, 1294943
Total [candidate] (11.244 s) : 0, 11243536
section iast
Agent [baseline] (1.231 s) : 0, 1231227
Total [baseline] (11.118 s) : 0, 11117612
Agent [candidate] (1.256 s) : 0, 1255639
Total [candidate] (11.33 s) : 0, 11329622
section profiling
Agent [baseline] (1.202 s) : 0, 1202481
Total [baseline] (10.911 s) : 0, 10910980
Agent [candidate] (1.217 s) : 0, 1216952
Total [candidate] (11.074 s) : 0, 11074048
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~4d7ac37ff7, baseline=1.59.0-SNAPSHOT~2a6801efde
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.172 ms) : 0, 1172
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (649.857 ms) : 0, 649857
BytebuddyAgent [candidate] (650.27 ms) : 0, 650270
AgentMeter [candidate] (34.7 ms) : 0, 34700
GlobalTracer [baseline] (282.605 ms) : 0, 282605
GlobalTracer [candidate] (256.578 ms) : 0, 256578
AppSec [baseline] (32.354 ms) : 0, 32354
AppSec [candidate] (32.52 ms) : 0, 32520
Debugger [baseline] (68.031 ms) : 0, 68031
Debugger [candidate] (68.167 ms) : 0, 68167
Remote Config [baseline] (643.377 µs) : 0, 643
Remote Config [candidate] (633.937 µs) : 0, 634
Telemetry [baseline] (8.918 ms) : 0, 8918
Telemetry [candidate] (9.038 ms) : 0, 9038
Flare Poller [baseline] (3.765 ms) : 0, 3765
Flare Poller [candidate] (3.874 ms) : 0, 3874
section appsec
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (696.024 ms) : 0, 696024
BytebuddyAgent [candidate] (696.75 ms) : 0, 696750
AgentMeter [candidate] (25.737 ms) : 0, 25737
GlobalTracer [baseline] (260.348 ms) : 0, 260348
GlobalTracer [candidate] (264.313 ms) : 0, 264313
AppSec [baseline] (174.743 ms) : 0, 174743
AppSec [candidate] (173.03 ms) : 0, 173030
Debugger [baseline] (65.851 ms) : 0, 65851
Debugger [candidate] (63.766 ms) : 0, 63766
Remote Config [baseline] (751.848 µs) : 0, 752
Remote Config [candidate] (706.748 µs) : 0, 707
Telemetry [baseline] (9.324 ms) : 0, 9324
Telemetry [candidate] (9.095 ms) : 0, 9095
Flare Poller [baseline] (3.712 ms) : 0, 3712
Flare Poller [candidate] (3.529 ms) : 0, 3529
IAST [baseline] (24.72 ms) : 0, 24720
IAST [candidate] (25.273 ms) : 0, 25273
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (796.871 ms) : 0, 796871
BytebuddyAgent [candidate] (795.653 ms) : 0, 795653
AgentMeter [candidate] (28.16 ms) : 0, 28160
GlobalTracer [baseline] (258.161 ms) : 0, 258161
GlobalTracer [candidate] (260.978 ms) : 0, 260978
AppSec [baseline] (34.229 ms) : 0, 34229
AppSec [candidate] (30.559 ms) : 0, 30559
Debugger [baseline] (65.48 ms) : 0, 65480
Debugger [candidate] (65.832 ms) : 0, 65832
Remote Config [baseline] (590.482 µs) : 0, 590
Remote Config [candidate] (622.91 µs) : 0, 623
Telemetry [baseline] (8.437 ms) : 0, 8437
Telemetry [candidate] (8.369 ms) : 0, 8369
Flare Poller [baseline] (3.518 ms) : 0, 3518
Flare Poller [candidate] (3.41 ms) : 0, 3410
IAST [baseline] (27.234 ms) : 0, 27234
IAST [candidate] (29.531 ms) : 0, 29531
section profiling
ProfilingAgent [baseline] (96.729 ms) : 0, 96729
ProfilingAgent [candidate] (93.995 ms) : 0, 93995
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (700.698 ms) : 0, 700698
BytebuddyAgent [candidate] (709.888 ms) : 0, 709888
AgentMeter [candidate] (13.616 ms) : 0, 13616
GlobalTracer [baseline] (220.804 ms) : 0, 220804
GlobalTracer [candidate] (217.5 ms) : 0, 217500
AppSec [baseline] (32.157 ms) : 0, 32157
AppSec [candidate] (33.254 ms) : 0, 33254
Debugger [baseline] (67.785 ms) : 0, 67785
Debugger [candidate] (67.865 ms) : 0, 67865
Remote Config [baseline] (662.072 µs) : 0, 662
Remote Config [candidate] (620.197 µs) : 0, 620
Telemetry [baseline] (8.977 ms) : 0, 8977
Telemetry [candidate] (8.616 ms) : 0, 8616
Flare Poller [baseline] (3.781 ms) : 0, 3781
Flare Poller [candidate] (3.637 ms) : 0, 3637
Profiling [baseline] (97.312 ms) : 0, 97312
Profiling [candidate] (94.566 ms) : 0, 94566
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~4d7ac37ff7, baseline=1.59.0-SNAPSHOT~2a6801efde
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084132
Total [baseline] (8.776 s) : 0, 8775585
Agent [candidate] (1.087 s) : 0, 1086885
Total [candidate] (8.76 s) : 0, 8760091
section iast
Agent [baseline] (1.221 s) : 0, 1221114
Total [baseline] (9.377 s) : 0, 9376614
Agent [candidate] (1.25 s) : 0, 1249634
Total [candidate] (9.372 s) : 0, 9372498
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~4d7ac37ff7, baseline=1.59.0-SNAPSHOT~2a6801efde
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (651.762 ms) : 0, 651762
BytebuddyAgent [candidate] (650.428 ms) : 0, 650428
AgentMeter [candidate] (34.613 ms) : 0, 34613
GlobalTracer [baseline] (282.799 ms) : 0, 282799
GlobalTracer [candidate] (256.337 ms) : 0, 256337
AppSec [baseline] (32.609 ms) : 0, 32609
AppSec [candidate] (32.34 ms) : 0, 32340
Debugger [baseline] (66.922 ms) : 0, 66922
Debugger [candidate] (67.098 ms) : 0, 67098
Remote Config [baseline] (664.575 µs) : 0, 665
Remote Config [candidate] (607.541 µs) : 0, 608
Telemetry [baseline] (8.983 ms) : 0, 8983
Telemetry [candidate] (9.144 ms) : 0, 9144
Flare Poller [baseline] (3.766 ms) : 0, 3766
Flare Poller [candidate] (3.829 ms) : 0, 3829
section iast
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (790.2 ms) : 0, 790200
BytebuddyAgent [candidate] (792.899 ms) : 0, 792899
AgentMeter [candidate] (28.004 ms) : 0, 28004
GlobalTracer [baseline] (255.715 ms) : 0, 255715
GlobalTracer [candidate] (259.068 ms) : 0, 259068
AppSec [baseline] (34.971 ms) : 0, 34971
AppSec [candidate] (30.566 ms) : 0, 30566
Debugger [baseline] (63.941 ms) : 0, 63941
Debugger [candidate] (64.842 ms) : 0, 64842
Remote Config [baseline] (581.145 µs) : 0, 581
Remote Config [candidate] (576.35 µs) : 0, 576
Telemetry [baseline] (8.56 ms) : 0, 8560
Telemetry [candidate] (8.444 ms) : 0, 8444
Flare Poller [baseline] (3.622 ms) : 0, 3622
Flare Poller [candidate] (3.47 ms) : 0, 3470
IAST [baseline] (26.967 ms) : 0, 26967
IAST [candidate] (29.263 ms) : 0, 29263
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~4d7ac37ff7, baseline=1.59.0-SNAPSHOT~2a6801efde
dateFormat X
axisFormat %s
section baseline
no_agent (17.895 ms) : 17717, 18073
. : milestone, 17895,
appsec (18.647 ms) : 18459, 18835
. : milestone, 18647,
code_origins (17.611 ms) : 17436, 17787
. : milestone, 17611,
iast (19.084 ms) : 18889, 19278
. : milestone, 19084,
profiling (18.802 ms) : 18613, 18991
. : milestone, 18802,
tracing (17.478 ms) : 17306, 17649
. : milestone, 17478,
section candidate
no_agent (17.515 ms) : 17337, 17693
. : milestone, 17515,
appsec (19.17 ms) : 18973, 19367
. : milestone, 19170,
code_origins (19.332 ms) : 19133, 19532
. : milestone, 19332,
iast (19.496 ms) : 19300, 19691
. : milestone, 19496,
profiling (19.931 ms) : 19730, 20133
. : milestone, 19931,
tracing (18.313 ms) : 18127, 18498
. : milestone, 18313,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~4d7ac37ff7, baseline=1.59.0-SNAPSHOT~2a6801efde
dateFormat X
axisFormat %s
section baseline
no_agent (1.173 ms) : 1162, 1185
. : milestone, 1173,
iast (3.22 ms) : 3177, 3263
. : milestone, 3220,
iast_FULL (5.682 ms) : 5626, 5739
. : milestone, 5682,
iast_GLOBAL (3.577 ms) : 3525, 3628
. : milestone, 3577,
profiling (2.005 ms) : 1988, 2023
. : milestone, 2005,
tracing (1.829 ms) : 1814, 1844
. : milestone, 1829,
section candidate
no_agent (1.192 ms) : 1181, 1204
. : milestone, 1192,
iast (3.215 ms) : 3175, 3256
. : milestone, 3215,
iast_FULL (5.661 ms) : 5605, 5717
. : milestone, 5661,
iast_GLOBAL (3.6 ms) : 3541, 3659
. : milestone, 3600,
profiling (1.959 ms) : 1942, 1976
. : milestone, 1959,
tracing (1.76 ms) : 1745, 1775
. : milestone, 1760,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~4d7ac37ff7, baseline=1.59.0-SNAPSHOT~2a6801efde
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.736 ms) : 3514, 3958
. : milestone, 3736,
iast (2.23 ms) : 2165, 2295
. : milestone, 2230,
iast_GLOBAL (2.265 ms) : 2200, 2330
. : milestone, 2265,
profiling (2.109 ms) : 2054, 2164
. : milestone, 2109,
tracing (2.048 ms) : 1996, 2099
. : milestone, 2048,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (2.523 ms) : 2468, 2579
. : milestone, 2523,
iast (2.219 ms) : 2154, 2284
. : milestone, 2219,
iast_GLOBAL (2.257 ms) : 2191, 2323
. : milestone, 2257,
profiling (2.103 ms) : 2048, 2157
. : milestone, 2103,
tracing (2.058 ms) : 2006, 2110
. : milestone, 2058,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~4d7ac37ff7, baseline=1.59.0-SNAPSHOT~2a6801efde
dateFormat X
axisFormat %s
section baseline
no_agent (15.116 s) : 15116000, 15116000
. : milestone, 15116000,
appsec (14.875 s) : 14875000, 14875000
. : milestone, 14875000,
iast (17.846 s) : 17846000, 17846000
. : milestone, 17846000,
iast_GLOBAL (17.884 s) : 17884000, 17884000
. : milestone, 17884000,
profiling (15.004 s) : 15004000, 15004000
. : milestone, 15004000,
tracing (14.743 s) : 14743000, 14743000
. : milestone, 14743000,
section candidate
no_agent (15.634 s) : 15634000, 15634000
. : milestone, 15634000,
appsec (14.931 s) : 14931000, 14931000
. : milestone, 14931000,
iast (18.314 s) : 18314000, 18314000
. : milestone, 18314000,
iast_GLOBAL (18.201 s) : 18201000, 18201000
. : milestone, 18201000,
profiling (15.064 s) : 15064000, 15064000
. : milestone, 15064000,
tracing (15.319 s) : 15319000, 15319000
. : milestone, 15319000,
|
What Does This Do
This PR is a try at extracting various concerns from the
:communicationmodule.It all started when trying to move the
datadog.communication.monitorpackage from:communicationmodule to a dedicated module. The rest is only the required changed to make it work even if it grew bigger that wanted.Motivation
The
:communicationmodule is going under a redo this quarter to provide clear API for intake communications.Additional Notes
There might be more to extract from
:internal-apiand:dd-trace-coreto the new metrics module but I want to start "small".Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]