-
Notifications
You must be signed in to change notification settings - Fork 324
Introduce @AppliesOn to override advices InstrumenterModule target system #10404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
amarziali
wants to merge
2
commits into
master
Choose a base branch
from
andrea.marziali/advice-index
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~c38294a906, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084012
Total [baseline] (8.766 s) : 0, 8765566
Agent [candidate] (1.096 s) : 0, 1095855
Total [candidate] (8.784 s) : 0, 8784048
section iast
Agent [baseline] (1.228 s) : 0, 1227791
Total [baseline] (9.39 s) : 0, 9389634
Agent [candidate] (1.236 s) : 0, 1236498
Total [candidate] (9.334 s) : 0, 9333882
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~c38294a906, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (651.23 ms) : 0, 651230
BytebuddyAgent [candidate] (663.329 ms) : 0, 663329
GlobalTracer [baseline] (283.008 ms) : 0, 283008
GlobalTracer [candidate] (282.765 ms) : 0, 282765
AppSec [baseline] (32.624 ms) : 0, 32624
AppSec [candidate] (32.473 ms) : 0, 32473
Debugger [baseline] (66.956 ms) : 0, 66956
Debugger [candidate] (67.215 ms) : 0, 67215
Remote Config [baseline] (638.418 µs) : 0, 638
Remote Config [candidate] (635.31 µs) : 0, 635
Telemetry [baseline] (8.963 ms) : 0, 8963
Telemetry [candidate] (8.88 ms) : 0, 8880
Flare Poller [baseline] (3.794 ms) : 0, 3794
Flare Poller [candidate] (3.849 ms) : 0, 3849
section iast
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (794.183 ms) : 0, 794183
BytebuddyAgent [candidate] (803.255 ms) : 0, 803255
GlobalTracer [baseline] (257.483 ms) : 0, 257483
GlobalTracer [candidate] (257.31 ms) : 0, 257310
AppSec [baseline] (33.866 ms) : 0, 33866
AppSec [candidate] (34.454 ms) : 0, 34454
Debugger [baseline] (65.69 ms) : 0, 65690
Debugger [candidate] (65.205 ms) : 0, 65205
Remote Config [baseline] (569.27 µs) : 0, 569
Remote Config [candidate] (583.484 µs) : 0, 583
Telemetry [baseline] (8.521 ms) : 0, 8521
Telemetry [candidate] (8.482 ms) : 0, 8482
Flare Poller [baseline] (3.601 ms) : 0, 3601
Flare Poller [candidate] (3.571 ms) : 0, 3571
IAST [baseline] (27.142 ms) : 0, 27142
IAST [candidate] (26.911 ms) : 0, 26911
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~c38294a906, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088126
Total [baseline] (10.808 s) : 0, 10807564
Agent [candidate] (1.096 s) : 0, 1096479
Total [candidate] (10.862 s) : 0, 10861895
section appsec
Agent [baseline] (1.267 s) : 0, 1267442
Total [baseline] (11.16 s) : 0, 11160023
Agent [candidate] (1.282 s) : 0, 1281911
Total [candidate] (11.111 s) : 0, 11111314
section iast
Agent [baseline] (1.226 s) : 0, 1226460
Total [baseline] (11.256 s) : 0, 11255817
Agent [candidate] (1.239 s) : 0, 1238528
Total [candidate] (11.2 s) : 0, 11199925
section profiling
Agent [baseline] (1.208 s) : 0, 1207740
Total [baseline] (10.873 s) : 0, 10872629
Agent [candidate] (1.216 s) : 0, 1215853
Total [candidate] (10.921 s) : 0, 10920536
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~c38294a906, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (653.339 ms) : 0, 653339
BytebuddyAgent [candidate] (663.114 ms) : 0, 663114
GlobalTracer [baseline] (283.582 ms) : 0, 283582
GlobalTracer [candidate] (283.124 ms) : 0, 283124
AppSec [baseline] (32.737 ms) : 0, 32737
AppSec [candidate] (32.603 ms) : 0, 32603
Debugger [baseline] (68.193 ms) : 0, 68193
Debugger [candidate] (67.554 ms) : 0, 67554
Remote Config [baseline] (655.976 µs) : 0, 656
Remote Config [candidate] (626.264 µs) : 0, 626
Telemetry [baseline] (8.972 ms) : 0, 8972
Telemetry [candidate] (8.836 ms) : 0, 8836
Flare Poller [baseline] (3.792 ms) : 0, 3792
Flare Poller [candidate] (3.837 ms) : 0, 3837
section appsec
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (692.232 ms) : 0, 692232
BytebuddyAgent [candidate] (704.58 ms) : 0, 704580
GlobalTracer [baseline] (259.551 ms) : 0, 259551
GlobalTracer [candidate] (260.346 ms) : 0, 260346
IAST [baseline] (24.515 ms) : 0, 24515
IAST [candidate] (24.603 ms) : 0, 24603
AppSec [baseline] (171.61 ms) : 0, 171610
AppSec [candidate] (174.24 ms) : 0, 174240
Debugger [baseline] (68.629 ms) : 0, 68629
Debugger [candidate] (67.777 ms) : 0, 67777
Remote Config [baseline] (809.672 µs) : 0, 810
Remote Config [candidate] (722.6 µs) : 0, 723
Telemetry [baseline] (9.503 ms) : 0, 9503
Telemetry [candidate] (9.212 ms) : 0, 9212
Flare Poller [baseline] (3.811 ms) : 0, 3811
Flare Poller [candidate] (3.751 ms) : 0, 3751
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (792.234 ms) : 0, 792234
BytebuddyAgent [candidate] (804.204 ms) : 0, 804204
GlobalTracer [baseline] (257.24 ms) : 0, 257240
GlobalTracer [candidate] (257.102 ms) : 0, 257102
IAST [baseline] (27.042 ms) : 0, 27042
IAST [candidate] (26.854 ms) : 0, 26854
AppSec [baseline] (35.129 ms) : 0, 35129
AppSec [candidate] (34.727 ms) : 0, 34727
Debugger [baseline] (65.547 ms) : 0, 65547
Debugger [candidate] (66.142 ms) : 0, 66142
Remote Config [baseline] (578.09 µs) : 0, 578
Remote Config [candidate] (611.176 µs) : 0, 611
Telemetry [baseline] (8.468 ms) : 0, 8468
Telemetry [candidate] (8.559 ms) : 0, 8559
Flare Poller [baseline] (3.541 ms) : 0, 3541
Flare Poller [candidate] (3.552 ms) : 0, 3552
section profiling
crashtracking [baseline] (1.227 ms) : 0, 1227
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (704.316 ms) : 0, 704316
BytebuddyAgent [candidate] (713.057 ms) : 0, 713057
GlobalTracer [baseline] (221.586 ms) : 0, 221586
GlobalTracer [candidate] (221.168 ms) : 0, 221168
AppSec [baseline] (32.3 ms) : 0, 32300
AppSec [candidate] (32.274 ms) : 0, 32274
Debugger [baseline] (68.027 ms) : 0, 68027
Debugger [candidate] (67.277 ms) : 0, 67277
Remote Config [baseline] (634.831 µs) : 0, 635
Remote Config [candidate] (681.929 µs) : 0, 682
Telemetry [baseline] (8.974 ms) : 0, 8974
Telemetry [candidate] (8.593 ms) : 0, 8593
Flare Poller [baseline] (3.807 ms) : 0, 3807
Flare Poller [candidate] (3.613 ms) : 0, 3613
ProfilingAgent [baseline] (96.871 ms) : 0, 96871
ProfilingAgent [candidate] (98.199 ms) : 0, 98199
Profiling [baseline] (97.444 ms) : 0, 97444
Profiling [candidate] (98.78 ms) : 0, 98780
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 4 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~c38294a906, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section baseline
no_agent (1.196 ms) : 1184, 1208
. : milestone, 1196,
iast (3.214 ms) : 3167, 3261
. : milestone, 3214,
iast_FULL (5.748 ms) : 5691, 5804
. : milestone, 5748,
iast_GLOBAL (3.608 ms) : 3551, 3664
. : milestone, 3608,
profiling (2.102 ms) : 2082, 2121
. : milestone, 2102,
tracing (1.843 ms) : 1828, 1858
. : milestone, 1843,
section candidate
no_agent (1.189 ms) : 1178, 1200
. : milestone, 1189,
iast (3.423 ms) : 3376, 3471
. : milestone, 3423,
iast_FULL (6.122 ms) : 6060, 6185
. : milestone, 6122,
iast_GLOBAL (3.675 ms) : 3620, 3730
. : milestone, 3675,
profiling (2.047 ms) : 2030, 2065
. : milestone, 2047,
tracing (1.904 ms) : 1888, 1920
. : milestone, 1904,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~c38294a906, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section baseline
no_agent (17.956 ms) : 17771, 18142
. : milestone, 17956,
appsec (18.665 ms) : 18476, 18854
. : milestone, 18665,
code_origins (19.476 ms) : 19277, 19676
. : milestone, 19476,
iast (17.903 ms) : 17723, 18083
. : milestone, 17903,
profiling (18.84 ms) : 18647, 19033
. : milestone, 18840,
tracing (17.806 ms) : 17625, 17987
. : milestone, 17806,
section candidate
no_agent (18.23 ms) : 18038, 18421
. : milestone, 18230,
appsec (18.393 ms) : 18206, 18579
. : milestone, 18393,
code_origins (17.761 ms) : 17581, 17940
. : milestone, 17761,
iast (17.799 ms) : 17623, 17976
. : milestone, 17799,
profiling (18.884 ms) : 18694, 19074
. : milestone, 18884,
tracing (17.601 ms) : 17427, 17775
. : milestone, 17601,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~c38294a906, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.735 ms) : 3514, 3957
. : milestone, 3735,
iast (2.211 ms) : 2146, 2276
. : milestone, 2211,
iast_GLOBAL (2.258 ms) : 2193, 2324
. : milestone, 2258,
profiling (2.063 ms) : 2011, 2116
. : milestone, 2063,
tracing (2.046 ms) : 1995, 2097
. : milestone, 2046,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.731 ms) : 3512, 3950
. : milestone, 3731,
iast (2.219 ms) : 2154, 2285
. : milestone, 2219,
iast_GLOBAL (2.246 ms) : 2181, 2312
. : milestone, 2246,
profiling (2.049 ms) : 1997, 2101
. : milestone, 2049,
tracing (2.041 ms) : 1989, 2092
. : milestone, 2041,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~c38294a906, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section baseline
no_agent (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
appsec (14.616 s) : 14616000, 14616000
. : milestone, 14616000,
iast (17.672 s) : 17672000, 17672000
. : milestone, 17672000,
iast_GLOBAL (18.037 s) : 18037000, 18037000
. : milestone, 18037000,
profiling (15.195 s) : 15195000, 15195000
. : milestone, 15195000,
tracing (14.801 s) : 14801000, 14801000
. : milestone, 14801000,
section candidate
no_agent (15.542 s) : 15542000, 15542000
. : milestone, 15542000,
appsec (14.613 s) : 14613000, 14613000
. : milestone, 14613000,
iast (18.397 s) : 18397000, 18397000
. : milestone, 18397000,
iast_GLOBAL (17.934 s) : 17934000, 17934000
. : milestone, 17934000,
profiling (14.803 s) : 14803000, 14803000
. : milestone, 14803000,
tracing (14.746 s) : 14746000, 14746000
. : milestone, 14746000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]