Enforce size limit on application_monitoring.yaml files #8789

mtoffl01 · 2025-05-08T19:31:34Z

What Does This Do

Introduces a file size limit (256 KB) to limit the maximum "hands off" configuration file size that we will read.

Motivation

Protection against corrupted files and maintain performance.
See: RFC

The value (256 KB) was determined by taking the size of a sample "hands off" configuration file with both apm_configuration_default and apm_configuration_rules (phase 1 and phase 2 inputs, respectively), multiplying it by 100 * 2. This value may change, or may become configurable, in the future depending on where phase 2 specifications land.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

…rying key-vals

…ith tests

…values in template variable

pr-commenter · 2025-05-08T20:25:10Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/scfg_file_size_limit
git_commit_date	1746692171	1746732774
git_commit_sha	`d5d53cd`	`6bcada2`
release_version	1.50.0-SNAPSHOT~d5d53cd553	1.50.0-SNAPSHOT~6bcada273a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1746735878	1746735878
ci_job_id	930478070	930478070
ci_pipeline_id	64572419	64572419
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-psrqmy6d-project-304-concurrent-0-uko4c9uu 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-psrqmy6d-project-304-concurrent-0-uko4c9uu 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 16 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~6bcada273a, baseline=1.50.0-SNAPSHOT~d5d53cd553

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1021158
Total [baseline] (10.457 s) : 0, 10456802
Agent [candidate] (1.026 s) : 0, 1025758
Total [candidate] (10.596 s) : 0, 10595938
section appsec
Agent [baseline] (1.161 s) : 0, 1160860
Total [baseline] (10.656 s) : 0, 10655740
Agent [candidate] (1.166 s) : 0, 1165895
Total [candidate] (10.691 s) : 0, 10690747
section iast
Agent [baseline] (1.15 s) : 0, 1149929
Total [baseline] (11.044 s) : 0, 11043896
Agent [candidate] (1.162 s) : 0, 1161715
Total [candidate] (10.986 s) : 0, 10986476
section profiling
Agent [baseline] (1.28 s) : 0, 1279983
Total [baseline] (10.906 s) : 0, 10906171
Agent [candidate] (1.286 s) : 0, 1286032
Total [candidate] (10.904 s) : 0, 10903540

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.021 s	-
Agent	appsec	1.161 s	139.702 ms (13.7%)
Agent	iast	1.15 s	128.771 ms (12.6%)
Agent	profiling	1.28 s	258.825 ms (25.3%)
Total	tracing	10.457 s	-
Total	appsec	10.656 s	198.938 ms (1.9%)
Total	iast	11.044 s	587.095 ms (5.6%)
Total	profiling	10.906 s	449.369 ms (4.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.026 s	-
Agent	appsec	1.166 s	140.137 ms (13.7%)
Agent	iast	1.162 s	135.957 ms (13.3%)
Agent	profiling	1.286 s	260.274 ms (25.4%)
Total	tracing	10.596 s	-
Total	appsec	10.691 s	94.809 ms (0.9%)
Total	iast	10.986 s	390.537 ms (3.7%)
Total	profiling	10.904 s	307.602 ms (2.9%)

gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~6bcada273a, baseline=1.50.0-SNAPSHOT~d5d53cd553

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.801 ms) : 0, 682801
BytebuddyAgent [candidate] (685.073 ms) : 0, 685073
GlobalTracer [baseline] (240.585 ms) : 0, 240585
GlobalTracer [candidate] (242.297 ms) : 0, 242297
AppSec [baseline] (54.538 ms) : 0, 54538
AppSec [candidate] (54.935 ms) : 0, 54935
Debugger [baseline] (8.427 ms) : 0, 8427
Debugger [candidate] (10.075 ms) : 0, 10075
Remote Config [baseline] (701.348 µs) : 0, 701
Remote Config [candidate] (713.029 µs) : 0, 713
Telemetry [baseline] (10.599 ms) : 0, 10599
Telemetry [candidate] (9.162 ms) : 0, 9162
section appsec
BytebuddyAgent [baseline] (700.233 ms) : 0, 700233
BytebuddyAgent [candidate] (703.563 ms) : 0, 703563
GlobalTracer [baseline] (236.619 ms) : 0, 236619
GlobalTracer [candidate] (237.387 ms) : 0, 237387
IAST [baseline] (21.648 ms) : 0, 21648
IAST [candidate] (21.911 ms) : 0, 21911
AppSec [baseline] (175.454 ms) : 0, 175454
AppSec [candidate] (175.92 ms) : 0, 175920
Debugger [baseline] (5.921 ms) : 0, 5921
Debugger [candidate] (5.998 ms) : 0, 5998
Remote Config [baseline] (619.688 µs) : 0, 620
Remote Config [candidate] (631.365 µs) : 0, 631
Telemetry [baseline] (7.759 ms) : 0, 7759
Telemetry [candidate] (7.832 ms) : 0, 7832
section iast
BytebuddyAgent [baseline] (802.943 ms) : 0, 802943
BytebuddyAgent [candidate] (811.258 ms) : 0, 811258
GlobalTracer [baseline] (231.08 ms) : 0, 231080
GlobalTracer [candidate] (232.655 ms) : 0, 232655
IAST [baseline] (27.424 ms) : 0, 27424
IAST [candidate] (26.456 ms) : 0, 26456
AppSec [baseline] (48.388 ms) : 0, 48388
AppSec [candidate] (50.008 ms) : 0, 50008
Debugger [baseline] (5.85 ms) : 0, 5850
Debugger [candidate] (5.987 ms) : 0, 5987
Remote Config [baseline] (591.973 µs) : 0, 592
Remote Config [candidate] (603.227 µs) : 0, 603
Telemetry [baseline] (7.863 ms) : 0, 7863
Telemetry [candidate] (8.016 ms) : 0, 8016
section profiling
BytebuddyAgent [baseline] (673.713 ms) : 0, 673713
BytebuddyAgent [candidate] (675.761 ms) : 0, 675761
GlobalTracer [baseline] (377.649 ms) : 0, 377649
GlobalTracer [candidate] (380.715 ms) : 0, 380715
AppSec [baseline] (54.616 ms) : 0, 54616
AppSec [candidate] (53.881 ms) : 0, 53881
Debugger [baseline] (6.115 ms) : 0, 6115
Debugger [candidate] (6.141 ms) : 0, 6141
Remote Config [baseline] (655.31 µs) : 0, 655
Remote Config [candidate] (660.975 µs) : 0, 661
Telemetry [baseline] (8.074 ms) : 0, 8074
Telemetry [candidate] (8.176 ms) : 0, 8176
ProfilingAgent [baseline] (108.677 ms) : 0, 108677
ProfilingAgent [candidate] (110.092 ms) : 0, 110092
Profiling [baseline] (108.702 ms) : 0, 108702
Profiling [candidate] (110.118 ms) : 0, 110118

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~6bcada273a, baseline=1.50.0-SNAPSHOT~d5d53cd553

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1019887
Total [baseline] (8.672 s) : 0, 8672184
Agent [candidate] (1.021 s) : 0, 1021303
Total [candidate] (8.661 s) : 0, 8661335
section iast
Agent [baseline] (1.154 s) : 0, 1154337
Total [baseline] (9.245 s) : 0, 9245449
Agent [candidate] (1.158 s) : 0, 1158283
Total [candidate] (9.298 s) : 0, 9297555
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.148 s) : 0, 1148191
Total [baseline] (9.216 s) : 0, 9216200
Agent [candidate] (1.149 s) : 0, 1149369
Total [candidate] (9.268 s) : 0, 9268220
section iast_TELEMETRY_OFF
Agent [baseline] (1.146 s) : 0, 1145846
Total [baseline] (9.267 s) : 0, 9266741
Agent [candidate] (1.145 s) : 0, 1145177
Total [candidate] (9.268 s) : 0, 9267548

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.02 s	-
Agent	iast	1.154 s	134.45 ms (13.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.148 s	128.304 ms (12.6%)
Agent	iast_TELEMETRY_OFF	1.146 s	125.959 ms (12.4%)
Total	tracing	8.672 s	-
Total	iast	9.245 s	573.264 ms (6.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.216 s	544.016 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.267 s	594.557 ms (6.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.021 s	-
Agent	iast	1.158 s	136.98 ms (13.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.149 s	128.066 ms (12.5%)
Agent	iast_TELEMETRY_OFF	1.145 s	123.874 ms (12.1%)
Total	tracing	8.661 s	-
Total	iast	9.298 s	636.22 ms (7.3%)
Total	iast_HARDCODED_SECRET_DISABLED	9.268 s	606.884 ms (7.0%)
Total	iast_TELEMETRY_OFF	9.268 s	606.213 ms (7.0%)

gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~6bcada273a, baseline=1.50.0-SNAPSHOT~d5d53cd553

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.217 ms) : 0, 682217
BytebuddyAgent [candidate] (682.008 ms) : 0, 682008
GlobalTracer [baseline] (239.983 ms) : 0, 239983
GlobalTracer [candidate] (240.563 ms) : 0, 240563
AppSec [baseline] (54.459 ms) : 0, 54459
AppSec [candidate] (56.294 ms) : 0, 56294
Debugger [baseline] (9.229 ms) : 0, 9229
Debugger [candidate] (6.873 ms) : 0, 6873
Remote Config [baseline] (691.366 µs) : 0, 691
Remote Config [candidate] (697.159 µs) : 0, 697
Telemetry [baseline] (9.861 ms) : 0, 9861
Telemetry [candidate] (11.447 ms) : 0, 11447
section iast
BytebuddyAgent [baseline] (806.382 ms) : 0, 806382
BytebuddyAgent [candidate] (809.023 ms) : 0, 809023
GlobalTracer [baseline] (231.168 ms) : 0, 231168
GlobalTracer [candidate] (231.967 ms) : 0, 231967
IAST [baseline] (28.447 ms) : 0, 28447
IAST [candidate] (30.094 ms) : 0, 30094
AppSec [baseline] (50.383 ms) : 0, 50383
AppSec [candidate] (48.973 ms) : 0, 48973
Debugger [baseline] (5.901 ms) : 0, 5901
Debugger [candidate] (5.968 ms) : 0, 5968
Remote Config [baseline] (598.774 µs) : 0, 599
Remote Config [candidate] (594.323 µs) : 0, 594
Telemetry [baseline] (7.865 ms) : 0, 7865
Telemetry [candidate] (7.976 ms) : 0, 7976
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (801.09 ms) : 0, 801090
BytebuddyAgent [candidate] (801.902 ms) : 0, 801902
GlobalTracer [baseline] (230.599 ms) : 0, 230599
GlobalTracer [candidate] (230.566 ms) : 0, 230566
IAST [baseline] (30.149 ms) : 0, 30149
IAST [candidate] (26.713 ms) : 0, 26713
AppSec [baseline] (48.515 ms) : 0, 48515
AppSec [candidate] (52.358 ms) : 0, 52358
Debugger [baseline] (5.891 ms) : 0, 5891
Debugger [candidate] (5.889 ms) : 0, 5889
Remote Config [baseline] (602.997 µs) : 0, 603
Remote Config [candidate] (594.042 µs) : 0, 594
Telemetry [baseline] (7.882 ms) : 0, 7882
Telemetry [candidate] (7.851 ms) : 0, 7851
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.818 ms) : 0, 798818
BytebuddyAgent [candidate] (798.284 ms) : 0, 798284
GlobalTracer [baseline] (230.373 ms) : 0, 230373
GlobalTracer [candidate] (230.51 ms) : 0, 230510
IAST [baseline] (23.981 ms) : 0, 23981
IAST [candidate] (22.408 ms) : 0, 22408
AppSec [baseline] (54.809 ms) : 0, 54809
AppSec [candidate] (56.132 ms) : 0, 56132
Debugger [baseline] (5.98 ms) : 0, 5980
Debugger [candidate] (5.954 ms) : 0, 5954
Remote Config [baseline] (609.586 µs) : 0, 610
Remote Config [candidate] (616.304 µs) : 0, 616
Telemetry [baseline] (7.803 ms) : 0, 7803
Telemetry [candidate] (7.806 ms) : 0, 7806

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-05-08T19:54:56	2025-05-08T20:02:40
git_branch	master	mtoff/scfg_file_size_limit
git_commit_date	1746692171	1746732774
git_commit_sha	`d5d53cd`	`6bcada2`
release_version	1.50.0-SNAPSHOT~d5d53cd553	1.50.0-SNAPSHOT~6bcada273a
start_time	2025-05-08T19:54:42	2025-05-08T20:02:26

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1746734958	1746734958
ci_job_id	930478071	930478071
ci_pipeline_id	64572419	64572419
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-psrqmy6d-project-304-concurrent-1-kbm5y33q 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-psrqmy6d-project-304-concurrent-1-kbm5y33q 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~6bcada273a, baseline=1.50.0-SNAPSHOT~d5d53cd553
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.361 ms) : 1340, 1382
.   : milestone, 1361,
appsec (1.75 ms) : 1727, 1774
.   : milestone, 1750,
appsec_no_iast (1.739 ms) : 1716, 1762
.   : milestone, 1739,
code_origins (1.67 ms) : 1642, 1697
.   : milestone, 1670,
iast (1.51 ms) : 1485, 1535
.   : milestone, 1510,
profiling (1.517 ms) : 1494, 1540
.   : milestone, 1517,
tracing (1.505 ms) : 1481, 1530
.   : milestone, 1505,
section candidate
no_agent (1.35 ms) : 1331, 1370
.   : milestone, 1350,
appsec (1.757 ms) : 1733, 1780
.   : milestone, 1757,
appsec_no_iast (1.733 ms) : 1710, 1756
.   : milestone, 1733,
code_origins (1.667 ms) : 1640, 1694
.   : milestone, 1667,
iast (1.511 ms) : 1487, 1535
.   : milestone, 1511,
profiling (1.504 ms) : 1480, 1527
.   : milestone, 1504,
tracing (1.512 ms) : 1488, 1537
.   : milestone, 1512,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.361 ms [1.34 ms, 1.382 ms]	-
appsec	1.75 ms [1.727 ms, 1.774 ms]	389.561 µs (28.6%)
appsec_no_iast	1.739 ms [1.716 ms, 1.762 ms]	378.239 µs (27.8%)
code_origins	1.67 ms [1.642 ms, 1.697 ms]	308.66 µs (22.7%)
iast	1.51 ms [1.485 ms, 1.535 ms]	149.341 µs (11.0%)
profiling	1.517 ms [1.494 ms, 1.54 ms]	156.187 µs (11.5%)
tracing	1.505 ms [1.481 ms, 1.53 ms]	144.505 µs (10.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.35 ms [1.331 ms, 1.37 ms]	-
appsec	1.757 ms [1.733 ms, 1.78 ms]	406.226 µs (30.1%)
appsec_no_iast	1.733 ms [1.71 ms, 1.756 ms]	382.277 µs (28.3%)
code_origins	1.667 ms [1.64 ms, 1.694 ms]	316.626 µs (23.4%)
iast	1.511 ms [1.487 ms, 1.535 ms]	160.382 µs (11.9%)
profiling	1.504 ms [1.48 ms, 1.527 ms]	153.249 µs (11.3%)
tracing	1.512 ms [1.488 ms, 1.537 ms]	161.871 µs (12.0%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~6bcada273a, baseline=1.50.0-SNAPSHOT~d5d53cd553
    dateFormat X
    axisFormat %s
section baseline
no_agent (387.448 µs) : 366, 409
.   : milestone, 387,
iast (527.164 µs) : 504, 551
.   : milestone, 527,
iast_FULL (734.017 µs) : 712, 756
.   : milestone, 734,
iast_GLOBAL (580.232 µs) : 558, 603
.   : milestone, 580,
iast_HARDCODED_SECRET_DISABLED (528.248 µs) : 506, 551
.   : milestone, 528,
iast_INACTIVE (467.757 µs) : 445, 491
.   : milestone, 468,
iast_TELEMETRY_OFF (505.638 µs) : 483, 529
.   : milestone, 506,
tracing (464.681 µs) : 442, 487
.   : milestone, 465,
section candidate
no_agent (381.403 µs) : 362, 401
.   : milestone, 381,
iast (521.093 µs) : 499, 543
.   : milestone, 521,
iast_FULL (737.076 µs) : 715, 760
.   : milestone, 737,
iast_GLOBAL (564.205 µs) : 543, 586
.   : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (517.264 µs) : 496, 539
.   : milestone, 517,
iast_INACTIVE (467.453 µs) : 445, 490
.   : milestone, 467,
iast_TELEMETRY_OFF (511.532 µs) : 488, 535
.   : milestone, 512,
tracing (461.422 µs) : 439, 484
.   : milestone, 461,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	387.448 µs [366.325 µs, 408.571 µs]	-
iast	527.164 µs [503.766 µs, 550.561 µs]	139.716 µs (36.1%)
iast_FULL	734.017 µs [711.918 µs, 756.117 µs]	346.57 µs (89.4%)
iast_GLOBAL	580.232 µs [557.645 µs, 602.819 µs]	192.785 µs (49.8%)
iast_HARDCODED_SECRET_DISABLED	528.248 µs [505.561 µs, 550.935 µs]	140.8 µs (36.3%)
iast_INACTIVE	467.757 µs [444.881 µs, 490.633 µs]	80.309 µs (20.7%)
iast_TELEMETRY_OFF	505.638 µs [482.684 µs, 528.591 µs]	118.19 µs (30.5%)
tracing	464.681 µs [442.22 µs, 487.143 µs]	77.234 µs (19.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	381.403 µs [361.752 µs, 401.055 µs]	-
iast	521.093 µs [498.919 µs, 543.267 µs]	139.69 µs (36.6%)
iast_FULL	737.076 µs [714.517 µs, 759.635 µs]	355.673 µs (93.3%)
iast_GLOBAL	564.205 µs [542.567 µs, 585.844 µs]	182.802 µs (47.9%)
iast_HARDCODED_SECRET_DISABLED	517.264 µs [495.66 µs, 538.869 µs]	135.861 µs (35.6%)
iast_INACTIVE	467.453 µs [444.633 µs, 490.272 µs]	86.05 µs (22.6%)
iast_TELEMETRY_OFF	511.532 µs [488.237 µs, 534.827 µs]	130.129 µs (34.1%)
tracing	461.422 µs [439.208 µs, 483.637 µs]	80.019 µs (21.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/scfg_file_size_limit
git_commit_date	1746692171	1746732774
git_commit_sha	`d5d53cd`	`6bcada2`
release_version	1.50.0-SNAPSHOT~d5d53cd553	1.50.0-SNAPSHOT~6bcada273a

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1746735459	1746735459
ci_job_id	930478072	930478072
ci_pipeline_id	64572419	64572419
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-7pg-kqds-project-304-concurrent-0-rszt1omh 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-7pg-kqds-project-304-concurrent-0-rszt1omh 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~6bcada273a, baseline=1.50.0-SNAPSHOT~d5d53cd553
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.375 ms) : 2328, 2421
.   : milestone, 2375,
iast (2.161 ms) : 2102, 2221
.   : milestone, 2161,
iast_GLOBAL (2.201 ms) : 2142, 2261
.   : milestone, 2201,
profiling (2.023 ms) : 1974, 2071
.   : milestone, 2023,
tracing (1.98 ms) : 1934, 2026
.   : milestone, 1980,
section candidate
no_agent (1.478 ms) : 1466, 1490
.   : milestone, 1478,
appsec (2.374 ms) : 2327, 2421
.   : milestone, 2374,
iast (2.161 ms) : 2101, 2220
.   : milestone, 2161,
iast_GLOBAL (2.202 ms) : 2142, 2262
.   : milestone, 2202,
profiling (2.493 ms) : 2311, 2675
.   : milestone, 2493,
tracing (1.989 ms) : 1942, 2035
.   : milestone, 1989,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.459 ms, 1.482 ms]	-
appsec	2.375 ms [2.328 ms, 2.421 ms]	904.098 µs (61.5%)
iast	2.161 ms [2.102 ms, 2.221 ms]	690.713 µs (47.0%)
iast_GLOBAL	2.201 ms [2.142 ms, 2.261 ms]	730.736 µs (49.7%)
profiling	2.023 ms [1.974 ms, 2.071 ms]	552.244 µs (37.6%)
tracing	1.98 ms [1.934 ms, 2.026 ms]	509.818 µs (34.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.466 ms, 1.49 ms]	-
appsec	2.374 ms [2.327 ms, 2.421 ms]	896.172 µs (60.6%)
iast	2.161 ms [2.101 ms, 2.22 ms]	682.847 µs (46.2%)
iast_GLOBAL	2.202 ms [2.142 ms, 2.262 ms]	724.21 µs (49.0%)
profiling	2.493 ms [2.311 ms, 2.675 ms]	1.015 ms (68.7%)
tracing	1.989 ms [1.942 ms, 2.035 ms]	510.825 µs (34.6%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~6bcada273a, baseline=1.50.0-SNAPSHOT~d5d53cd553
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.472 s) : 15472000, 15472000
.   : milestone, 15472000,
appsec (15.085 s) : 15085000, 15085000
.   : milestone, 15085000,
iast (18.383 s) : 18383000, 18383000
.   : milestone, 18383000,
iast_GLOBAL (18.205 s) : 18205000, 18205000
.   : milestone, 18205000,
profiling (15.279 s) : 15279000, 15279000
.   : milestone, 15279000,
tracing (14.917 s) : 14917000, 14917000
.   : milestone, 14917000,
section candidate
no_agent (14.925 s) : 14925000, 14925000
.   : milestone, 14925000,
appsec (14.988 s) : 14988000, 14988000
.   : milestone, 14988000,
iast (18.581 s) : 18581000, 18581000
.   : milestone, 18581000,
iast_GLOBAL (17.702 s) : 17702000, 17702000
.   : milestone, 17702000,
profiling (14.914 s) : 14914000, 14914000
.   : milestone, 14914000,
tracing (15.046 s) : 15046000, 15046000
.   : milestone, 15046000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.472 s [15.472 s, 15.472 s]	-
appsec	15.085 s [15.085 s, 15.085 s]	-387.0 ms (-2.5%)
iast	18.383 s [18.383 s, 18.383 s]	2.911 s (18.8%)
iast_GLOBAL	18.205 s [18.205 s, 18.205 s]	2.733 s (17.7%)
profiling	15.279 s [15.279 s, 15.279 s]	-193.0 ms (-1.2%)
tracing	14.917 s [14.917 s, 14.917 s]	-555.0 ms (-3.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.925 s [14.925 s, 14.925 s]	-
appsec	14.988 s [14.988 s, 14.988 s]	63.0 ms (0.4%)
iast	18.581 s [18.581 s, 18.581 s]	3.656 s (24.5%)
iast_GLOBAL	17.702 s [17.702 s, 17.702 s]	2.777 s (18.6%)
profiling	14.914 s [14.914 s, 14.914 s]	-11.0 ms (-0.1%)
tracing	15.046 s [15.046 s, 15.046 s]	121.0 ms (0.8%)

mtoffl01 and others added 22 commits April 10, 2025 12:38

migrate CLIHelper to use a Map, parse system properties in key-vals

d112dc7

Fix processTemplateVar logic to remove superfluous ':'

3ba99af

nits: javadocs

9caeb5d

Move writeFileRaw helper to testutils

d0f194b

Add YamlParser tests

457c288

Revert CLIHelper to use List<String>; lazily load a Map cache for que…

06ae9ac

…rying key-vals

reuse logic for adding to the vm args cache

06712dc

apply github suggestions

0a1da8f

Move processTemplate yaml helper fns into StableConfigParser, along w…

e106416

…ith tests

Remove changes to CLIHelper; rely on System.getProperty instead

48adeaa

optimize: return from processTemplate early if no {{ found

24b8615

Add more test coverage to StableConfigParserTest

cc76954

Merge branch 'master' into mtoff/scfg_fix

afddf95

Optimize template processing to reduce use of substrings

fc4652c

Introduce constants for repeated strings

e633f26

Change UNDEFINED_VALUE to empty string

b5deffd

Add log messages for empty environment_variable and process_argument …

9104f0d

…values in template variable

Remove FileUtils and all its references

ecb5a15

initial file size limit implementation: phase 1 limit only

62388b3

Implement file size limit + tests

7b7dbdd

merge wth main, resolve conflicts

b7f224b

remove unrelated changes

6bcada2

mtoffl01 changed the title ~~Mtoff/scfg file size limit~~ Enforce size limit on application_monitoring.yaml files May 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enforce size limit on application_monitoring.yaml files #8789

Enforce size limit on application_monitoring.yaml files #8789

mtoffl01 commented May 8, 2025 •

edited

Loading

pr-commenter bot commented May 8, 2025 •

edited

Loading

Enforce size limit on application_monitoring.yaml files #8789

Are you sure you want to change the base?

Enforce size limit on application_monitoring.yaml files #8789

Conversation

mtoffl01 commented May 8, 2025 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented May 8, 2025 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

mtoffl01 commented May 8, 2025 •

edited

Loading

pr-commenter bot commented May 8, 2025 •

edited

Loading