Skip to content

Add process tags to crashtracking #8810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add process tags to crashtracking #8810

wants to merge 1 commit into from

Conversation

amarziali
Copy link
Collaborator

@amarziali amarziali commented May 13, 2025 •
edited
Loading

What Does This Do

Adds Process tags (when enabled) to crashtracking payload. Depending on the payload the tags are:

  • logs payload -> /process_tags
  • telemetry payload -> /application/process_tags

The tags are encoded as a comma separated list. Each entry, key:value

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner May 13, 2025 09:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 13, 2025 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@amarziali amarziali requested a review from raphaelgavache May 13, 2025 09:19
@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies

Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented May 13, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/crashtracking
git_commit_date 1747122031 1747127834
git_commit_sha 25acb15 2b71c78
release_version 1.50.0-SNAPSHOT~25acb15350 1.50.0-SNAPSHOT~2b71c78d8b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747130358 1747130358
ci_job_id 935242780 935242780
ci_pipeline_id 64907669 64907669
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-j-ha6efi-project-304-concurrent-0-hz19zalg 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-j-ha6efi-project-304-concurrent-0-hz19zalg 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~2b71c78d8b, baseline=1.50.0-SNAPSHOT~25acb15350

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.031 s) : 0, 1030616
Total [baseline] (8.695 s) : 0, 8695156
Agent [candidate] (1.019 s) : 0, 1019141
Total [candidate] (8.644 s) : 0, 8643603
section iast
Agent [baseline] (1.146 s) : 0, 1146025
Total [baseline] (9.24 s) : 0, 9239548
Agent [candidate] (1.157 s) : 0, 1156717
Total [candidate] (9.234 s) : 0, 9233692
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.15 s) : 0, 1150157
Total [baseline] (9.207 s) : 0, 9207497
Agent [candidate] (1.151 s) : 0, 1151093
Total [candidate] (9.205 s) : 0, 9204846
section iast_TELEMETRY_OFF
Agent [baseline] (1.146 s) : 0, 1145582
Total [baseline] (9.213 s) : 0, 9212865
Agent [candidate] (1.166 s) : 0, 1166374
Total [candidate] (9.259 s) : 0, 9258516
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.031 s -
Agent iast 1.146 s 115.408 ms (11.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.15 s 119.541 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.146 s 114.966 ms (11.2%)
Total tracing 8.695 s -
Total iast 9.24 s 544.392 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.207 s 512.34 ms (5.9%)
Total iast_TELEMETRY_OFF 9.213 s 517.709 ms (6.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.019 s -
Agent iast 1.157 s 137.576 ms (13.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.151 s 131.952 ms (12.9%)
Agent iast_TELEMETRY_OFF 1.166 s 147.233 ms (14.4%)
Total tracing 8.644 s -
Total iast 9.234 s 590.089 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.205 s 561.243 ms (6.5%)
Total iast_TELEMETRY_OFF 9.259 s 614.913 ms (7.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~2b71c78d8b, baseline=1.50.0-SNAPSHOT~25acb15350

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.396 ms) : 0, 688396
BytebuddyAgent [candidate] (681.254 ms) : 0, 681254
GlobalTracer [baseline] (242.216 ms) : 0, 242216
GlobalTracer [candidate] (239.525 ms) : 0, 239525
AppSec [baseline] (55.651 ms) : 0, 55651
AppSec [candidate] (55.286 ms) : 0, 55286
Debugger [baseline] (8.517 ms) : 0, 8517
Debugger [candidate] (9.113 ms) : 0, 9113
Remote Config [baseline] (713.122 µs) : 0, 713
Remote Config [candidate] (695.007 µs) : 0, 695
Telemetry [baseline] (11.395 ms) : 0, 11395
Telemetry [candidate] (9.627 ms) : 0, 9627
section iast
BytebuddyAgent [baseline] (800.007 ms) : 0, 800007
BytebuddyAgent [candidate] (808.021 ms) : 0, 808021
GlobalTracer [baseline] (229.909 ms) : 0, 229909
GlobalTracer [candidate] (231.696 ms) : 0, 231696
IAST [baseline] (24.09 ms) : 0, 24090
IAST [candidate] (29.349 ms) : 0, 29349
AppSec [baseline] (52.742 ms) : 0, 52742
AppSec [candidate] (48.084 ms) : 0, 48084
Debugger [baseline] (5.897 ms) : 0, 5897
Debugger [candidate] (5.952 ms) : 0, 5952
Remote Config [baseline] (585.926 µs) : 0, 586
Remote Config [candidate] (586.742 µs) : 0, 587
Telemetry [baseline] (7.826 ms) : 0, 7826
Telemetry [candidate] (7.969 ms) : 0, 7969
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (802.379 ms) : 0, 802379
BytebuddyAgent [candidate] (803.366 ms) : 0, 803366
GlobalTracer [baseline] (231.029 ms) : 0, 231029
GlobalTracer [candidate] (231.071 ms) : 0, 231071
IAST [baseline] (27.811 ms) : 0, 27811
IAST [candidate] (28.316 ms) : 0, 28316
AppSec [baseline] (51.118 ms) : 0, 51118
AppSec [candidate] (50.419 ms) : 0, 50419
Debugger [baseline] (5.881 ms) : 0, 5881
Debugger [candidate] (5.899 ms) : 0, 5899
Remote Config [baseline] (587.162 µs) : 0, 587
Remote Config [candidate] (579.672 µs) : 0, 580
Telemetry [baseline] (7.818 ms) : 0, 7818
Telemetry [candidate] (7.893 ms) : 0, 7893
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.757 ms) : 0, 799757
BytebuddyAgent [candidate] (814.717 ms) : 0, 814717
GlobalTracer [baseline] (230.264 ms) : 0, 230264
GlobalTracer [candidate] (234.458 ms) : 0, 234458
IAST [baseline] (24.326 ms) : 0, 24326
IAST [candidate] (23.581 ms) : 0, 23581
AppSec [baseline] (53.329 ms) : 0, 53329
AppSec [candidate] (55.334 ms) : 0, 55334
Debugger [baseline] (5.951 ms) : 0, 5951
Debugger [candidate] (6.056 ms) : 0, 6056
Remote Config [baseline] (608.371 µs) : 0, 608
Remote Config [candidate] (618.103 µs) : 0, 618
Telemetry [baseline] (7.814 ms) : 0, 7814
Telemetry [candidate] (7.88 ms) : 0, 7880
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~2b71c78d8b, baseline=1.50.0-SNAPSHOT~25acb15350

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1022646
Total [baseline] (10.507 s) : 0, 10507412
Agent [candidate] (1.022 s) : 0, 1021619
Total [candidate] (10.547 s) : 0, 10547430
section appsec
Agent [baseline] (1.168 s) : 0, 1167558
Total [baseline] (10.697 s) : 0, 10696582
Agent [candidate] (1.168 s) : 0, 1168143
Total [candidate] (10.736 s) : 0, 10735915
section iast
Agent [baseline] (1.151 s) : 0, 1150937
Total [baseline] (10.918 s) : 0, 10918291
Agent [candidate] (1.154 s) : 0, 1154358
Total [candidate] (10.884 s) : 0, 10884042
section profiling
Agent [baseline] (1.276 s) : 0, 1275842
Total [baseline] (10.743 s) : 0, 10742577
Agent [candidate] (1.288 s) : 0, 1287569
Total [candidate] (10.903 s) : 0, 10902614
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.023 s -
Agent appsec 1.168 s 144.912 ms (14.2%)
Agent iast 1.151 s 128.291 ms (12.5%)
Agent profiling 1.276 s 253.195 ms (24.8%)
Total tracing 10.507 s -
Total appsec 10.697 s 189.17 ms (1.8%)
Total iast 10.918 s 410.879 ms (3.9%)
Total profiling 10.743 s 235.165 ms (2.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.022 s -
Agent appsec 1.168 s 146.524 ms (14.3%)
Agent iast 1.154 s 132.738 ms (13.0%)
Agent profiling 1.288 s 265.95 ms (26.0%)
Total tracing 10.547 s -
Total appsec 10.736 s 188.484 ms (1.8%)
Total iast 10.884 s 336.612 ms (3.2%)
Total profiling 10.903 s 355.184 ms (3.4%) 
gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~2b71c78d8b, baseline=1.50.0-SNAPSHOT~25acb15350

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.605 ms) : 0, 682605
BytebuddyAgent [candidate] (684.381 ms) : 0, 684381
GlobalTracer [baseline] (240.278 ms) : 0, 240278
GlobalTracer [candidate] (240.868 ms) : 0, 240868
AppSec [baseline] (54.444 ms) : 0, 54444
AppSec [candidate] (55.107 ms) : 0, 55107
Debugger [baseline] (10.568 ms) : 0, 10568
Debugger [candidate] (7.523 ms) : 0, 7523
Remote Config [baseline] (689.737 µs) : 0, 690
Remote Config [candidate] (682.978 µs) : 0, 683
Telemetry [baseline] (10.468 ms) : 0, 10468
Telemetry [candidate] (9.365 ms) : 0, 9365
section appsec
BytebuddyAgent [baseline] (705.536 ms) : 0, 705536
BytebuddyAgent [candidate] (705.094 ms) : 0, 705094
GlobalTracer [baseline] (237.448 ms) : 0, 237448
GlobalTracer [candidate] (238.056 ms) : 0, 238056
IAST [baseline] (21.651 ms) : 0, 21651
IAST [candidate] (21.701 ms) : 0, 21701
AppSec [baseline] (176.118 ms) : 0, 176118
AppSec [candidate] (176.009 ms) : 0, 176009
Debugger [baseline] (5.952 ms) : 0, 5952
Debugger [candidate] (5.972 ms) : 0, 5972
Remote Config [baseline] (626.244 µs) : 0, 626
Remote Config [candidate] (626.725 µs) : 0, 627
Telemetry [baseline] (7.374 ms) : 0, 7374
Telemetry [candidate] (7.823 ms) : 0, 7823
section iast
BytebuddyAgent [baseline] (803.505 ms) : 0, 803505
BytebuddyAgent [candidate] (804.341 ms) : 0, 804341
GlobalTracer [baseline] (230.935 ms) : 0, 230935
GlobalTracer [candidate] (232.326 ms) : 0, 232326
IAST [baseline] (28.353 ms) : 0, 28353
IAST [candidate] (28.598 ms) : 0, 28598
AppSec [baseline] (50.177 ms) : 0, 50177
AppSec [candidate] (50.041 ms) : 0, 50041
Debugger [baseline] (5.911 ms) : 0, 5911
Debugger [candidate] (5.982 ms) : 0, 5982
Remote Config [baseline] (597.638 µs) : 0, 598
Remote Config [candidate] (613.897 µs) : 0, 614
Telemetry [baseline] (7.869 ms) : 0, 7869
Telemetry [candidate] (8.044 ms) : 0, 8044
section profiling
BytebuddyAgent [baseline] (671.821 ms) : 0, 671821
BytebuddyAgent [candidate] (678.237 ms) : 0, 678237
GlobalTracer [baseline] (374.649 ms) : 0, 374649
GlobalTracer [candidate] (376.688 ms) : 0, 376688
AppSec [baseline] (61.626 ms) : 0, 61626
AppSec [candidate] (62.161 ms) : 0, 62161
Debugger [baseline] (6.223 ms) : 0, 6223
Debugger [candidate] (6.344 ms) : 0, 6344
Remote Config [baseline] (651.719 µs) : 0, 652
Remote Config [candidate] (655.367 µs) : 0, 655
Telemetry [baseline] (8.087 ms) : 0, 8087
Telemetry [candidate] (8.303 ms) : 0, 8303
ProfilingAgent [baseline] (102.157 ms) : 0, 102157
ProfilingAgent [candidate] (103.973 ms) : 0, 103973
Profiling [baseline] (102.181 ms) : 0, 102181
Profiling [candidate] (103.997 ms) : 0, 103997
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-05-13T09:29:47 2025-05-13T09:37:35
git_branch master andrea.marziali/crashtracking
git_commit_date 1747122031 1747127834
git_commit_sha 25acb15 2b71c78
release_version 1.50.0-SNAPSHOT~25acb15350 1.50.0-SNAPSHOT~2b71c78d8b
start_time 2025-05-13T09:29:33 2025-05-13T09:37:20
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747129453 1747129453
ci_job_id 935242781 935242781
ci_pipeline_id 64907669 64907669
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-j-ha6efi-project-304-concurrent-1-luf2zgu0 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-j-ha6efi-project-304-concurrent-1-luf2zgu0 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~2b71c78d8b, baseline=1.50.0-SNAPSHOT~25acb15350
    dateFormat X
    axisFormat %s
section baseline
no_agent (383.109 µs) : 363, 403
.   : milestone, 383,
iast (527.626 µs) : 505, 550
.   : milestone, 528,
iast_FULL (741.712 µs) : 720, 764
.   : milestone, 742,
iast_GLOBAL (561.049 µs) : 540, 582
.   : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (520.811 µs) : 498, 544
.   : milestone, 521,
iast_INACTIVE (475.384 µs) : 453, 498
.   : milestone, 475,
iast_TELEMETRY_OFF (522.518 µs) : 499, 546
.   : milestone, 523,
tracing (467.827 µs) : 445, 491
.   : milestone, 468,
section candidate
no_agent (383.472 µs) : 363, 404
.   : milestone, 383,
iast (522.819 µs) : 501, 544
.   : milestone, 523,
iast_FULL (740.026 µs) : 718, 762
.   : milestone, 740,
iast_GLOBAL (572.135 µs) : 550, 594
.   : milestone, 572,
iast_HARDCODED_SECRET_DISABLED (529.29 µs) : 507, 551
.   : milestone, 529,
iast_INACTIVE (468.986 µs) : 446, 492
.   : milestone, 469,
iast_TELEMETRY_OFF (504.993 µs) : 482, 528
.   : milestone, 505,
tracing (468.196 µs) : 445, 491
.   : milestone, 468,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 383.109 µs [362.731 µs, 403.487 µs] -
iast 527.626 µs [505.433 µs, 549.819 µs] 144.517 µs (37.7%)
iast_FULL 741.712 µs [719.751 µs, 763.673 µs] 358.603 µs (93.6%)
iast_GLOBAL 561.049 µs [539.621 µs, 582.477 µs] 177.939 µs (46.4%)
iast_HARDCODED_SECRET_DISABLED 520.811 µs [497.567 µs, 544.056 µs] 137.702 µs (35.9%)
iast_INACTIVE 475.384 µs [452.767 µs, 498.0 µs] 92.274 µs (24.1%)
iast_TELEMETRY_OFF 522.518 µs [499.032 µs, 546.004 µs] 139.408 µs (36.4%)
tracing 467.827 µs [444.803 µs, 490.851 µs] 84.717 µs (22.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 383.472 µs [363.373 µs, 403.57 µs] -
iast 522.819 µs [501.142 µs, 544.495 µs] 139.347 µs (36.3%)
iast_FULL 740.026 µs [718.172 µs, 761.879 µs] 356.554 µs (93.0%)
iast_GLOBAL 572.135 µs [550.183 µs, 594.088 µs] 188.664 µs (49.2%)
iast_HARDCODED_SECRET_DISABLED 529.29 µs [507.156 µs, 551.425 µs] 145.819 µs (38.0%)
iast_INACTIVE 468.986 µs [446.17 µs, 491.803 µs] 85.515 µs (22.3%)
iast_TELEMETRY_OFF 504.993 µs [482.026 µs, 527.96 µs] 121.522 µs (31.7%)
tracing 468.196 µs [445.278 µs, 491.113 µs] 84.724 µs (22.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~2b71c78d8b, baseline=1.50.0-SNAPSHOT~25acb15350
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.374 ms) : 1354, 1393
.   : milestone, 1374,
appsec (1.742 ms) : 1719, 1765
.   : milestone, 1742,
appsec_no_iast (1.716 ms) : 1693, 1739
.   : milestone, 1716,
code_origins (1.677 ms) : 1649, 1704
.   : milestone, 1677,
iast (1.54 ms) : 1516, 1564
.   : milestone, 1540,
profiling (1.53 ms) : 1507, 1553
.   : milestone, 1530,
tracing (1.506 ms) : 1481, 1530
.   : milestone, 1506,
section candidate
no_agent (1.366 ms) : 1346, 1385
.   : milestone, 1366,
appsec (1.744 ms) : 1720, 1768
.   : milestone, 1744,
appsec_no_iast (1.718 ms) : 1694, 1741
.   : milestone, 1718,
code_origins (1.675 ms) : 1648, 1702
.   : milestone, 1675,
iast (1.505 ms) : 1480, 1529
.   : milestone, 1505,
profiling (1.531 ms) : 1507, 1555
.   : milestone, 1531,
tracing (1.494 ms) : 1470, 1519
.   : milestone, 1494,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.374 ms [1.354 ms, 1.393 ms] -
appsec 1.742 ms [1.719 ms, 1.765 ms] 368.414 µs (26.8%)
appsec_no_iast 1.716 ms [1.693 ms, 1.739 ms] 342.022 µs (24.9%)
code_origins 1.677 ms [1.649 ms, 1.704 ms] 303.145 µs (22.1%)
iast 1.54 ms [1.516 ms, 1.564 ms] 165.969 µs (12.1%)
profiling 1.53 ms [1.507 ms, 1.553 ms] 156.475 µs (11.4%)
tracing 1.506 ms [1.481 ms, 1.53 ms] 131.851 µs (9.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.366 ms [1.346 ms, 1.385 ms] -
appsec 1.744 ms [1.72 ms, 1.768 ms] 378.315 µs (27.7%)
appsec_no_iast 1.718 ms [1.694 ms, 1.741 ms] 352.25 µs (25.8%)
code_origins 1.675 ms [1.648 ms, 1.702 ms] 309.228 µs (22.6%)
iast 1.505 ms [1.48 ms, 1.529 ms] 139.19 µs (10.2%)
profiling 1.531 ms [1.507 ms, 1.555 ms] 165.777 µs (12.1%)
tracing 1.494 ms [1.47 ms, 1.519 ms] 128.869 µs (9.4%)

Dacapo

@amarziali amarziali requested review from jbachorik and MattAlp May 13, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaelgavache raphaelgavache raphaelgavache approved these changes

@jbachorik jbachorik Awaiting requested review from jbachorik

@MattAlp MattAlp Awaiting requested review from MattAlp

Assignees
No one assigned
Labels
comp: crash tracking Crash tracking type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amarziali @raphaelgavache