Skip to content

Fix error mark on http status for IBM liberty #8822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix error mark on http status for IBM liberty #8822

wants to merge 2 commits into from

Conversation

amarziali
Copy link
Collaborator

@amarziali amarziali commented May 14, 2025 •
edited by jira bot
Loading

What Does This Do

The libery decorator does not take into account flagging the span as errored depending on the http status code.
In fact the code on the HttpServerDecorator that handles that was not called so that logic was skipped.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: APMS-15737

@amarziali amarziali requested a review from a team as a code owner May 14, 2025 09:58
@github-actions GitHub Actions
Copy link
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

vandonr
vandonr approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@vandonr vandonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amarziali amarziali enabled auto-merge (squash) May 14, 2025 10:02
@amarziali amarziali added type: bug inst: others All other instrumentations labels May 14, 2025
@pr-commenter
Copy link

pr-commenter bot commented May 14, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/liberty-fix
git_commit_date 1747229243 1747230805
git_commit_sha 7c80dbe e2f2c9a
release_version 1.50.0-SNAPSHOT~7c80dbede3 1.50.0-SNAPSHOT~e2f2c9a5c8
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747233216 1747233216
ci_job_id 937923375 937923375
ci_pipeline_id 65071769 65071769
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-px6-mzwm-project-304-concurrent-2-hvfafqk1 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-px6-mzwm-project-304-concurrent-2-hvfafqk1 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 13 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~e2f2c9a5c8, baseline=1.50.0-SNAPSHOT~7c80dbede3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1019773
Total [baseline] (10.47 s) : 0, 10469776
Agent [candidate] (1.026 s) : 0, 1026329
Total [candidate] (10.485 s) : 0, 10485132
section appsec
Agent [baseline] (1.161 s) : 0, 1160949
Total [baseline] (10.678 s) : 0, 10677665
Agent [candidate] (1.16 s) : 0, 1159585
Total [candidate] (10.72 s) : 0, 10720327
section iast
Agent [baseline] (1.166 s) : 0, 1165716
Total [baseline] (10.94 s) : 0, 10939993
Agent [candidate] (1.147 s) : 0, 1147350
Total [candidate] (10.916 s) : 0, 10916000
section profiling
Agent [baseline] (1.275 s) : 0, 1274924
Total [baseline] (10.823 s) : 0, 10822600
Agent [candidate] (1.278 s) : 0, 1277746
Total [candidate] (10.814 s) : 0, 10814262
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.02 s -
Agent appsec 1.161 s 141.176 ms (13.8%)
Agent iast 1.166 s 145.943 ms (14.3%)
Agent profiling 1.275 s 255.151 ms (25.0%)
Total tracing 10.47 s -
Total appsec 10.678 s 207.889 ms (2.0%)
Total iast 10.94 s 470.217 ms (4.5%)
Total profiling 10.823 s 352.824 ms (3.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.026 s -
Agent appsec 1.16 s 133.256 ms (13.0%)
Agent iast 1.147 s 121.021 ms (11.8%)
Agent profiling 1.278 s 251.417 ms (24.5%)
Total tracing 10.485 s -
Total appsec 10.72 s 235.195 ms (2.2%)
Total iast 10.916 s 430.868 ms (4.1%)
Total profiling 10.814 s 329.13 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~e2f2c9a5c8, baseline=1.50.0-SNAPSHOT~7c80dbede3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.145 ms) : 0, 681145
BytebuddyAgent [candidate] (686.001 ms) : 0, 686001
GlobalTracer [baseline] (240.674 ms) : 0, 240674
GlobalTracer [candidate] (242.558 ms) : 0, 242558
AppSec [baseline] (54.575 ms) : 0, 54575
AppSec [candidate] (55.159 ms) : 0, 55159
Debugger [baseline] (8.459 ms) : 0, 8459
Debugger [candidate] (9.145 ms) : 0, 9145
Remote Config [baseline] (710.855 µs) : 0, 711
Remote Config [candidate] (698.487 µs) : 0, 698
Telemetry [baseline] (10.664 ms) : 0, 10664
Telemetry [candidate] (9.147 ms) : 0, 9147
section appsec
BytebuddyAgent [baseline] (700.886 ms) : 0, 700886
BytebuddyAgent [candidate] (699.194 ms) : 0, 699194
GlobalTracer [baseline] (236.468 ms) : 0, 236468
GlobalTracer [candidate] (236.388 ms) : 0, 236388
AppSec [baseline] (174.191 ms) : 0, 174191
AppSec [candidate] (174.879 ms) : 0, 174879
Debugger [baseline] (5.919 ms) : 0, 5919
Debugger [candidate] (5.947 ms) : 0, 5947
Remote Config [baseline] (631.295 µs) : 0, 631
Remote Config [candidate] (627.132 µs) : 0, 627
Telemetry [baseline] (8.437 ms) : 0, 8437
Telemetry [candidate] (8.182 ms) : 0, 8182
IAST [baseline] (21.603 ms) : 0, 21603
IAST [candidate] (21.674 ms) : 0, 21674
section iast
BytebuddyAgent [baseline] (815.191 ms) : 0, 815191
BytebuddyAgent [candidate] (800.584 ms) : 0, 800584
GlobalTracer [baseline] (233.473 ms) : 0, 233473
GlobalTracer [candidate] (230.933 ms) : 0, 230933
AppSec [baseline] (50.556 ms) : 0, 50556
AppSec [candidate] (48.274 ms) : 0, 48274
Debugger [baseline] (5.92 ms) : 0, 5920
Debugger [candidate] (5.823 ms) : 0, 5823
Remote Config [baseline] (588.83 µs) : 0, 589
Remote Config [candidate] (590.586 µs) : 0, 591
Telemetry [baseline] (7.876 ms) : 0, 7876
Telemetry [candidate] (7.831 ms) : 0, 7831
IAST [baseline] (27.591 ms) : 0, 27591
IAST [candidate] (29.799 ms) : 0, 29799
section profiling
ProfilingAgent [baseline] (102.967 ms) : 0, 102967
ProfilingAgent [candidate] (103.663 ms) : 0, 103663
BytebuddyAgent [baseline] (671.525 ms) : 0, 671525
BytebuddyAgent [candidate] (671.469 ms) : 0, 671469
GlobalTracer [baseline] (373.004 ms) : 0, 373004
GlobalTracer [candidate] (374.033 ms) : 0, 374033
AppSec [baseline] (61.738 ms) : 0, 61738
AppSec [candidate] (62.631 ms) : 0, 62631
Debugger [baseline] (6.247 ms) : 0, 6247
Debugger [candidate] (6.292 ms) : 0, 6292
Remote Config [baseline] (664.957 µs) : 0, 665
Remote Config [candidate] (666.923 µs) : 0, 667
Telemetry [baseline] (8.177 ms) : 0, 8177
Telemetry [candidate] (8.234 ms) : 0, 8234
Profiling [baseline] (102.99 ms) : 0, 102990
Profiling [candidate] (103.688 ms) : 0, 103688
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~e2f2c9a5c8, baseline=1.50.0-SNAPSHOT~7c80dbede3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1021098
Total [baseline] (8.683 s) : 0, 8682681
Agent [candidate] (1.027 s) : 0, 1026702
Total [candidate] (8.705 s) : 0, 8705097
section iast
Agent [baseline] (1.15 s) : 0, 1149830
Total [baseline] (9.203 s) : 0, 9203333
Agent [candidate] (1.148 s) : 0, 1148381
Total [candidate] (9.259 s) : 0, 9258516
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.148 s) : 0, 1148490
Total [baseline] (9.187 s) : 0, 9186604
Agent [candidate] (1.15 s) : 0, 1150280
Total [candidate] (9.189 s) : 0, 9188855
section iast_TELEMETRY_OFF
Agent [baseline] (1.144 s) : 0, 1144178
Total [baseline] (9.267 s) : 0, 9267289
Agent [candidate] (1.143 s) : 0, 1142970
Total [candidate] (9.219 s) : 0, 9219005
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.021 s -
Agent iast 1.15 s 128.732 ms (12.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.148 s 127.393 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.144 s 123.08 ms (12.1%)
Total tracing 8.683 s -
Total iast 9.203 s 520.652 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.187 s 503.923 ms (5.8%)
Total iast_TELEMETRY_OFF 9.267 s 584.608 ms (6.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.027 s -
Agent iast 1.148 s 121.679 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.15 s 123.578 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.143 s 116.268 ms (11.3%)
Total tracing 8.705 s -
Total iast 9.259 s 553.42 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.189 s 483.758 ms (5.6%)
Total iast_TELEMETRY_OFF 9.219 s 513.908 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~e2f2c9a5c8, baseline=1.50.0-SNAPSHOT~7c80dbede3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.483 ms) : 0, 682483
BytebuddyAgent [candidate] (688.944 ms) : 0, 688944
GlobalTracer [baseline] (240.017 ms) : 0, 240017
GlobalTracer [candidate] (241.003 ms) : 0, 241003
AppSec [baseline] (54.449 ms) : 0, 54449
AppSec [candidate] (54.76 ms) : 0, 54760
Debugger [baseline] (9.165 ms) : 0, 9165
Debugger [candidate] (8.333 ms) : 0, 8333
Remote Config [baseline] (685.496 µs) : 0, 685
Remote Config [candidate] (710.204 µs) : 0, 710
Telemetry [baseline] (10.531 ms) : 0, 10531
Telemetry [candidate] (9.143 ms) : 0, 9143
section iast
BytebuddyAgent [baseline] (802.593 ms) : 0, 802593
BytebuddyAgent [candidate] (801.839 ms) : 0, 801839
GlobalTracer [baseline] (230.324 ms) : 0, 230324
GlobalTracer [candidate] (230.873 ms) : 0, 230873
IAST [baseline] (28.472 ms) : 0, 28472
IAST [candidate] (28.889 ms) : 0, 28889
AppSec [baseline] (50.517 ms) : 0, 50517
AppSec [candidate] (49.032 ms) : 0, 49032
Debugger [baseline] (5.899 ms) : 0, 5899
Debugger [candidate] (5.834 ms) : 0, 5834
Remote Config [baseline] (616.8 µs) : 0, 617
Remote Config [candidate] (591.181 µs) : 0, 591
Telemetry [baseline] (7.82 ms) : 0, 7820
Telemetry [candidate] (7.795 ms) : 0, 7795
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (801.568 ms) : 0, 801568
BytebuddyAgent [candidate] (803.863 ms) : 0, 803863
GlobalTracer [baseline] (229.955 ms) : 0, 229955
GlobalTracer [candidate] (229.711 ms) : 0, 229711
IAST [baseline] (27.723 ms) : 0, 27723
IAST [candidate] (29.158 ms) : 0, 29158
AppSec [baseline] (51.409 ms) : 0, 51409
AppSec [candidate] (49.495 ms) : 0, 49495
Debugger [baseline] (5.889 ms) : 0, 5889
Debugger [candidate] (5.91 ms) : 0, 5910
Remote Config [baseline] (587.719 µs) : 0, 588
Remote Config [candidate] (586.172 µs) : 0, 586
Telemetry [baseline] (7.923 ms) : 0, 7923
Telemetry [candidate] (7.913 ms) : 0, 7913
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.471 ms) : 0, 797471
BytebuddyAgent [candidate] (796.968 ms) : 0, 796968
GlobalTracer [baseline] (230.015 ms) : 0, 230015
GlobalTracer [candidate] (230.452 ms) : 0, 230452
IAST [baseline] (22.297 ms) : 0, 22297
IAST [candidate] (22.302 ms) : 0, 22302
AppSec [baseline] (56.463 ms) : 0, 56463
AppSec [candidate] (55.461 ms) : 0, 55461
Debugger [baseline] (6.024 ms) : 0, 6024
Debugger [candidate] (5.94 ms) : 0, 5940
Remote Config [baseline] (603.123 µs) : 0, 603
Remote Config [candidate] (589.708 µs) : 0, 590
Telemetry [baseline] (7.769 ms) : 0, 7769
Telemetry [candidate] (7.716 ms) : 0, 7716
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-05-14T14:02:03 2025-05-14T14:09:47
git_branch master andrea.marziali/liberty-fix
git_commit_date 1747229243 1747230805
git_commit_sha 7c80dbe e2f2c9a
release_version 1.50.0-SNAPSHOT~7c80dbede3 1.50.0-SNAPSHOT~e2f2c9a5c8
start_time 2025-05-14T14:01:49 2025-05-14T14:09:33
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747232184 1747232184
ci_job_id 937923376 937923376
ci_pipeline_id 65071769 65071769
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-n8gyx9gk-project-304-concurrent-1-dqrpzgp1 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-n8gyx9gk-project-304-concurrent-1-dqrpzgp1 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~e2f2c9a5c8, baseline=1.50.0-SNAPSHOT~7c80dbede3
    dateFormat X
    axisFormat %s
section baseline
no_agent (384.268 µs) : 365, 404
.   : milestone, 384,
iast (518.544 µs) : 497, 540
.   : milestone, 519,
iast_FULL (736.907 µs) : 715, 759
.   : milestone, 737,
iast_GLOBAL (572.177 µs) : 549, 595
.   : milestone, 572,
iast_HARDCODED_SECRET_DISABLED (523.572 µs) : 501, 546
.   : milestone, 524,
iast_INACTIVE (471.557 µs) : 448, 495
.   : milestone, 472,
iast_TELEMETRY_OFF (499.869 µs) : 477, 523
.   : milestone, 500,
tracing (460.713 µs) : 439, 483
.   : milestone, 461,
section candidate
no_agent (388.045 µs) : 367, 409
.   : milestone, 388,
iast (513.51 µs) : 492, 535
.   : milestone, 514,
iast_FULL (734.796 µs) : 713, 757
.   : milestone, 735,
iast_GLOBAL (577.597 µs) : 555, 600
.   : milestone, 578,
iast_HARDCODED_SECRET_DISABLED (529.638 µs) : 507, 552
.   : milestone, 530,
iast_INACTIVE (466.862 µs) : 444, 489
.   : milestone, 467,
iast_TELEMETRY_OFF (507.071 µs) : 484, 530
.   : milestone, 507,
tracing (460.227 µs) : 438, 483
.   : milestone, 460,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 384.268 µs [364.559 µs, 403.978 µs] -
iast 518.544 µs [496.666 µs, 540.422 µs] 134.276 µs (34.9%)
iast_FULL 736.907 µs [714.844 µs, 758.97 µs] 352.639 µs (91.8%)
iast_GLOBAL 572.177 µs [549.379 µs, 594.975 µs] 187.909 µs (48.9%)
iast_HARDCODED_SECRET_DISABLED 523.572 µs [501.004 µs, 546.14 µs] 139.304 µs (36.3%)
iast_INACTIVE 471.557 µs [448.436 µs, 494.677 µs] 87.288 µs (22.7%)
iast_TELEMETRY_OFF 499.869 µs [476.81 µs, 522.928 µs] 115.601 µs (30.1%)
tracing 460.713 µs [438.876 µs, 482.549 µs] 76.444 µs (19.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 388.045 µs [367.244 µs, 408.846 µs] -
iast 513.51 µs [491.875 µs, 535.144 µs] 125.464 µs (32.3%)
iast_FULL 734.796 µs [712.875 µs, 756.716 µs] 346.75 µs (89.4%)
iast_GLOBAL 577.597 µs [554.725 µs, 600.468 µs] 189.551 µs (48.8%)
iast_HARDCODED_SECRET_DISABLED 529.638 µs [507.059 µs, 552.218 µs] 141.593 µs (36.5%)
iast_INACTIVE 466.862 µs [444.342 µs, 489.382 µs] 78.817 µs (20.3%)
iast_TELEMETRY_OFF 507.071 µs [483.884 µs, 530.259 µs] 119.026 µs (30.7%)
tracing 460.227 µs [437.736 µs, 482.718 µs] 72.182 µs (18.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~e2f2c9a5c8, baseline=1.50.0-SNAPSHOT~7c80dbede3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.345 ms) : 1326, 1365
.   : milestone, 1345,
appsec (1.762 ms) : 1738, 1786
.   : milestone, 1762,
appsec_no_iast (1.735 ms) : 1712, 1758
.   : milestone, 1735,
code_origins (1.673 ms) : 1643, 1703
.   : milestone, 1673,
iast (1.529 ms) : 1506, 1553
.   : milestone, 1529,
profiling (1.514 ms) : 1490, 1537
.   : milestone, 1514,
tracing (1.484 ms) : 1460, 1508
.   : milestone, 1484,
section candidate
no_agent (1.357 ms) : 1339, 1376
.   : milestone, 1357,
appsec (1.735 ms) : 1712, 1759
.   : milestone, 1735,
appsec_no_iast (1.731 ms) : 1708, 1755
.   : milestone, 1731,
code_origins (1.68 ms) : 1653, 1706
.   : milestone, 1680,
iast (1.499 ms) : 1475, 1524
.   : milestone, 1499,
profiling (1.512 ms) : 1489, 1536
.   : milestone, 1512,
tracing (1.495 ms) : 1472, 1519
.   : milestone, 1495,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.326 ms, 1.365 ms] -
appsec 1.762 ms [1.738 ms, 1.786 ms] 416.781 µs (31.0%)
appsec_no_iast 1.735 ms [1.712 ms, 1.758 ms] 389.783 µs (29.0%)
code_origins 1.673 ms [1.643 ms, 1.703 ms] 327.534 µs (24.3%)
iast 1.529 ms [1.506 ms, 1.553 ms] 183.892 µs (13.7%)
profiling 1.514 ms [1.49 ms, 1.537 ms] 168.375 µs (12.5%)
tracing 1.484 ms [1.46 ms, 1.508 ms] 138.615 µs (10.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.357 ms [1.339 ms, 1.376 ms] -
appsec 1.735 ms [1.712 ms, 1.759 ms] 377.671 µs (27.8%)
appsec_no_iast 1.731 ms [1.708 ms, 1.755 ms] 373.876 µs (27.5%)
code_origins 1.68 ms [1.653 ms, 1.706 ms] 322.458 µs (23.8%)
iast 1.499 ms [1.475 ms, 1.524 ms] 141.741 µs (10.4%)
profiling 1.512 ms [1.489 ms, 1.536 ms] 154.914 µs (11.4%)
tracing 1.495 ms [1.472 ms, 1.519 ms] 138.023 µs (10.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/liberty-fix
git_commit_date 1747229243 1747230805
git_commit_sha 7c80dbe e2f2c9a
release_version 1.50.0-SNAPSHOT~7c80dbede3 1.50.0-SNAPSHOT~e2f2c9a5c8
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1747232841 1747232841
ci_job_id 937923377 937923377
ci_pipeline_id 65071769 65071769
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-px6-mzwm-project-304-concurrent-3-bfuo2azt 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-px6-mzwm-project-304-concurrent-3-bfuo2azt 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~e2f2c9a5c8, baseline=1.50.0-SNAPSHOT~7c80dbede3
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.496 s) : 15496000, 15496000
.   : milestone, 15496000,
appsec (14.966 s) : 14966000, 14966000
.   : milestone, 14966000,
iast (18.487 s) : 18487000, 18487000
.   : milestone, 18487000,
iast_GLOBAL (18.198 s) : 18198000, 18198000
.   : milestone, 18198000,
profiling (14.876 s) : 14876000, 14876000
.   : milestone, 14876000,
tracing (15.007 s) : 15007000, 15007000
.   : milestone, 15007000,
section candidate
no_agent (14.926 s) : 14926000, 14926000
.   : milestone, 14926000,
appsec (15.164 s) : 15164000, 15164000
.   : milestone, 15164000,
iast (18.52 s) : 18520000, 18520000
.   : milestone, 18520000,
iast_GLOBAL (18.157 s) : 18157000, 18157000
.   : milestone, 18157000,
profiling (15.272 s) : 15272000, 15272000
.   : milestone, 15272000,
tracing (15.0 s) : 15000000, 15000000
.   : milestone, 15000000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.496 s [15.496 s, 15.496 s] -
appsec 14.966 s [14.966 s, 14.966 s] -530.0 ms (-3.4%)
iast 18.487 s [18.487 s, 18.487 s] 2.991 s (19.3%)
iast_GLOBAL 18.198 s [18.198 s, 18.198 s] 2.702 s (17.4%)
profiling 14.876 s [14.876 s, 14.876 s] -620.0 ms (-4.0%)
tracing 15.007 s [15.007 s, 15.007 s] -489.0 ms (-3.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.926 s [14.926 s, 14.926 s] -
appsec 15.164 s [15.164 s, 15.164 s] 238.0 ms (1.6%)
iast 18.52 s [18.52 s, 18.52 s] 3.594 s (24.1%)
iast_GLOBAL 18.157 s [18.157 s, 18.157 s] 3.231 s (21.6%)
profiling 15.272 s [15.272 s, 15.272 s] 346.0 ms (2.3%)
tracing 15.0 s [15.0 s, 15.0 s] 74.0 ms (0.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~e2f2c9a5c8, baseline=1.50.0-SNAPSHOT~7c80dbede3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.488 ms) : 1476, 1500
.   : milestone, 1488,
appsec (2.438 ms) : 2388, 2487
.   : milestone, 2438,
iast (2.206 ms) : 2143, 2269
.   : milestone, 2206,
iast_GLOBAL (2.241 ms) : 2178, 2303
.   : milestone, 2241,
profiling (2.062 ms) : 2012, 2113
.   : milestone, 2062,
tracing (2.025 ms) : 1977, 2073
.   : milestone, 2025,
section candidate
no_agent (1.489 ms) : 1477, 1501
.   : milestone, 1489,
appsec (2.43 ms) : 2381, 2479
.   : milestone, 2430,
iast (2.196 ms) : 2134, 2257
.   : milestone, 2196,
iast_GLOBAL (2.24 ms) : 2178, 2303
.   : milestone, 2240,
profiling (2.069 ms) : 2018, 2120
.   : milestone, 2069,
tracing (2.029 ms) : 1981, 2078
.   : milestone, 2029,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.488 ms [1.476 ms, 1.5 ms] -
appsec 2.438 ms [2.388 ms, 2.487 ms] 949.949 µs (63.8%)
iast 2.206 ms [2.143 ms, 2.269 ms] 718.21 µs (48.3%)
iast_GLOBAL 2.241 ms [2.178 ms, 2.303 ms] 752.721 µs (50.6%)
profiling 2.062 ms [2.012 ms, 2.113 ms] 574.547 µs (38.6%)
tracing 2.025 ms [1.977 ms, 2.073 ms] 537.039 µs (36.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.489 ms [1.477 ms, 1.501 ms] -
appsec 2.43 ms [2.381 ms, 2.479 ms] 941.106 µs (63.2%)
iast 2.196 ms [2.134 ms, 2.257 ms] 706.711 µs (47.5%)
iast_GLOBAL 2.24 ms [2.178 ms, 2.303 ms] 751.583 µs (50.5%)
profiling 2.069 ms [2.018 ms, 2.12 ms] 580.421 µs (39.0%)
tracing 2.029 ms [1.981 ms, 2.078 ms] 540.528 µs (36.3%)

@amarziali amarziali force-pushed the andrea.marziali/liberty-fix branch from 04d2bea to e2f2c9a Compare May 14, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vandonr vandonr vandonr approved these changes

Assignees
No one assigned
Labels
inst: others All other instrumentations type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amarziali @vandonr