-
Notifications
You must be signed in to change notification settings - Fork 304
Use JDK 8 by default #8883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
smola
wants to merge
5
commits into
master
Choose a base branch
from
smola/gradle-3-toolchain8
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Use JDK 8 by default #8883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 55 metrics, 11 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~5e7ffc43ea, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1023343
Total [baseline] (10.523 s) : 0, 10522853
Agent [candidate] (1.021 s) : 0, 1021355
Total [candidate] (10.503 s) : 0, 10503393
section appsec
Agent [baseline] (1.167 s) : 0, 1166801
Total [baseline] (10.731 s) : 0, 10730734
Agent [candidate] (1.165 s) : 0, 1164571
Total [candidate] (10.694 s) : 0, 10694455
section iast
Agent [baseline] (1.15 s) : 0, 1150097
Total [baseline] (10.814 s) : 0, 10813757
Agent [candidate] (1.153 s) : 0, 1152950
Total [candidate] (10.853 s) : 0, 10852651
section profiling
Agent [baseline] (1.287 s) : 0, 1286865
Total [baseline] (10.851 s) : 0, 10851331
Agent [candidate] (1.28 s) : 0, 1280449
Total [candidate] (10.82 s) : 0, 10820020
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~5e7ffc43ea, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.285 ms) : 0, 683285
BytebuddyAgent [candidate] (683.54 ms) : 0, 683540
GlobalTracer [baseline] (240.314 ms) : 0, 240314
GlobalTracer [candidate] (240.639 ms) : 0, 240639
AppSec [baseline] (55.169 ms) : 0, 55169
AppSec [candidate] (56.038 ms) : 0, 56038
Debugger [baseline] (12.008 ms) : 0, 12008
Debugger [candidate] (6.881 ms) : 0, 6881
Remote Config [baseline] (674.259 µs) : 0, 674
Remote Config [candidate] (722.624 µs) : 0, 723
Telemetry [baseline] (8.215 ms) : 0, 8215
Telemetry [candidate] (9.937 ms) : 0, 9937
section appsec
BytebuddyAgent [baseline] (703.13 ms) : 0, 703130
BytebuddyAgent [candidate] (702.6 ms) : 0, 702600
GlobalTracer [baseline] (238.084 ms) : 0, 238084
GlobalTracer [candidate] (237.458 ms) : 0, 237458
IAST [baseline] (22.166 ms) : 0, 22166
IAST [candidate] (21.816 ms) : 0, 21816
AppSec [baseline] (175.961 ms) : 0, 175961
AppSec [candidate] (175.911 ms) : 0, 175911
Debugger [baseline] (6.011 ms) : 0, 6011
Debugger [candidate] (5.988 ms) : 0, 5988
Remote Config [baseline] (626.358 µs) : 0, 626
Remote Config [candidate] (626.687 µs) : 0, 627
Telemetry [baseline] (8.196 ms) : 0, 8196
Telemetry [candidate] (7.414 ms) : 0, 7414
section iast
BytebuddyAgent [baseline] (802.707 ms) : 0, 802707
BytebuddyAgent [candidate] (804.488 ms) : 0, 804488
GlobalTracer [baseline] (230.729 ms) : 0, 230729
GlobalTracer [candidate] (231.57 ms) : 0, 231570
IAST [baseline] (29.211 ms) : 0, 29211
IAST [candidate] (29.384 ms) : 0, 29384
AppSec [baseline] (49.59 ms) : 0, 49590
AppSec [candidate] (49.488 ms) : 0, 49488
Debugger [baseline] (5.866 ms) : 0, 5866
Debugger [candidate] (5.936 ms) : 0, 5936
Remote Config [baseline] (593.346 µs) : 0, 593
Remote Config [candidate] (593.082 µs) : 0, 593
Telemetry [baseline] (7.885 ms) : 0, 7885
Telemetry [candidate] (7.887 ms) : 0, 7887
section profiling
BytebuddyAgent [baseline] (675.539 ms) : 0, 675539
BytebuddyAgent [candidate] (683.305 ms) : 0, 683305
GlobalTracer [baseline] (380.147 ms) : 0, 380147
GlobalTracer [candidate] (362.973 ms) : 0, 362973
AppSec [baseline] (55.044 ms) : 0, 55044
AppSec [candidate] (62.478 ms) : 0, 62478
Debugger [baseline] (6.183 ms) : 0, 6183
Debugger [candidate] (6.337 ms) : 0, 6337
Remote Config [baseline] (670.423 µs) : 0, 670
Remote Config [candidate] (651.05 µs) : 0, 651
Telemetry [baseline] (8.154 ms) : 0, 8154
Telemetry [candidate] (8.368 ms) : 0, 8368
ProfilingAgent [baseline] (110.67 ms) : 0, 110670
ProfilingAgent [candidate] (104.778 ms) : 0, 104778
Profiling [baseline] (110.696 ms) : 0, 110696
Profiling [candidate] (104.802 ms) : 0, 104802
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~5e7ffc43ea, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1022539
Total [baseline] (8.64 s) : 0, 8639567
Agent [candidate] (1.026 s) : 0, 1026313
Total [candidate] (8.642 s) : 0, 8641650
section iast
Agent [baseline] (1.144 s) : 0, 1144049
Total [baseline] (9.215 s) : 0, 9214533
Agent [candidate] (1.153 s) : 0, 1153042
Total [candidate] (9.229 s) : 0, 9228622
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.147 s) : 0, 1146823
Total [baseline] (9.191 s) : 0, 9190702
Agent [candidate] (1.147 s) : 0, 1147322
Total [candidate] (9.141 s) : 0, 9141344
section iast_TELEMETRY_OFF
Agent [baseline] (1.14 s) : 0, 1140132
Total [baseline] (9.201 s) : 0, 9200585
Agent [candidate] (1.156 s) : 0, 1156204
Total [candidate] (9.23 s) : 0, 9230359
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~5e7ffc43ea, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.649 ms) : 0, 682649
BytebuddyAgent [candidate] (686.708 ms) : 0, 686708
GlobalTracer [baseline] (240.263 ms) : 0, 240263
GlobalTracer [candidate] (241.328 ms) : 0, 241328
AppSec [baseline] (55.223 ms) : 0, 55223
AppSec [candidate] (54.748 ms) : 0, 54748
Debugger [baseline] (11.968 ms) : 0, 11968
Debugger [candidate] (9.217 ms) : 0, 9217
Remote Config [baseline] (691.001 µs) : 0, 691
Remote Config [candidate] (738.343 µs) : 0, 738
Telemetry [baseline] (8.212 ms) : 0, 8212
Telemetry [candidate] (9.837 ms) : 0, 9837
section iast
BytebuddyAgent [baseline] (798.907 ms) : 0, 798907
BytebuddyAgent [candidate] (805.227 ms) : 0, 805227
GlobalTracer [baseline] (229.338 ms) : 0, 229338
GlobalTracer [candidate] (231.657 ms) : 0, 231657
IAST [baseline] (29.814 ms) : 0, 29814
IAST [candidate] (29.945 ms) : 0, 29945
AppSec [baseline] (48.324 ms) : 0, 48324
AppSec [candidate] (48.308 ms) : 0, 48308
Debugger [baseline] (5.849 ms) : 0, 5849
Debugger [candidate] (5.909 ms) : 0, 5909
Remote Config [baseline] (589.2 µs) : 0, 589
Remote Config [candidate] (594.41 µs) : 0, 594
Telemetry [baseline] (7.831 ms) : 0, 7831
Telemetry [candidate] (7.849 ms) : 0, 7849
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.177 ms) : 0, 800177
BytebuddyAgent [candidate] (801.166 ms) : 0, 801166
GlobalTracer [baseline] (230.094 ms) : 0, 230094
GlobalTracer [candidate] (230.223 ms) : 0, 230223
IAST [baseline] (29.147 ms) : 0, 29147
IAST [candidate] (28.952 ms) : 0, 28952
AppSec [baseline] (49.466 ms) : 0, 49466
AppSec [candidate] (49.219 ms) : 0, 49219
Debugger [baseline] (5.959 ms) : 0, 5959
Debugger [candidate] (5.862 ms) : 0, 5862
Remote Config [baseline] (604.26 µs) : 0, 604
Remote Config [candidate] (602.554 µs) : 0, 603
Telemetry [baseline] (7.965 ms) : 0, 7965
Telemetry [candidate] (7.863 ms) : 0, 7863
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (795.216 ms) : 0, 795216
BytebuddyAgent [candidate] (806.915 ms) : 0, 806915
GlobalTracer [baseline] (229.477 ms) : 0, 229477
GlobalTracer [candidate] (232.402 ms) : 0, 232402
IAST [baseline] (22.155 ms) : 0, 22155
IAST [candidate] (22.526 ms) : 0, 22526
AppSec [baseline] (55.618 ms) : 0, 55618
AppSec [candidate] (56.166 ms) : 0, 56166
Debugger [baseline] (5.886 ms) : 0, 5886
Debugger [candidate] (6.024 ms) : 0, 6024
Remote Config [baseline] (588.659 µs) : 0, 589
Remote Config [candidate] (612.386 µs) : 0, 612
Telemetry [baseline] (7.762 ms) : 0, 7762
Telemetry [candidate] (7.837 ms) : 0, 7837
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~5e7ffc43ea, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.362 ms) : 1342, 1383
. : milestone, 1362,
appsec (1.736 ms) : 1712, 1761
. : milestone, 1736,
appsec_no_iast (1.739 ms) : 1716, 1763
. : milestone, 1739,
code_origins (1.657 ms) : 1630, 1684
. : milestone, 1657,
iast (1.521 ms) : 1496, 1545
. : milestone, 1521,
profiling (1.503 ms) : 1480, 1527
. : milestone, 1503,
tracing (1.498 ms) : 1474, 1522
. : milestone, 1498,
section candidate
no_agent (1.366 ms) : 1346, 1385
. : milestone, 1366,
appsec (1.749 ms) : 1725, 1772
. : milestone, 1749,
appsec_no_iast (1.726 ms) : 1702, 1749
. : milestone, 1726,
code_origins (1.679 ms) : 1653, 1706
. : milestone, 1679,
iast (1.521 ms) : 1497, 1544
. : milestone, 1521,
profiling (1.523 ms) : 1499, 1547
. : milestone, 1523,
tracing (1.486 ms) : 1463, 1509
. : milestone, 1486,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~5e7ffc43ea, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (387.113 µs) : 367, 408
. : milestone, 387,
iast (519.878 µs) : 498, 542
. : milestone, 520,
iast_FULL (740.205 µs) : 718, 762
. : milestone, 740,
iast_GLOBAL (568.928 µs) : 547, 591
. : milestone, 569,
iast_HARDCODED_SECRET_DISABLED (531.829 µs) : 509, 555
. : milestone, 532,
iast_INACTIVE (470.117 µs) : 447, 493
. : milestone, 470,
iast_TELEMETRY_OFF (517.85 µs) : 495, 541
. : milestone, 518,
tracing (458.378 µs) : 436, 481
. : milestone, 458,
section candidate
no_agent (385.929 µs) : 364, 408
. : milestone, 386,
iast (517.614 µs) : 494, 541
. : milestone, 518,
iast_FULL (744.322 µs) : 721, 768
. : milestone, 744,
iast_GLOBAL (567.781 µs) : 546, 590
. : milestone, 568,
iast_HARDCODED_SECRET_DISABLED (529.149 µs) : 506, 552
. : milestone, 529,
iast_INACTIVE (463.016 µs) : 441, 486
. : milestone, 463,
iast_TELEMETRY_OFF (498.826 µs) : 476, 522
. : milestone, 499,
tracing (461.888 µs) : 440, 484
. : milestone, 462,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~5e7ffc43ea, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (15.053 s) : 15053000, 15053000
. : milestone, 15053000,
appsec (14.931 s) : 14931000, 14931000
. : milestone, 14931000,
iast (18.841 s) : 18841000, 18841000
. : milestone, 18841000,
iast_GLOBAL (18.269 s) : 18269000, 18269000
. : milestone, 18269000,
profiling (14.874 s) : 14874000, 14874000
. : milestone, 14874000,
tracing (14.871 s) : 14871000, 14871000
. : milestone, 14871000,
section candidate
no_agent (14.965 s) : 14965000, 14965000
. : milestone, 14965000,
appsec (15.076 s) : 15076000, 15076000
. : milestone, 15076000,
iast (18.829 s) : 18829000, 18829000
. : milestone, 18829000,
iast_GLOBAL (18.061 s) : 18061000, 18061000
. : milestone, 18061000,
profiling (14.976 s) : 14976000, 14976000
. : milestone, 14976000,
tracing (14.7 s) : 14700000, 14700000
. : milestone, 14700000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~5e7ffc43ea, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.484 ms) : 1473, 1496
. : milestone, 1484,
appsec (2.408 ms) : 2359, 2457
. : milestone, 2408,
iast (2.193 ms) : 2132, 2254
. : milestone, 2193,
iast_GLOBAL (2.227 ms) : 2165, 2288
. : milestone, 2227,
profiling (2.029 ms) : 1980, 2078
. : milestone, 2029,
tracing (2.02 ms) : 1972, 2068
. : milestone, 2020,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.416 ms) : 2367, 2465
. : milestone, 2416,
iast (2.182 ms) : 2121, 2244
. : milestone, 2182,
iast_GLOBAL (2.224 ms) : 2163, 2286
. : milestone, 2224,
profiling (2.472 ms) : 2239, 2705
. : milestone, 2472,
tracing (2.007 ms) : 1959, 2054
. : milestone, 2007,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Use JDK 8 by default, explicitly, to allow running gradle with newer JDKs.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APMJAVA-1342