Default obfuscation regexp update #8937
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezen-datadog
force-pushed
the
sezen.leblay/APPSEC-57270-default-regex-change
branch
from
f0f5955 to
5186564
Compare
AlexeyKuznetsov-DD
requested changes
Jun 6, 2025
Comment on lines
122
to
130
| if (wafHandle != null && !wafHandle.isOnline()) { | ||
| wafHandle.close(); | ||
| } | ||
| if (wafContext != null && !wafContext.isOnline()) { | ||
| wafContext.close(); | ||
| } | ||
| if (wafBuilder != null && !wafBuilder.isOnline()) { | ||
| wafBuilder.close(); | ||
| } |
There was a problem hiding this comment.
I think the isOnline() check might not need to be negated here. Could you please double-check this logic?
Suggested change
| if (wafHandle != null && !wafHandle.isOnline()) { | |
| wafHandle.close(); | |
| } | |
| if (wafContext != null && !wafContext.isOnline()) { | |
| wafContext.close(); | |
| } | |
| if (wafBuilder != null && !wafBuilder.isOnline()) { | |
| wafBuilder.close(); | |
| } | |
| if (wafHandle != null && wafHandle.isOnline()) { | |
| wafHandle.close(); | |
| } | |
| if (wafContext != null && wafContext.isOnline()) { | |
| wafContext.close(); | |
| } | |
| if (wafBuilder != null && wafBuilder.isOnline()) { | |
| wafBuilder.close(); | |
| } |
There was a problem hiding this comment.
Note this is a stacked PR. These changes are from: #8654
There was a problem hiding this comment.
But good point. I do think this logic is reversed.
There was a problem hiding this comment.
corrected in the original PR, thank you!
sezen-datadog
changed the base branch from
master
to
sezen.leblay/upgrade-libddwaf-java-1.23
Signed-off-by: sezen.leblay <[email protected]>
Signed-off-by: sezen.leblay <[email protected]>
sezen-datadog
force-pushed
the
sezen.leblay/APPSEC-57270-default-regex-change
branch
from
5186564 to
24555b6
Compare
Signed-off-by: sezen.leblay <[email protected]>
sezen-datadog
force-pushed
the
sezen.leblay/upgrade-libddwaf-java-1.23
branch
from
6c47b1e to
42f13c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Updates libddwaf-java version to have the new regex key for obfuscation
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APPSEC-57270