Skip to content

WIP: separate span and noop into their own storages#5393

Closed
ida613 wants to merge 5 commits intomasterfrom
ida613/span-stores
Closed

WIP: separate span and noop into their own storages#5393
ida613 wants to merge 5 commits intomasterfrom
ida613/span-stores

Conversation

@ida613
Copy link
Collaborator

@ida613 ida613 commented Mar 12, 2025

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025

Overall package size

Self size: 8.9 MB
Deduped: 95.51 MB
No deduping: 96.02 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.0 | 19.26 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 840.3 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.40%. Comparing base (52279e0) to head (b1e985a).
⚠️ Report is 564 commits behind head on master.

Files with missing lines Patch % Lines
packages/dd-trace/src/plugins/plugin.js 80.00% 1 Missing ⚠️
packages/dd-trace/src/profiling/exporters/agent.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5393      +/-   ##
==========================================
- Coverage   80.65%   75.40%   -5.26%     
==========================================
  Files         492      470      -22     
  Lines       21989    20735    -1254     
==========================================
- Hits        17736    15635    -2101     
- Misses       4253     5100     +847     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Mar 12, 2025

Benchmarks

Benchmark execution time: 2025-03-12 20:07:14

Comparing candidate commit b1e985a in PR branch ida613/span-stores with baseline commit 52279e0 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 913 metrics, 20 unstable metrics.

@BridgeAR
Copy link
Member

BridgeAR commented Jul 8, 2025

I am currently cleaning up old drafts. This one has conflicts and I am not sure if this is something you still want to actively work on @ida613. If not, I guess we could close this?

@ida613
Copy link
Collaborator Author

ida613 commented Jul 30, 2025

this PR has been on hold for too long, closing for now

@ida613 ida613 closed this Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants