Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: monitor io-valkey #5484

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nico385412
Copy link

@Nico385412 Nico385412 commented Mar 25, 2025

What does this PR do?

This PR will make datadog able to trace valkey

Motivation

It's about amost year now that redis change his licence and valkey was born right after this.

Since then, time has passed and we start having some mismatch between the two and some commands in redis are not compatible anymore (or not yet) with valkey
For exemple HEXPIRE

For a while, ioredis was compatible with redis but in the future ... meh

So i would like to instrument the official lib for valkey and help the community.

Plugin Checklist

Additional Notes

@Nico385412 Nico385412 requested review from a team as code owners March 25, 2025 21:33
@Nico385412 Nico385412 force-pushed the feat/init-io-valkey branch from 397bc59 to 6489464 Compare March 25, 2025 21:37
const rawExpectedSchema = {
outbound: {
v0: {
opName: 'redis.command',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to figure out if it's better to have a valkey.command option here. The two services are very similar but I'm not sure what the UI implications are. It seems that long term we'd be better off with valkey.command but in the short term using redis.command probably "just works".

@tlhunter
Copy link
Member

tlhunter commented Mar 28, 2025

Thanks for this PR! I'm going to ask around about the resource names. FYI I'll need to duplicate this PR to "bless" it with CI.

Looks like we should be using a valkey. prefix after all:
https://github.com/DataDog/dd-trace-java/pull/8228/files#diff-d6905711aa4f326699955bf67424754947999b4612aae65b4d706b21e6c97b4fR324-R358

The agent also understands valkey:
DataDog/datadog-agent#33187

@tlhunter tlhunter self-assigned this Mar 28, 2025
@Nico385412
Copy link
Author

Thanks for this PR! I'm going to ask around about the resource names. FYI I'll need to duplicate this PR to "bless" it with CI.

Looks like we should be using a valkey. prefix after all: https://github.com/DataDog/dd-trace-java/pull/8228/files#diff-d6905711aa4f326699955bf67424754947999b4612aae65b4d706b21e6c97b4fR324-R358

The agent also understands valkey: DataDog/datadog-agent#33187

Nice ! i'll let you duplicate the PR x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants