v5.44.0 proposal #5487

rochdev · 2025-03-26T14:09:05Z

[8f744b05ff] - (SEMVER-PATCH) Fix iast flaky code injection tests (Ugaitz Urien) #5460
[ca101dce10] - (SEMVER-PATCH) Add a few TODO's (Thomas Watson) #5477
[166207260d] - (SEMVER-MINOR) chore(llmobs): add span size telemetry metrics (Yun Kim) #5468
[288d38bc6f] - (SEMVER-PATCH) fix memory leak in runtime.node.heap.* metrics (Roch Devost) #5476
[d1d7ccf2aa] - (SEMVER-MINOR) waf requests telemetry metrics (Ilyas Shabi) #5384
[1a74c9b183] - (SEMVER-MINOR) feat(llmobs): add vertexai plugin (Sam Brenner) #5413
[959c5e6529] - (SEMVER-PATCH) Fix logging null when debugging and sending data without any error (simon-id) #5480
[f92be45ba7] - (SEMVER-PATCH) [test optimization] [SDTEST-1720] Change capabilities tagging to send version number (Mario Vidal Domínguez) #5463
[faea8912a2] - (SEMVER-MINOR) [test optimization] [SDTEST-1630] Attempt to fix flaky tests implementation (Mario Vidal Domínguez) #5429
[fac89882fd] - (SEMVER-PATCH) fix wrong test error message when expected span was not received (Roch Devost) #5447
[402741bbb4] - (SEMVER-PATCH) make cache action unix compatible and update test agent (Roch Devost) #5464
[fc756abf6a] - (SEMVER-PATCH) fix connection pool error in mongoose tests (Roch Devost) #5435
[de5df2a7d4] - (SEMVER-PATCH) fix release script esm error on node 20 (Roch Devost) #5368
[3bff8507eb] - (SEMVER-PATCH) chore(llmobs): add span.finished telemetry metric (Yun Kim) #5444
[f84216a10e] - (SEMVER-MINOR) feat(llmobs): add integration tag to llmobs spans (Yun Kim) #5465
[579d213a53] - (SEMVER-PATCH) replace node action cache with custom cache in ci (Roch Devost) #5454
[174a5cd944] - (SEMVER-PATCH) set dc-polyfill version to 0.1.6 (Roch Devost) #5457
[f6eefc5993] - (SEMVER-PATCH) retry npm install/view for appsec and plugins tests (Roch Devost) #5434
[b52b7fae08] - (SEMVER-PATCH) add matrix strategy to llmobs sdk ci job (Roch Devost) #5451
[86cbc0acca] - (SEMVER-PATCH) fix profiling test expectating minimum 2 requests instead of 1 (Roch Devost) #5449
[52a91c9f4a] - (SEMVER-PATCH) fix aws-sdk kinesis flaky dsm test (Roch Devost) #5446
[fa07ecf5c5] - (SEMVER-PATCH) fix amqplib flaky dsm tests (Roch Devost) #5445
[9d3ec95656] - (SEMVER-PATCH) fix mysql/mysql2/pg dbm trace id tests (Roch Devost) #5436
[604cfa03ee] - (SEMVER-PATCH) retry test agent start when it fails (Roch Devost) #5443
[8dc7f96e24] - (SEMVER-PATCH) lazy load dd-trace-api integration (Roch Devost) #5406
[38cb93514a] - (SEMVER-PATCH) increase next.js test timeout to 5 minutes (Roch Devost) #5442
[2c5e17c280] - (SEMVER-MINOR) dbm: tedious (sql server) service mode (Thomas Hunter II) #5375
[c5e5f8c0db] - (SEMVER-PATCH) [test optimization] Improve playwright flakiness (this time for real?) (Juan Antonio Fernández de Alba) #5440
[5e794c7519] - (SEMVER-PATCH) bump native appsec package (Ilyas Shabi) #5439
[a0fe0c5867] - (SEMVER-MINOR) Report waf init and update success and failure (Ilyas Shabi) #5388
[450abfffcd] - (SEMVER-PATCH) [test optimization] Fix playwright e2e tests flakiness (Juan Antonio Fernández de Alba) #5438

* Report waf init and update success * handle waf init failure * do not report ecent rules when success fails * remove default value of diagnosticsRules * use default args to report init

#5440)

* fix mysql dbm trace id test * fix mysql2 and pg * code cleanup

* Add integration tag to llmobs spans * Add integration tag to tests

* Add span.finished telemetry metric * Add decorator tag * address comments * Fix root parent bool * Add error tag * Fix boolean coalescing

* use old version of dependency instead of vendoring

* use tar for everything * update test-agent to 1.21.1

…tation (#5429)

… version number (#5463)

…5480) Co-authored-by: FredericEspiau <[email protected]>

* add llmobs plugin * wip tests * tests + ci workflow * move helper functions outside of class scope * add integration tag * Update packages/dd-trace/test/llmobs/plugins/google-cloud-vertexai/index.spec.js

* waf requests telemetry metrics * fix undefined versions * add more tests * fix tags order * update waf metrics integration test * remove duplicate input_truncated on test * fix waf requests telemtry test * fix rate limiter * report waf error metric * fix updateWafRateLimitedMetric reporter test * fix functions order * change function names * add versions to report attack * fix reporting rate limiting metric

* fix memory leak in runtime.node.heap metrics * switch to promise-based timers for test * add benchmark

* Add raw span size metric * Add processed span event size metrics * Refactor * Remove unnecessary check

github-actions · 2025-03-26T14:11:18Z

Overall package size

Self size: 9.1 MB
Deduped: 101.63 MB
No deduping: 102.15 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

codecov · 2025-03-26T14:11:50Z

Codecov Report

Attention: Patch coverage is 61.73121% with 168 lines in your changes missing coverage. Please review.

Please upload report for BASE (v5.x@33b1184). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...ckages/datadog-instrumentations/src/mocha/utils.js	0.00%	43 Missing ⚠️
packages/datadog-instrumentations/src/cucumber.js	0.00%	40 Missing ⚠️
packages/dd-trace/src/llmobs/telemetry.js	57.57%	14 Missing ⚠️
packages/dd-trace/src/llmobs/plugins/vertexai.js	86.17%	13 Missing ⚠️
...ackages/datadog-instrumentations/src/mocha/main.js	0.00%	12 Missing ⚠️
packages/dd-trace/src/plugins/util/test.js	50.00%	11 Missing ⚠️
packages/datadog-plugin-mocha/src/index.js	0.00%	10 Missing ⚠️
packages/datadog-plugin-cucumber/src/index.js	0.00%	9 Missing ⚠️
packages/dd-trace/src/llmobs/writers/spans/base.js	14.28%	6 Missing ⚠️
...atadog-plugin-google-cloud-vertexai/src/tracing.js	95.55%	4 Missing ⚠️
... and 3 more

Additional details and impacted files

@@           Coverage Diff           @@
##             v5.x    #5487   +/-   ##
=======================================
  Coverage        ?   79.28%           
=======================================
  Files           ?      514           
  Lines           ?    23174           
  Branches        ?        0           
=======================================
  Hits            ?    18373           
  Misses          ?     4801           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

datadog-datadog-prod-us1 · 2025-03-26T14:18:03Z

Datadog Report

Branch report: v5.44.0-proposal
Commit report: 9157ff2
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 919 Passed, 0 Skipped, 6m 48.75s Total Time

pr-commenter · 2025-03-26T14:21:51Z

Benchmarks

Benchmark execution time: 2025-03-26 14:21:48

Comparing candidate commit 38b0372 in PR branch v5.44.0-proposal with baseline commit 33b1184 in branch v5.x.

Found 5 performance improvements and 6 performance regressions! Performance is the same for 905 metrics, 17 unstable metrics.

scenario:plugin-http-server-control-18

🟩 cpu_user_time [-21.572ms; -12.862ms] or [-8.791%; -5.241%]
🟩 execution_time [-36.040ms; -33.738ms] or [-6.243%; -5.844%]

scenario:plugin-http-server-control-20

🟩 cpu_user_time [-14.345ms; -9.789ms] or [-8.407%; -5.737%]

scenario:plugin-http-server-control-22

🟩 cpu_user_time [-14.511ms; -9.741ms] or [-7.519%; -5.048%]
🟩 execution_time [-20.978ms; -18.550ms] or [-5.656%; -5.001%]

scenario:plugin-http-server-querystring-obfuscation-18

🟥 cpu_user_time [+16.404ms; +23.283ms] or [+6.150%; +8.728%]
🟥 execution_time [+50.514ms; +54.924ms] or [+5.018%; +5.456%]

scenario:plugin-http-server-querystring-obfuscation-20

🟥 cpu_user_time [+12.360ms; +17.219ms] or [+6.650%; +9.263%]
🟥 execution_time [+39.854ms; +43.868ms] or [+5.134%; +5.651%]

scenario:plugin-http-server-querystring-obfuscation-22

🟥 cpu_user_time [+12.837ms; +18.951ms] or [+6.299%; +9.299%]
🟥 execution_time [+38.834ms; +43.348ms] or [+5.273%; +5.886%]

juan-fernandez and others added 30 commits March 26, 2025 10:08

[test optimization] Fix playwright e2e tests flakiness (#5438)

942530a

Report waf init and update success and failure (#5388)

9461c3a

* Report waf init and update success * handle waf init failure * do not report ecent rules when success fails * remove default value of diagnosticsRules * use default args to report init

bump native appsec package (#5439)

0c8751c

[test optimization] Improve playwright flakiness (this time for real?) (

e374119

#5440)

dbm: tedious (sql server) service mode (#5375)

24a2607

increase next.js test timeout to 5 minutes (#5442)

edc0de4

lazy load dd-trace-api integration (#5406)

00b1529

retry test agent start when it fails (#5443)

9f46dbc

fix mysql/mysql2/pg dbm trace id tests (#5436)

aca4f05

* fix mysql dbm trace id test * fix mysql2 and pg * code cleanup

fix amqplib flaky dsm tests (#5445)

d5a436a

fix aws-sdk kinesis flaky dsm test (#5446)

7483391

fix profiling test expectating minimum 2 requests instead of 1 (#5449)

a68c72a

add matrix strategy to llmobs sdk ci job (#5451)

bcd9fbd

retry npm install/view for appsec and plugins tests (#5434)

5bdc342

set dc-polyfill version to 0.1.6 (#5457)

0a33d5d

replace node action cache with custom cache in ci (#5454)

b18ea0a

feat(llmobs): add integration tag to llmobs spans (#5465)

a41d43d

* Add integration tag to llmobs spans * Add integration tag to tests

chore(llmobs): add span.finished telemetry metric (#5444)

bc3be93

* Add span.finished telemetry metric * Add decorator tag * address comments * Fix root parent bool * Add error tag * Fix boolean coalescing

fix release script esm error on node 20 (#5368)

acbb8dc

* use old version of dependency instead of vendoring

fix connection pool error in mongoose tests (#5435)

7eda6c5

make cache action unix compatible and update test agent (#5464)

ac08612

* use tar for everything * update test-agent to 1.21.1

fix wrong test error message when expected span was not received (#5447)

4bd1de0

[test optimization] [SDTEST-1630] Attempt to fix flaky tests implemen…

7c5cecd

…tation (#5429)

[test optimization] [SDTEST-1720] Change capabilities tagging to send…

0075b25

… version number (#5463)

Fix logging null when debugging and sending data without any error (#…

23bdda6

…5480) Co-authored-by: FredericEspiau <[email protected]>

feat(llmobs): add vertexai plugin (#5413)

5027915

* add llmobs plugin * wip tests * tests + ci workflow * move helper functions outside of class scope * add integration tag * Update packages/dd-trace/test/llmobs/plugins/google-cloud-vertexai/index.spec.js

fix memory leak in runtime.node.heap.* metrics (#5476)

a385cac

* fix memory leak in runtime.node.heap metrics * switch to promise-based timers for test * add benchmark

chore(llmobs): add span size telemetry metrics (#5468)

90ab0cb

* Add raw span size metric * Add processed span event size metrics * Refactor * Remove unnecessary check

Add a few TODO's (#5477)

1b8d583

uurien and others added 2 commits March 26, 2025 10:08

Fix iast flaky code injection tests (#5460)

8370d31

v5.44.0

38b0372

rochdev marked this pull request as ready for review March 26, 2025 14:28

rochdev requested a review from a team as a code owner March 26, 2025 14:28

bengl approved these changes Mar 26, 2025

View reviewed changes

rochdev merged commit f2a38c1 into v5.x Mar 26, 2025
429 checks passed

rochdev deleted the v5.44.0-proposal branch March 26, 2025 14:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v5.44.0 proposal #5487

v5.44.0 proposal #5487

rochdev commented Mar 26, 2025 •

edited by jira bot

Loading

github-actions bot commented Mar 26, 2025

codecov bot commented Mar 26, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Mar 26, 2025

pr-commenter bot commented Mar 26, 2025

v5.44.0 proposal #5487

v5.44.0 proposal #5487

Conversation

rochdev commented Mar 26, 2025 • edited by jira bot Loading

github-actions bot commented Mar 26, 2025

Overall package size

codecov bot commented Mar 26, 2025 • edited Loading

Codecov Report

datadog-datadog-prod-us1 bot commented Mar 26, 2025

Datadog Report

pr-commenter bot commented Mar 26, 2025

Benchmarks

scenario:plugin-http-server-control-18

scenario:plugin-http-server-control-20

scenario:plugin-http-server-control-22

scenario:plugin-http-server-querystring-obfuscation-18

scenario:plugin-http-server-querystring-obfuscation-20

scenario:plugin-http-server-querystring-obfuscation-22

rochdev commented Mar 26, 2025 •

edited by jira bot

Loading

codecov bot commented Mar 26, 2025 •

edited

Loading