Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Improve integration test error handling #5500

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

watson
Copy link
Collaborator

@watson watson commented Mar 30, 2025

What does this PR do?

In case the integration tests times out trying to create the sandbox, don't also fail trying to remove it (since it doesn't exist).

Motivation

Better debugging experience in case of certain test failures.

Plugin Checklist

Additional Notes

In case the integration tests times out trying to create the sandbox,
don't also fail trying to remove it (since it doesn't exist).
@watson watson requested review from a team as code owners March 30, 2025 13:37
@watson watson self-assigned this Mar 30, 2025
Copy link
Collaborator Author

watson commented Mar 30, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Overall package size

Self size: 9.13 MB
Deduped: 101.66 MB
No deduping: 102.18 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Mar 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.11%. Comparing base (120b6b0) to head (d7becee).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5500      +/-   ##
==========================================
- Coverage   79.26%   79.11%   -0.16%     
==========================================
  Files         513      510       -3     
  Lines       23183    23031     -152     
==========================================
- Hits        18377    18221     -156     
- Misses       4806     4810       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: watson/improve-di-tests
Commit report: 597f3a7
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 919 Passed, 0 Skipped, 19m 42.06s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 30, 2025

Benchmarks

Benchmark execution time: 2025-03-30 13:45:31

Comparing candidate commit d7becee in PR branch watson/improve-di-tests with baseline commit 120b6b0 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 945 metrics, 18 unstable metrics.

@BridgeAR BridgeAR merged commit f62b60a into master Mar 31, 2025
435 checks passed
@BridgeAR BridgeAR deleted the watson/improve-di-tests branch March 31, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants