Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow @[email protected] #5503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maisano-patreon
Copy link

What does this PR do?

Allows for @opentelemetry/[email protected].

Motivation

A tracing regression due to using the latest version of @opentelemetry/api.

Plugin Checklist

Additional Notes

Happy to make whatever changes to land this.

Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maisano-patreon thank you for the PR. We still have a reference about the version in our main README.md. Can you please also update that?
I would actually update the text not to include any specific version range so that we do not have to update it every time.

I am not certain if we have to test for anything in particular/update something to make sure the instrumentation works for the new version as well.

@maisano-patreon
Copy link
Author

@BridgeAR Thanks for flagging the README reference. I removed the version specifier altogether and changed the language to be more broad. Also updated the package.json per your recommendation.

Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the CI being green. Sadly, we can't currently run the CI for external contributors, so I'll later on cherry-pick the commit and open a new PR with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants